Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33773

Assignment "View/grade all submissions" button breaks usability guidelines

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Assignment
    • Labels:

      Description

      This should be a link and not a button.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            $o seems like a very non-meaningful identifier.

            Show
            salvetore Michael de Raadt added a comment - $o seems like a very non-meaningful identifier.
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Hi Damyon
            I agree with what Michael said. But I guess changing that through out the file is beyond the scope of this issue. May be a separate improvement if it seems needed.
            Changes looks good.
            +1 for integration

            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Hi Damyon I agree with what Michael said. But I guess changing that through out the file is beyond the scope of this issue. May be a separate improvement if it seems needed. Changes looks good. +1 for integration Thanks
            Hide
            damyon Damyon Wiese added a comment -

            Thanks, I don't really want to make the change to rename $o to $output right now as I have a lot of work that is waiting until after 2.3 to submit and that change will likely cause lots of conflicts.

            I'll submit this for integration and create a new ticket for renaming the variable so we can do it later.

            Show
            damyon Damyon Wiese added a comment - Thanks, I don't really want to make the change to rename $o to $output right now as I have a lot of work that is waiting until after 2.3 to submit and that change will likely cause lots of conflicts. I'll submit this for integration and create a new ticket for renaming the variable so we can do it later.
            Hide
            salvetore Michael de Raadt added a comment -

            Yes, that's wise.

            I was a programming teacher for too long to let that slip by.

            Show
            salvetore Michael de Raadt added a comment - Yes, that's wise. I was a programming teacher for too long to let that slip by.
            Hide
            poltawski Dan Poltawski added a comment -

            Actually $o is quite common in renderers and helps avoid uncessarily long lines so I think its fine.

            Show
            poltawski Dan Poltawski added a comment - Actually $o is quite common in renderers and helps avoid uncessarily long lines so I think its fine.
            Hide
            poltawski Dan Poltawski added a comment -

            Hi Damyon,

            I don't think all these changes are correct. The view/edit to be a link yes.

            But the submit button is an action surely!

            Show
            poltawski Dan Poltawski added a comment - Hi Damyon, I don't think all these changes are correct. The view/edit to be a link yes. But the submit button is an action surely!
            Hide
            damyon Damyon Wiese added a comment -

            Hi Dan,

            You are right (I was thinking too literally before). I think the same applies for edit submission - so I changed that back to a button too.

            Show
            damyon Damyon Wiese added a comment - Hi Dan, You are right (I was thinking too literally before). I think the same applies for edit submission - so I changed that back to a button too.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks Damyon, i've integrated that now

            Show
            poltawski Dan Poltawski added a comment - Thanks Damyon, i've integrated that now
            Hide
            andyjdavis Andrew Davis added a comment -

            Passing.

            Show
            andyjdavis Andrew Davis added a comment - Passing.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay!

            Many, many thanks for your hard work!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay! Many, many thanks for your hard work! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12