Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33793

Assignment upgrade tool overwrites unrelated records in gradebook

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 2.3
    • 2.3
    • Assignment
    • MOODLE_23_STABLE
    • MOODLE_23_STABLE
    • Hide
      1. Perform a clean install of Moodle to a fresh database.
      2. Enable the Assignment 2.2 module
      3. Create a new course (does not require users)
      4. Add 1 quiz to the course (Just name it and leave everything at defaults)
      5. Add 1 assignment 2.2 online text to the course
      6. After this setup you should have 3 entries in the grade_items table all with iteminstance set to 1, the itemmodule column should be NULL, quiz and assignment.
      7. Upgrade the assignment instance
      8. After the upgrade the grade_item table should have 3 entries and the itemmodule column should be NULL, quiz and assign (without this fix, the itemmodule column for all three entries are updated to assign)
      Show
      Perform a clean install of Moodle to a fresh database. Enable the Assignment 2.2 module Create a new course (does not require users) Add 1 quiz to the course (Just name it and leave everything at defaults) Add 1 assignment 2.2 online text to the course After this setup you should have 3 entries in the grade_items table all with iteminstance set to 1, the itemmodule column should be NULL, quiz and assignment. Upgrade the assignment instance After the upgrade the grade_item table should have 3 entries and the itemmodule column should be NULL, quiz and assign (without this fix, the itemmodule column for all three entries are updated to assign)

    Description

      Reported by Michael Woods on MDL-33464.

      Assignment upgrade tool needs additional where clauses so it does not affect unrelated grade items. This is a serious bug and silently damages the data in the gradebook for anyone using the assignment upgrade tool.

      Attachments

        Issue Links

          Activity

            People

              damyon Damyon Wiese
              damyon Damyon Wiese
              Ankit Agarwal Ankit Agarwal
              Dan Poltawski Dan Poltawski
              Rajesh Taneja Rajesh Taneja
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                25/Jun/12