Moodle
  1. Moodle
  2. MDL-33795

Increase size of default file picker window

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.2
    • Component/s: Repositories
    • Labels:
    • Testing Instructions:
      Hide

      1. Make Equella repository "enabled and visible" (Site admin > Plugins > Repositories > Manage repositories)
      2. Go to "my private files"
      3. Click "add"
      4. Click Equella
      5. There should be no horizontal scrolling

      Show
      1. Make Equella repository "enabled and visible" (Site admin > Plugins > Repositories > Manage repositories) 2. Go to "my private files" 3. Click "add" 4. Click Equella 5. There should be no horizontal scrolling
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      wip-MDL-33795-master
    • Rank:
      41850

      Description

      It seems that the file picker will resizable by users in 2.3. This patch proposes that the file picker width is increased by 40px and height by 150px to provide a larger view for users browsing repository contents. The current window is slightly too narrow for the EQUELLA repository right now so regardless of this landing for 2.3, it would be recommended for EQUELLA clients to manually modify the width in the CSS to avoid horizontal scrolling. The height increase is a nice to have - it keeps the dialog somewhat in proportion to the increase in width, and also provides a much larger area to view.

      Tested locally on the latest Chrome and Firefox, plus on IE8.

        Issue Links

          Activity

          Hide
          Nick Read added a comment -

          Looking for thoughts on this.

          Show
          Nick Read added a comment - Looking for thoughts on this.
          Hide
          Michael de Raadt added a comment -

          Hi, Nick.

          I've fixed the roles around on this issue. Could you please push it to peer review again?

          Show
          Michael de Raadt added a comment - Hi, Nick. I've fixed the roles around on this issue. Could you please push it to peer review again?
          Hide
          Nick Read added a comment -

          Thanks Michael - I thought something funny was happening!

          Show
          Nick Read added a comment - Thanks Michael - I thought something funny was happening!
          Hide
          Nick Read added a comment -

          Added a screenshot to show the current problem.

          Show
          Nick Read added a comment - Added a screenshot to show the current problem.
          Hide
          Martin Dougiamas added a comment -

          OK, I tried this out.

          Unfortunately it seems the resizable filepicker is not going to be landing in 2.3 due to some lingering CSS issues. (I'll file and link a new issue about that)

          As a result increasing the fixed size a little would be good.

          I tried this patch but although Equella looks good it make the standard thumbnail screens look bad (we have 4 columns plus an unbalanced white space on the right).

          I think we're OK to increase the width by a whole icon (90px). This takes us just over the 800x600 range but is still well under 1024 and would increase usability for everyone (you can see more icons on the screen).

          Something like:

           /*
            * File Picker layout
            */
          -#filesskin .file-picker.fp-generallayout {width: 764px;background: #FFFFFF;border-radius:10px;border: 1px solid #CCCCCC;position: relative;}
          +#filesskin .file-picker.fp-generallayout {width: 840px;background: #FFFFFF;border-radius:10px;border: 1px solid #CCCCCC;position: relative;}
           .file-picker .fp-repo-area {width:180px;overflow:auto;display:inline-block;border-right:1px solid #BBBBBB;position:absolute;top:26px;bottom:1px;}
           .file-picker .fp-repo-items {vertical-align:top;display: inline-block;margin-left: 181px;}
           .file-picker .fp-navbar {background: #F2F2F2;min-height:22px;border-bottom: 1px solid #BBBBBB;padding: 5px 8px;}
          -.file-picker .fp-content {background: #FFFFFF;clear: both;overflow:auto;width: 583px;height: 500px;margin-bottom:-14px;}
          +.file-picker .fp-content {background: #FFFFFF;clear: both;overflow:auto;width: 660px;height: 500px;margin-bottom:-14px;}
           .file-picker .fp-content-loading {height: 100%;width: 100%;display: table;text-align:center;}
           .file-picker .fp-content .fp-object-container {width:100%;height:99%;}
          

          Barbara, can you test/finish this off?

          Show
          Martin Dougiamas added a comment - OK, I tried this out. Unfortunately it seems the resizable filepicker is not going to be landing in 2.3 due to some lingering CSS issues. (I'll file and link a new issue about that) As a result increasing the fixed size a little would be good. I tried this patch but although Equella looks good it make the standard thumbnail screens look bad (we have 4 columns plus an unbalanced white space on the right). I think we're OK to increase the width by a whole icon (90px). This takes us just over the 800x600 range but is still well under 1024 and would increase usability for everyone (you can see more icons on the screen). Something like: /* * File Picker layout */ -#filesskin .file-picker.fp-generallayout {width: 764px;background: #FFFFFF;border-radius:10px;border: 1px solid #CCCCCC;position: relative;} +#filesskin .file-picker.fp-generallayout {width: 840px;background: #FFFFFF;border-radius:10px;border: 1px solid #CCCCCC;position: relative;} .file-picker .fp-repo-area {width:180px;overflow:auto;display:inline-block;border-right:1px solid #BBBBBB;position:absolute;top:26px;bottom:1px;} .file-picker .fp-repo-items {vertical-align:top;display: inline-block;margin-left: 181px;} .file-picker .fp-navbar {background: #F2F2F2;min-height:22px;border-bottom: 1px solid #BBBBBB;padding: 5px 8px;} -.file-picker .fp-content {background: #FFFFFF;clear: both;overflow:auto;width: 583px;height: 500px;margin-bottom:-14px;} +.file-picker .fp-content {background: #FFFFFF;clear: both;overflow:auto;width: 660px;height: 500px;margin-bottom:-14px;} .file-picker .fp-content-loading {height: 100%;width: 100%;display: table;text-align:center;} .file-picker .fp-content .fp-object-container {width:100%;height:99%;} Barbara, can you test/finish this off?
          Hide
          Martin Dougiamas added a comment -

          Dammit we dropped the ball on this one. Barbara can you please make sure you comment when you update the code fields?

          It's good to go, right?

          Show
          Martin Dougiamas added a comment - Dammit we dropped the ball on this one. Barbara can you please make sure you comment when you update the code fields? It's good to go, right?
          Hide
          Barbara Ramiro added a comment -

          yes, good to go

          Show
          Barbara Ramiro added a comment - yes, good to go
          Hide
          Sam Hemelryk added a comment -

          Thanks guys, this has been integrated now.
          Just noting despite this being an improvement I have backported it to 2.3 as I feel it is a good improvement.

          Barbara could you please add some testing instructions.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks guys, this has been integrated now. Just noting despite this being an improvement I have backported it to 2.3 as I feel it is a good improvement. Barbara could you please add some testing instructions. Cheers Sam
          Hide
          Barbara Ramiro added a comment -

          I just did Sam. Cheers

          Show
          Barbara Ramiro added a comment - I just did Sam. Cheers
          Hide
          Dan Poltawski added a comment -

          Martin/Nick. The equella test site doesn't appear to be working. I've asked David to pass this because the other repos are working fine.

          (BTW I think this makes repos with a big single 'search' box look really lonely now.)

          Show
          Dan Poltawski added a comment - Martin/Nick. The equella test site doesn't appear to be working. I've asked David to pass this because the other repos are working fine. (BTW I think this makes repos with a big single 'search' box look really lonely now.)
          Hide
          David Monllaó added a comment -

          Tested in master and in 2.3. Passes since the new styles are applied, but there is no available equella demo repository to test it on.

          Show
          David Monllaó added a comment - Tested in master and in 2.3. Passes since the new styles are applied, but there is no available equella demo repository to test it on.
          Hide
          Simon Wilkinson added a comment -

          We have had a network outage. Should be back online tomorrow.

          Show
          Simon Wilkinson added a comment - We have had a network outage. Should be back online tomorrow.
          Hide
          Nick Read added a comment -

          Sorry about the test environment being down - the office move has taken out all our office-hosted services, but it should be back up today crosses fingers. If you want a more permanent testing instance of EQUELLA hosted at Moodle HQ, just shout out and it can be organised.

          Show
          Nick Read added a comment - Sorry about the test environment being down - the office move has taken out all our office-hosted services, but it should be back up today crosses fingers . If you want a more permanent testing instance of EQUELLA hosted at Moodle HQ, just shout out and it can be organised.
          Hide
          Dan Poltawski added a comment -

          Congratulations!

          You've made it into the weekly release!

          Thanks for your contribution - here are some random drummers to keep you inspired for the next week!
          http://www.youtube.com/watch?v=_QhpHUmVCmY

          Show
          Dan Poltawski added a comment - Congratulations! You've made it into the weekly release! Thanks for your contribution - here are some random drummers to keep you inspired for the next week! http://www.youtube.com/watch?v=_QhpHUmVCmY

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: