Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.2.3
-
Component/s: Glossary
-
Testing Instructions:
-
Affected Branches:MOODLE_22_STABLE
-
Fixed Branches:MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-33796-master -
Pull Master Diff URL:
Description
- Create a new glossary, add an entry which concept starts with a number
- Navigate to the glossary, alphabet view, filter by 'Special'
- Click on the print icon
Invalid get_string() identifier: 'alphabet' or component 'moodle'. Perhaps you are missing $string['alphabet'] = ''; in lang/en/moodle.php?
|
|
|
line 6583 of /lib/moodlelib.php: call to debugging()
|
line 7207 of /lib/moodlelib.php: call to core_string_manager->get_string()
|
line 168 of /mod/glossary/print.php: call to get_string()
|
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
fred, you may as well submit that patch, looks good to me!
This can easily be cherry-picked in 2.2 and 2.3
setting peer-reviewer to Dan and sending up for integration.
Integrated (21, 22, 23 and master). Thanks!
Fred, Dan and Eloy, testing instructions required. tisk tisk. 
Works as described. Passing.
The testing instructions were in the description! 
Congratulations your code is upstream - gold star for you!
This issue + 79 others made it in in time for the minor releases.
Thank you everyone involved for your exuberant efforts.
Looks like $alphabet is not used anymore.
diff --git a/mod/glossary/print.php b/mod/glossary/print.phpindex 8421481..2df4413 100644--- a/mod/glossary/print.php+++ b/mod/glossary/print.php@@ -164,9 +164,6 @@ include_once("sql.php");$entriesshown = 0;$currentpivot = '';-if ( $hook == 'SPECIAL' ) {- $alphabet = explode(",", get_string("alphabet"));-}$site = $DB->get_record("course", array("id"=>1));echo '<p style="text-align:right"><span style="font-size:0.75em">' . userdate(time()) . '</span></p>';