Moodle
  1. Moodle
  2. MDL-33796

Get string notice in glossary printing alphabet

    Details

    • Testing Instructions:
      Hide
      1. Set debug level to developer
      2. Create a new glossary, add an entry which concept starts with a number
      3. Navigate to the glossary, alphabet view, filter by 'Special'
      4. Click on the print icon
      5. Make sure you don't see any notice/errors on the print page
      Show
      Set debug level to developer Create a new glossary, add an entry which concept starts with a number Navigate to the glossary, alphabet view, filter by 'Special' Click on the print icon Make sure you don't see any notice/errors on the print page
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33796-master
    • Rank:
      41855

      Description

      1. Create a new glossary, add an entry which concept starts with a number
      2. Navigate to the glossary, alphabet view, filter by 'Special'
      3. Click on the print icon
      Invalid get_string() identifier: 'alphabet' or component 'moodle'. Perhaps you are missing $string['alphabet'] = ''; in lang/en/moodle.php?
      
          line 6583 of /lib/moodlelib.php: call to debugging()
          line 7207 of /lib/moodlelib.php: call to core_string_manager->get_string()
          line 168 of /mod/glossary/print.php: call to get_string()
      

        Activity

        Hide
        Frédéric Massart added a comment -

        Looks like $alphabet is not used anymore.

        diff --git a/mod/glossary/print.php b/mod/glossary/print.php
        index 8421481..2df4413 100644
        --- a/mod/glossary/print.php
        +++ b/mod/glossary/print.php
        @@ -164,9 +164,6 @@ include_once("sql.php");
         
         $entriesshown = 0;
         $currentpivot = '';
        -if ( $hook == 'SPECIAL' ) {
        -    $alphabet = explode(",", get_string("alphabet"));
        -}
         
         $site = $DB->get_record("course", array("id"=>1));
         echo '<p style="text-align:right"><span style="font-size:0.75em">' . userdate(time()) . '</span></p>';
        
        Show
        Frédéric Massart added a comment - Looks like $alphabet is not used anymore. diff --git a/mod/glossary/print.php b/mod/glossary/print.php index 8421481..2df4413 100644 --- a/mod/glossary/print.php +++ b/mod/glossary/print.php @@ -164,9 +164,6 @@ include_once( "sql.php" ); $entriesshown = 0; $currentpivot = ''; - if ( $hook == 'SPECIAL' ) { - $alphabet = explode( "," , get_string( "alphabet" )); -} $site = $DB->get_record( "course" , array( "id" =>1)); echo '<p style= "text-align:right" ><span style= "font-size:0.75em" >' . userdate(time()) . '</span></p>';
        Hide
        Dan Poltawski added a comment -

        fred, you may as well submit that patch, looks good to me!

        Show
        Dan Poltawski added a comment - fred, you may as well submit that patch, looks good to me!
        Hide
        Frédéric Massart added a comment -

        This can easily be cherry-picked in 2.2 and 2.3

        Show
        Frédéric Massart added a comment - This can easily be cherry-picked in 2.2 and 2.3
        Hide
        Aparup Banerjee added a comment -

        setting peer-reviewer to Dan and sending up for integration.

        Show
        Aparup Banerjee added a comment - setting peer-reviewer to Dan and sending up for integration.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (21, 22, 23 and master). Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (21, 22, 23 and master). Thanks!
        Hide
        Andrew Davis added a comment -

        Fred, Dan and Eloy, testing instructions required. tisk tisk.

        Show
        Andrew Davis added a comment - Fred, Dan and Eloy, testing instructions required. tisk tisk.
        Hide
        Andrew Davis added a comment -

        Works as described. Passing.

        Show
        Andrew Davis added a comment - Works as described. Passing.
        Hide
        Dan Poltawski added a comment -

        The testing instructions were in the description!

        Show
        Dan Poltawski added a comment - The testing instructions were in the description!
        Hide
        Sam Hemelryk added a comment -

        Congratulations your code is upstream - gold star for you!

        This issue + 79 others made it in in time for the minor releases.
        Thank you everyone involved for your exuberant efforts.

        Show
        Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: