Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33799

/backup/restorefile.php should check the return value of $form->save_file()

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Inactive
    • Affects Version/s: 2.3
    • Fix Version/s: None
    • Component/s: Backup, Files API
    • Labels:
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_23_STABLE

      Description

      While diagnosing a problem with MDL-27156 I noticed that we're not checking the return value of save_file(). That means that if there's a problem with the backup file we don't give an error until we go to read that file out of the user's draft files area much later in the process.

      If we fail to pull in the file from the repository we should stop immediately.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              andyjdavis Andrew Davis
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: