Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33811

if test for gallery version in yui_module is broken

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.6, 2.2.3, 2.3
    • Fix Version/s: 2.1.7, 2.2.4
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide
      1. No testing required. This code is not presently used in core.
        In 2.0 we had a gallery module in core, however it was removed before the release of 2.1.

      If you want to test it you would need to install two version of a gallery module, write a use for the older version of the gallery module and then execute the use and check the code to make sure you were delivered the desired version.

      Show
      No testing required. This code is not presently used in core. In 2.0 we had a gallery module in core, however it was removed before the release of 2.1. If you want to test it you would need to install two version of a gallery module, write a use for the older version of the gallery module and then execute the use and check the code to make sure you were delivered the desired version.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      wip-MDL-33811-m23

      Description

      See http://git.moodle.org/gw?p=moodle.git;a=blob;f=lib/outputrequirementslib.php;h=c4fdd8f200ce4d19ec780bdabadf151dd116a0aa;hb=master#l752

      if (empty($CFG->useexternalyui) || true) {
        ...
      } else {
        ...
      }

      This test can never fail. I don't think that any core modules actually use it mind...

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jul/12