[MDL-33811] if test for gallery version in yui_module is broken - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/samhemelryk/moodle.git
Pull Master Branch:
wip-~~MDL-33811~~-m23
Pull Master Diff URL:
https://github.com/samhemelryk/moodle/compare/master...wip-MDL-33811-m23
Testing Instructions:
Hide

No testing required. This code is not presently used in core.
In 2.0 we had a gallery module in core, however it was removed before the release of 2.1.

If you want to test it you would need to install two version of a gallery module, write a use for the older version of the gallery module and then execute the use and check the code to make sure you were delivered the desired version.
Show
No testing required. This code is not presently used in core. In 2.0 we had a gallery module in core, however it was removed before the release of 2.1. If you want to test it you would need to install two version of a gallery module, write a use for the older version of the gallery module and then execute the use and check the code to make sure you were delivered the desired version.

if (empty($CFG->useexternalyui) || true) {

...

} else {

...

This test can never fail. I don't think that any core modules actually use it mind...

Participants:: Andrew Lyons, Aparup Banerjee, Dan Poltawski, Eloy Lafuente (stronk7), Petr Skoda, Sam Hemelryk

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)