Moodle

if test for gallery version in yui_module is broken

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1.6, 2.2.3, 2.3
  • Fix Version/s: 2.1.7, 2.2.4
  • Component/s: Libraries
  • Labels:
  • Testing Instructions:
    Hide
    1. No testing required. This code is not presently used in core.
      In 2.0 we had a gallery module in core, however it was removed before the release of 2.1.

    If you want to test it you would need to install two version of a gallery module, write a use for the older version of the gallery module and then execute the use and check the code to make sure you were delivered the desired version.

    Show
    No testing required. This code is not presently used in core. In 2.0 we had a gallery module in core, however it was removed before the release of 2.1. If you want to test it you would need to install two version of a gallery module, write a use for the older version of the gallery module and then execute the use and check the code to make sure you were delivered the desired version.
  • Affected Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    wip-MDL-33811-m23
  • Pull Master Diff URL:

Description

See http://git.moodle.org/gw?p=moodle.git;a=blob;f=lib/outputrequirementslib.php;h=c4fdd8f200ce4d19ec780bdabadf151dd116a0aa;hb=master#l752

if (empty($CFG->useexternalyui) || true) {
  ...
} else {
  ...
}

This test can never fail. I don't think that any core modules actually use it mind...

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda added a comment -

Reassigning - Sam, this is your code, right?

Show
Petr Škoda added a comment - Reassigning - Sam, this is your code, right?
Hide
Permalink
Sam Hemelryk added a comment -

Hehe thanks for spotting that Andrew, I must've left that in there from when I was testing it originally.

I've fixed that up and put this straight up for integration.

Cheers
Sam

Show
Sam Hemelryk added a comment - Hehe thanks for spotting that Andrew, I must've left that in there from when I was testing it originally. I've fixed that up and put this straight up for integration. Cheers Sam
Hide
Permalink
Dan Poltawski added a comment -

Glossary test?

Show
Dan Poltawski added a comment - Glossary test?
Hide
Permalink
Andrew Nicols added a comment -

Is this a better description? Really hard to get something good!

Show
Andrew Nicols added a comment - Is this a better description? Really hard to get something good!
Hide
Permalink
Dan Poltawski added a comment -

'glossary'??

Show
Dan Poltawski added a comment - 'glossary'??
Hide
Permalink
Andrew Nicols added a comment -

ahem... gallery

Show
Andrew Nicols added a comment - ahem... gallery
Hide
Permalink
Aparup Banerjee added a comment -

thanks, truly integrated into 21,22 and master.

Show
Aparup Banerjee added a comment - thanks, truly integrated into 21,22 and master.
Hide
Permalink
Aparup Banerjee added a comment -

passing!

Show
Aparup Banerjee added a comment - passing!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay!

Many, many thanks for your hard work!

Ciao

Show
Eloy Lafuente (stronk7) added a comment - And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay! Many, many thanks for your hard work! Ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: