Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33814

Improve html_table hadling of html_table_cell objects

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.2.4, 2.3.1
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      1. Find some bits of the Moodle UI that use html_tables. The quiz view.php and summary.php are good examples.

      2. Make sure there are no regressions.

      Show
      1. Find some bits of the Moodle UI that use html_tables. The quiz view.php and summary.php are good examples. 2. Make sure there are no regressions.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33814-master
    • Pull Master Diff URL:

      Description

      Although MDL-30886 was wont-fixed, the proposed change to lib/outputcomponents.php was good. Basically, in one place, it was not checking if the table cell contents was already a html_table_cell, and was just assuming that a string was passed in. It is a simple, backwards-compatible API improvement to make it check that.

        Attachments

          Issue Links

          has a non-specific relationship to

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-30886 quiz summary table should have additional table headers

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              • Assignee:
                fred Frédéric Massart
                Reporter:
                timhunt Tim Hunt
                Peer reviewer:
                Dan Poltawski
                Integrator:
                Sam Hemelryk
                Tester:
                Ankit Agarwal
                Participants:
                Component watchers:
                Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jul/12