Moodle
  1. Moodle
  2. MDL-33814

Improve html_table hadling of html_table_cell objects

        Details

        • Type: Improvement Improvement
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.3
        • Fix Version/s: 2.2.4, 2.3.1
        • Component/s: Libraries
        • Labels:
        • Testing Instructions:
          Hide

          1. Find some bits of the Moodle UI that use html_tables. The quiz view.php and summary.php are good examples.

          2. Make sure there are no regressions.

          Show
          1. Find some bits of the Moodle UI that use html_tables. The quiz view.php and summary.php are good examples. 2. Make sure there are no regressions.
        • Affected Branches:
          MOODLE_23_STABLE
        • Fixed Branches:
          MOODLE_22_STABLE, MOODLE_23_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-33814-master
        • Pull Master Diff URL:
        • Rank:
          41900

          Description

          Although MDL-30886 was wont-fixed, the proposed change to lib/outputcomponents.php was good. Basically, in one place, it was not checking if the table cell contents was already a html_table_cell, and was just assuming that a string was passed in. It is a simple, backwards-compatible API improvement to make it check that.

            Issue Links

            has a non-specific relationship to

            Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-30886 quiz summary table should have additional table headers

            • Minor - Minor loss of function where workaround is possible
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Frédéric Massart added a comment -

              I believe this can be cherry-picked in 2.x if wanted.

              Show
              Frédéric Massart added a comment - I believe this can be cherry-picked in 2.x if wanted.
              Hide
              Permalink
              Dan Poltawski added a comment -

              +1 here Fred - thanks!

              Show
              Dan Poltawski added a comment - +1 here Fred - thanks!
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Thanks Fred, this has been integrated now and backported.

              Show
              Sam Hemelryk added a comment - Thanks Fred, this has been integrated now and backported.
              Hide
              Permalink
              Ankit Agarwal added a comment -

              I was not able to identify any regressions.
              Everything looks as it was before.
              Passing.
              Thanks

              Show
              Ankit Agarwal added a comment - I was not able to identify any regressions. Everything looks as it was before. Passing. Thanks
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Congratulations your code is upstream - gold star for you!

              This issue + 79 others made it in in time for the minor releases.
              Thank you everyone involved for your exuberant efforts.

              Show
              Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: