Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33814

Improve html_table hadling of html_table_cell objects

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • 2.2.4, 2.3.1
    • 2.3
    • Libraries
    • MOODLE_23_STABLE
    • MOODLE_22_STABLE, MOODLE_23_STABLE
    • MDL-33814-master
    • Hide

      1. Find some bits of the Moodle UI that use html_tables. The quiz view.php and summary.php are good examples.

      2. Make sure there are no regressions.

      Show
      1. Find some bits of the Moodle UI that use html_tables. The quiz view.php and summary.php are good examples. 2. Make sure there are no regressions.

    Description

      Although MDL-30886 was wont-fixed, the proposed change to lib/outputcomponents.php was good. Basically, in one place, it was not checking if the table cell contents was already a html_table_cell, and was just assuming that a string was passed in. It is a simple, backwards-compatible API improvement to make it check that.

      Attachments

        Issue Links

          Activity

            People

              fred Frédéric Massart
              timhunt Tim Hunt
              Dan Poltawski Dan Poltawski
              Sam Hemelryk Sam Hemelryk
              Ankit Agarwal Ankit Agarwal
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.