[MDL-33815] Users stuck in Online Users block - Moodle Tracker

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.2.3, 2.2.5
Fix Version/s: 2.2.6, 2.3.3
Component/s: Blocks
Labels:
- patch
- triaged

Testing Instructions:
Hide

As Admin, enable "Online user" block on a course and frontpage

Enrol a student to the course

check that user is display online online within the block (course and frontpage)

In frontpage:

Access the user table in DB and change the student lastaccess field to the past (eg: 1149936122)

Refresh the page and make sure student name is not display within the block

Access the user table in DB and change the student lastaccess field to the future (eg: 3349936122)

Refresh the page and make sure student name is not display within the block

In a course page:

Access the user_lastaccess table in DB and change the student timeaccess field to the past (eg: 1149936122)

Refresh the page and make sure student name is not display within the block

Access the user_lastaccess table in DB and change the student timeaccess field to the future (eg: 3349936122)

Refresh the page and make sure student name is not display within the block

Make sure there's no error display on the page.
Show
As Admin, enable "Online user" block on a course and frontpage Enrol a student to the course check that user is display online online within the block (course and frontpage) In frontpage: Access the user table in DB and change the student lastaccess field to the past (eg: 1149936122) Refresh the page and make sure student name is not display within the block Access the user table in DB and change the student lastaccess field to the future (eg: 3349936122) Refresh the page and make sure student name is not display within the block In a course page: Access the user_lastaccess table in DB and change the student timeaccess field to the past (eg: 1149936122) Refresh the page and make sure student name is not display within the block Access the user_lastaccess table in DB and change the student timeaccess field to the future (eg: 3349936122) Refresh the page and make sure student name is not display within the block Make sure there's no error display on the page.
Affected Branches:
MOODLE_22_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/rwijaya/moodle.git
Pull Master Branch:
~~MDL-33815~~
Pull Master Diff URL:
https://github.com/rwijaya/moodle/compare/master...MDL-33815

Description

If there are users in the database that have an invalid lastaccess, lastlogin or currentlogin timestamp in the mdl_user table, or have an invalid record in the mdl_user_lastaccess they will be stuck in the Online block, even if they are deleted.

Fix: add "AND deleted = 0" to line 61 and 84 in /block/online_users/block_online_users.php

Gliffy Diagrams

Attachments

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Michael de Raadt added a comment - 19/Jun/12 9:32 AM

"It's a trap!". (Let me out of here!)

Thanks for reporting that and providing a solution. Perhaps it's also worth checking that the time range is less than now.

Show

Michael de Raadt added a comment - 19/Jun/12 9:32 AM "It's a trap!". (Let me out of here!) Thanks for reporting that and providing a solution. Perhaps it's also worth checking that the time range is less than now.

Hide

Permalink

Mary Cooch added a comment - 14/Aug/12 2:13 PM

Interesting..I wonder if this is what happened to these guys who have been stuck in the Moodle lounge for over a week? http://moodle.org/mod/forum/discuss.php?d=208486

Show

Mary Cooch added a comment - 14/Aug/12 2:13 PM Interesting..I wonder if this is what happened to these guys who have been stuck in the Moodle lounge for over a week? http://moodle.org/mod/forum/discuss.php?d=208486

Hide

Permalink

David Bezemer added a comment - 16/Aug/12 4:32 PM

As far as I can see this behaviour happens when the users existed in a very old version of Moodle, and were deleted there.
From what I could see their timestamps are set to a number somewhere in 2038 or so.

One of the setups I noticed this with was an environment that started at Moodle 1.8 and was subsequently upgraded to Moodle 2.
So a complete fix for the problem would include an upgrade check for invalid timestamps (> NOW) and correct them, for instance to NOW

Show

David Bezemer added a comment - 16/Aug/12 4:32 PM As far as I can see this behaviour happens when the users existed in a very old version of Moodle, and were deleted there. From what I could see their timestamps are set to a number somewhere in 2038 or so. One of the setups I noticed this with was an environment that started at Moodle 1.8 and was subsequently upgraded to Moodle 2. So a complete fix for the problem would include an upgrade check for invalid timestamps (> NOW) and correct them, for instance to NOW

Hide

Permalink

Rossiani Wijaya added a comment - 11/Oct/12 3:39 PM

Hi David,

Thank you for providing solution for the issue.

I'm not convince to update the timestamps to now within the upgrade. I think the issue might occurs during the process of backup/restore/converting process from 1.8 to 2.x.

Therefore, I'm only fixing the 'online_user' block display.

Sending for peer-review.

Show

Rossiani Wijaya added a comment - 11/Oct/12 3:39 PM Hi David, Thank you for providing solution for the issue. I'm not convince to update the timestamps to now within the upgrade. I think the issue might occurs during the process of backup/restore/converting process from 1.8 to 2.x. Therefore, I'm only fixing the 'online_user' block display. Sending for peer-review.

Hide

Permalink

Ankit Agarwal added a comment - 11/Oct/12 4:13 PM

Hi Rosie,

Patch looks good to me.

[Y] Syntax
[Y] Output
[Y] Whitespace
[-] Language
[y] Databases
[Y] Testing
[-] Security
[-] Documentation
[Y] Git
[Y] Sanity check

Thanks

Show

Ankit Agarwal added a comment - 11/Oct/12 4:13 PM Hi Rosie, Patch looks good to me. [Y] Syntax [Y] Output [Y] Whitespace [-] Language [y] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check Thanks

Hide

Permalink

Rossiani Wijaya added a comment - 11/Oct/12 4:24 PM

Thanks Ankit for reviewing.

Submitting for integration review.

Show

Rossiani Wijaya added a comment - 11/Oct/12 4:24 PM Thanks Ankit for reviewing. Submitting for integration review.

Hide

Permalink

Dan Poltawski added a comment - 16/Oct/12 11:11 AM

Integrated thanks Rosie.

TO TESTER: Please be sure to test this in the different scenarios in the testing instructions, different code paths are followed and its very important we ensure this is all covered.

Show

Dan Poltawski added a comment - 16/Oct/12 11:11 AM Integrated thanks Rosie. TO TESTER: Please be sure to test this in the different scenarios in the testing instructions, different code paths are followed and its very important we ensure this is all covered.

Hide

Permalink

David Monllaó added a comment - 17/Oct/12 10:42 AM

It passes, tested in 22 and master

Show

David Monllaó added a comment - 17/Oct/12 10:42 AM It passes, tested in 22 and master

Hide

Permalink

Aparup Banerjee added a comment - 18/Oct/12 9:25 PM

Your issue has dug up some gold.
It works great i've been told.
Go forth, be brave, be bold.

yay! "All your thoughts are belong to everyone."

Thanks and ciao!

Show

Aparup Banerjee added a comment - 18/Oct/12 9:25 PM Your issue has dug up some gold. It works great i've been told. Go forth, be brave, be bold. yay! "All your thoughts are belong to everyone." Thanks and ciao!

People

Assignee:

Rossiani Wijaya

Reporter:

David Bezemer

Peer reviewer:

Ankit Agarwal

Integrator:

Dan Poltawski

Tester:

David Monllaó

Participants:

Ankit Agarwal, Aparup Banerjee, Dan Poltawski, David Bezemer, David Monllaó, Mary Cooch, Michael de Raadt, Rossiani Wijaya

Votes:

1 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

18/Jun/12 6:27 PM

Updated:

30/Sep/13 1:08 PM

Resolved:

18/Oct/12 9:25 PM

Fix Release Date:

12/Nov/12