Moodle
  1. Moodle
  2. MDL-33829

Exporting glossary entry with rich decription to portfolio

    Details

    • Testing Instructions:
      Hide

      Make sure the site setting "enableportfolios" is enabled.

      1. Create a new glossary
      2. Add an entry containing only text
      3. Add an entry containing text and an image in the description
      4. Add an entry with text in description and an image as attachment

      Export each of the entries to a range of the available portfolios. Go to /admin/portfolio.php to turn them on and off. You need to enable one portfolio, export the various entries, disable that portfolio and enable a different one.

      Some entries will not be able to be exported to some portfolio types. For example entries with an image attached or in the description cannot be exported to google docs.

      Show
      Make sure the site setting "enableportfolios" is enabled. Create a new glossary Add an entry containing only text Add an entry containing text and an image in the description Add an entry with text in description and an image as attachment Export each of the entries to a range of the available portfolios. Go to /admin/portfolio.php to turn them on and off. You need to enable one portfolio, export the various entries, disable that portfolio and enable a different one. Some entries will not be able to be exported to some portfolio types. For example entries with an image attached or in the description cannot be exported to google docs.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      wip-MDL-33829-master

      Description

      1. Create a new glossary
      2. Add an entry containing only text
      3. Add an entry containing text and an image in the description
      4. Add an entry with text in description and an image as attachment
      5. Export each of the entries to any portfolio

      Actual result:

      • When exporting the entry with image in the description (to file download/Google Docs in my case), an exception is raised:

      Failed to package up your data for export: original error was Rewriting file output is not supported for this format
       
      More information about this error
      Debug info:
      Error code: callercouldnotpackage
      Stack trace:
       
          line 453 of /lib/portfolio/exporter.php: portfolio_export_exception thrown
          line 227 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage_package()
          line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()
          line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()
          line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()
          line 268 of /portfolio/add.php: call to portfolio_exporter->process_stage()

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Frédéric Massart added a comment -

            Assigning to Jason

            Show
            Frédéric Massart added a comment - Assigning to Jason
            Hide
            Jason Fowler added a comment -

            Thanks Fred

            Show
            Jason Fowler added a comment - Thanks Fred
            Hide
            Jason Fowler added a comment -

            Estimated time to fix: 10 hours

            Show
            Jason Fowler added a comment - Estimated time to fix: 10 hours
            Hide
            Dan Poltawski added a comment -

            I'm very unfamiliar, but my guess from a brief investigation into the code:

            glossary_entry_portfolio_caller is setting the general formats the plugin supports - see base_supported_formats(), it can't actually work out what format it is until the time of export. Because it doesn't know if it contains images or note.

            At the time of export I don't think we are specialising enough, so you are getting the fileoutputnotsupported exception, that comes from class portfolio_format_file::file_output() and I think the problem is that its not specialised enough.

            The problem is similar in mod_forum, and I notice this code in load_data:

                  // depending on whether there are files or not, we might have to change richhtml/plainhtml
                    if (empty($this->attachment)) {
                        if (!empty($this->multifiles)) {
                            $this->add_format(PORTFOLIO_FORMAT_RICHHTML);
                        } else {
                            $this->add_format(PORTFOLIO_FORMAT_PLAINHTML);
                        }
                    }
            

            So maybe in your load_data() function needs to set the add_format() like above.

            Show
            Dan Poltawski added a comment - I'm very unfamiliar, but my guess from a brief investigation into the code: glossary_entry_portfolio_caller is setting the general formats the plugin supports - see base_supported_formats(), it can't actually work out what format it is until the time of export. Because it doesn't know if it contains images or note. At the time of export I don't think we are specialising enough, so you are getting the fileoutputnotsupported exception, that comes from class portfolio_format_ file::file_output( ) and I think the problem is that its not specialised enough. The problem is similar in mod_forum, and I notice this code in load_data: // depending on whether there are files or not, we might have to change richhtml/plainhtml if (empty($this->attachment)) { if (!empty($this->multifiles)) { $this->add_format(PORTFOLIO_FORMAT_RICHHTML); } else { $this->add_format(PORTFOLIO_FORMAT_PLAINHTML); } } So maybe in your load_data() function needs to set the add_format() like above.
            Hide
            Jason Fowler added a comment -

            Hope what I've done is right - it seems to work, just not 100% sure it's best ...

            Show
            Jason Fowler added a comment - Hope what I've done is right - it seems to work, just not 100% sure it's best ...
            Hide
            Frédéric Massart added a comment - - edited

            Jason, I was having a quick look at your patch, and I noticed this method portfolio_caller_base::set_formats_from_button(), which seems not to return the correct information.

            Changing:

            $this->supportedformats = portfolio_most_specific_formats($formats, $formats);
            

            To:

            $this->supportedformats = portfolio_most_specific_formats($formats, $base);
            

            Could resolve the issue without having to re set the format. Assuming mod/glossary/lib.php:1285 reflects your changes.

            I also discovered another issue which I will link to this one.

            Show
            Frédéric Massart added a comment - - edited Jason, I was having a quick look at your patch, and I noticed this method portfolio_caller_base::set_formats_from_button(), which seems not to return the correct information. Changing: $this->supportedformats = portfolio_most_specific_formats($formats, $formats); To: $this->supportedformats = portfolio_most_specific_formats($formats, $base); Could resolve the issue without having to re set the format. Assuming mod/glossary/lib.php:1285 reflects your changes. I also discovered another issue which I will link to this one.
            Hide
            Jason Fowler added a comment -

            I had a look at your suggestions, and can't seem to figure out how they would be better than the change I have put forward. Might need someone like Dan or Sam to have a look here

            Show
            Jason Fowler added a comment - I had a look at your suggestions, and can't seem to figure out how they would be better than the change I have put forward. Might need someone like Dan or Sam to have a look here
            Hide
            Sam Hemelryk added a comment - - edited

            Hi guys,

            I was just looking at this, first in regards to Fred's comment about.

            Having only read the code it appears to me that there is no difference between using $formats or $base as the second argument, the code above has asseratined that both arrays contain the exact same items.

            That bit of code within portfolio_caller_base::set_formats_from_button appears to be doing the following (in simplified english):

            function set_formats_from_button ( selected formats ) {
                get all of the base formats
                If the selected formats array is at all different to the base formats array
                    set the supported formats with the selected formats and the base formats
                otherwise
                    // the selected formats are the same as the base formats
                    set the supported formats with the selected formats for both arguments
            }
            

            Would you mind having a read of it again please Fred.

            Cheers
            Sam

            edited: I forgot to add something: that bit of code doesn't add up, the todo there obviously echo's someone elses suspicions about it as well.

            Show
            Sam Hemelryk added a comment - - edited Hi guys, I was just looking at this, first in regards to Fred's comment about. Having only read the code it appears to me that there is no difference between using $formats or $base as the second argument, the code above has asseratined that both arrays contain the exact same items. That bit of code within portfolio_caller_base::set_formats_from_button appears to be doing the following (in simplified english): function set_formats_from_button ( selected formats ) { get all of the base formats If the selected formats array is at all different to the base formats array set the supported formats with the selected formats and the base formats otherwise // the selected formats are the same as the base formats set the supported formats with the selected formats for both arguments } Would you mind having a read of it again please Fred. Cheers Sam edited: I forgot to add something: that bit of code doesn't add up, the todo there obviously echo's someone elses suspicions about it as well.
            Hide
            Jason Fowler added a comment -

            Hi Sam,

            Fred's comment isn't really related to the patch I posted, or the issue at hand as far as I can tell ...

            Thanks for looking this over though

            Show
            Jason Fowler added a comment - Hi Sam, Fred's comment isn't really related to the patch I posted, or the issue at hand as far as I can tell ... Thanks for looking this over though
            Hide
            Michael de Raadt added a comment -

            Carrying this over to the next sprint and noting that Jason will be away for the first two weeks of the sprint.

            Show
            Michael de Raadt added a comment - Carrying this over to the next sprint and noting that Jason will be away for the first two weeks of the sprint.
            Hide
            Frédéric Massart added a comment -

            Hi Sam,

            I only had a quick look, and was most certainly wrong as you both point it out that it was not related. The only thing I noticed which could be relevant is the set_formats_from_button() called from mod/glossary/lib.php:1285, but again as Jason mentioned, it is not directly related to this issue.

            Show
            Frédéric Massart added a comment - Hi Sam, I only had a quick look, and was most certainly wrong as you both point it out that it was not related. The only thing I noticed which could be relevant is the set_formats_from_button() called from mod/glossary/lib.php:1285, but again as Jason mentioned, it is not directly related to this issue.
            Hide
            Adrian Greeve added a comment -

            Hi guys,

            I had a look at the patch and while I was trying to run it I encountered this error:

            No common formats between any available portfolio plugin and the calling location glossary_entry_portfolio_caller (caller supported )
            Debug info:
            Error code: nocommonformats
            Stack trace:
             
                line 287 of /lib/portfolio/exporter.php: portfolio_export_exception thrown
                line 227 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage_config()
                line 268 of /portfolio/add.php: call to portfolio_exporter->process_stage()
            

            Exporting entries without images or attachments still works OK.

            Show
            Adrian Greeve added a comment - Hi guys, I had a look at the patch and while I was trying to run it I encountered this error: No common formats between any available portfolio plugin and the calling location glossary_entry_portfolio_caller (caller supported ) Debug info: Error code: nocommonformats Stack trace:   line 287 of /lib/portfolio/exporter.php: portfolio_export_exception thrown line 227 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage_config() line 268 of /portfolio/add.php: call to portfolio_exporter->process_stage() Exporting entries without images or attachments still works OK.
            Hide
            Andrew Davis added a comment - - edited

            I'm just familiarizing myself with this now. I've been able to export glossary entries without images, with an image in the description and with an image attached via the file download portfolio. Adrian said in chat he ran into the error while using Google Docs. Trying that now.

            Update: I get that same error when exporting a glossary entry with an image in the description. The glossary entry with an image attached doesn't even have an export to portfolio button. Not sure if that is intentional.

            Show
            Andrew Davis added a comment - - edited I'm just familiarizing myself with this now. I've been able to export glossary entries without images, with an image in the description and with an image attached via the file download portfolio. Adrian said in chat he ran into the error while using Google Docs. Trying that now. Update: I get that same error when exporting a glossary entry with an image in the description. The glossary entry with an image attached doesn't even have an export to portfolio button. Not sure if that is intentional.
            Hide
            Andrew Davis added a comment -

            The error is occurring in portfolio/exporter.php

            $formats = portfolio_supported_formats_intersect($this->caller->supported_formats(), $this->instance->supported_formats());

            $this->caller->supported_formats() contains
            Array
            (
            [0] => richhtml
            [1] => leap2a
            )

            $this->instance->supported_formats()
            Array
            (
            [0] => file
            )

            There are no common formats so an exception is thrown.

            Show
            Andrew Davis added a comment - The error is occurring in portfolio/exporter.php $formats = portfolio_supported_formats_intersect($this->caller->supported_formats(), $this->instance->supported_formats()); $this->caller->supported_formats() contains Array ( [0] => richhtml [1] => leap2a ) $this->instance->supported_formats() Array ( [0] => file ) There are no common formats so an exception is thrown.
            Hide
            Andrew Davis added a comment - - edited

            Here is the function in the glossary that specifies what formats it supports

            /**
                 * what formats this function *generally* supports
                 *
                 * @return array
                 */
                public static function base_supported_formats() {
                    return array(PORTFOLIO_FORMAT_RICHHTML, PORTFOLIO_FORMAT_PLAINHTML, PORTFOLIO_FORMAT_LEAP2A);
                }
            

            Here is the function from the google docs portfolio that specify what formats it supports.

            public function supported_formats() {
                    return array(PORTFOLIO_FORMAT_FILE);
                }
            

            Not being able to export anything but files to google docs makes sense. Maybe I shouldnt even be seeing "export to portfolio" buttons. Maybe we need to be doing something like saying "the portfolio only supports file. The caller supports html which is a kind of file so do something clever."

            I just tried exporting a glossary entry with no image to google docs. That, as it turns out, doesn't work either.

            error/Cantpostupload
             
            More information about this error
            Debug info:
            Error code: Cantpostupload
            $a contents:
            Stack trace:
             
                line 983 of /lib/portfoliolib.php: portfolio_export_exception thrown
                line 247 of /lib/portfolio/exporter.php: call to portfolio_export_rethrow_exception()
                line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()
                line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()
                line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()
                line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()
                line 268 of /portfolio/add.php: call to portfolio_exporter->process_stage()
             
            Output buffer: <div class="notifytiny">A third party exception was thrown during portfolio export (moodle_exception). Caught and rethrown but this should really be fixed<ul style="text-align: left"><li>line 245 of /lib/portfolio/exporter.php: call to debugging()</li><li>line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()</li><li>line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()</li><li>line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()</li><li>line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()</li><li>line 268 of /portfolio/add.php: call to portfolio_exporter->process_stage()</li></ul></div><div class="notifytiny">exception 'moodle_exception' with message 'error/Cantpostupload' in /home/andrew/Desktop/code/moodle/dev/master/lib/googleapi.php:149 Stack trace: #0 /home/andrew/Desktop/code/moodle/dev/master/portfolio/googledocs/lib.php(58): google_docs->send_file(Object(stored_file)) #1 /home/andrew/Desktop/code/moodle/dev/master/lib/portfolio/exporter.php(502): portfolio_plugin_googledocs->send_package() #2 /home/andrew/Desktop/code/moodle/dev/master/lib/portfolio/exporter.php(227): portfolio_exporter->process_stage_send() #3 /home/andrew/Desktop/code/moodle/dev/master/lib/portfolio/exporter.php(233): portfolio_exporter->process_stage(5) #4 /home/andrew/Desktop/code/moodle/dev/master/lib/portfolio/exporter.php(233): portfolio_exporter->process_stage(4) #5 /home/andrew/Desktop/code/moodle/dev/master/lib/portfolio/exporter.php(233): portfolio_exporter->process_stage(3) #6 /home/andrew/Desktop/code/moodle/dev/master/lib/portfolio/exporter.php(233): portfolio_exporter->process_stage(2) #7 /home/andrew/Desktop/code/moodle/dev/master/portfolio/add.php(268): portfolio_exporter->process_stage(1, true) #8 {main}<ul style="text-align: left"><li>line 246 of /lib/portfolio/exporter.php: call to debugging()</li><li>line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()</li><li>line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()</li><li>line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()</li><li>line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()</li><li>line 268 of /portfolio/add.php: call to portfolio_exporter->process_stage()</li></ul></div>
            

            Show
            Andrew Davis added a comment - - edited Here is the function in the glossary that specifies what formats it supports /** * what formats this function *generally* supports * * @return array */ public static function base_supported_formats() { return array(PORTFOLIO_FORMAT_RICHHTML, PORTFOLIO_FORMAT_PLAINHTML, PORTFOLIO_FORMAT_LEAP2A); } Here is the function from the google docs portfolio that specify what formats it supports. public function supported_formats() { return array(PORTFOLIO_FORMAT_FILE); } Not being able to export anything but files to google docs makes sense. Maybe I shouldnt even be seeing "export to portfolio" buttons. Maybe we need to be doing something like saying "the portfolio only supports file. The caller supports html which is a kind of file so do something clever." I just tried exporting a glossary entry with no image to google docs. That, as it turns out, doesn't work either. error/Cantpostupload   More information about this error Debug info: Error code: Cantpostupload $a contents: Stack trace:   line 983 of /lib/portfoliolib.php: portfolio_export_exception thrown line 247 of /lib/portfolio/exporter.php: call to portfolio_export_rethrow_exception() line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage() line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage() line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage() line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage() line 268 of /portfolio/add.php: call to portfolio_exporter->process_stage()   Output buffer: <div class="notifytiny">A third party exception was thrown during portfolio export (moodle_exception). Caught and rethrown but this should really be fixed<ul style="text-align: left"><li>line 245 of /lib/portfolio/exporter.php: call to debugging()</li><li>line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()</li><li>line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()</li><li>line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()</li><li>line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()</li><li>line 268 of /portfolio/add.php: call to portfolio_exporter->process_stage()</li></ul></div><div class="notifytiny">exception 'moodle_exception' with message 'error/Cantpostupload' in /home/andrew/Desktop/code/moodle/dev/master/lib/googleapi.php:149 Stack trace: #0 /home/andrew/Desktop/code/moodle/dev/master/portfolio/googledocs/lib.php(58): google_docs->send_file(Object(stored_file)) #1 /home/andrew/Desktop/code/moodle/dev/master/lib/portfolio/exporter.php(502): portfolio_plugin_googledocs->send_package() #2 /home/andrew/Desktop/code/moodle/dev/master/lib/portfolio/exporter.php(227): portfolio_exporter->process_stage_send() #3 /home/andrew/Desktop/code/moodle/dev/master/lib/portfolio/exporter.php(233): portfolio_exporter->process_stage(5) #4 /home/andrew/Desktop/code/moodle/dev/master/lib/portfolio/exporter.php(233): portfolio_exporter->process_stage(4) #5 /home/andrew/Desktop/code/moodle/dev/master/lib/portfolio/exporter.php(233): portfolio_exporter->process_stage(3) #6 /home/andrew/Desktop/code/moodle/dev/master/lib/portfolio/exporter.php(233): portfolio_exporter->process_stage(2) #7 /home/andrew/Desktop/code/moodle/dev/master/portfolio/add.php(268): portfolio_exporter->process_stage(1, true) #8 {main}<ul style="text-align: left"><li>line 246 of /lib/portfolio/exporter.php: call to debugging()</li><li>line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()</li><li>line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()</li><li>line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()</li><li>line 233 of /lib/portfolio/exporter.php: call to portfolio_exporter->process_stage()</li><li>line 268 of /portfolio/add.php: call to portfolio_exporter->process_stage()</li></ul></div>
            Hide
            Andrew Davis added a comment - - edited

            There are at least 2 problems here.

            1) Exporting text only glossary entries to Google Docs is failing. See the exception in my previous comment.

            2) I think the export to portfolio icon is being incorrectly displayed for a glossary entry with an image in the description (or we need to do some magic to make it work).

            First here is the format supported by Google docs.

            Array
            (
                [0] => file
            )

            File and file only.

            Here are the formats for a text only glossary entry (export to portfolio button is displayed).

            Array
            (
                [0] => plainhtml
                [2] => leap2a
            )

            Here are the formats common to both the glossary and the google docs portfolio as returned by portfolio_supported_formats_intersect()

            Array
            (
                [0] => plainhtml
            )

            So it looks like plainhtml is being considered a file, which makes sense.

            Here is the formats for a glossary entry with an attached image (no export to portfolio icon is displayed).

            Array
            (
                [0] => richhtml
                [2] => leap2a
            )

            portfolio_supported_formats_intersect() says there are no common formats so no icon is displayed. richhtml is not considered a file. That also makes sense. We could possibly consider richhtml multiple files but it isnt a straight up file.

            Here is the format for a glossary entry with a file in the description.

            Array
            (
                [0] => plainhtml
                [2] => leap2a
            )

            I believe this is being falsely classified as plainhtml. It needs a file so it should be richhtml. If its format is fixed it will not display an export to portfolio icon as there will be no common format.

            Show
            Andrew Davis added a comment - - edited There are at least 2 problems here. 1) Exporting text only glossary entries to Google Docs is failing. See the exception in my previous comment. 2) I think the export to portfolio icon is being incorrectly displayed for a glossary entry with an image in the description (or we need to do some magic to make it work). First here is the format supported by Google docs. Array ( [0] => file ) File and file only. Here are the formats for a text only glossary entry (export to portfolio button is displayed). Array ( [0] => plainhtml [2] => leap2a ) Here are the formats common to both the glossary and the google docs portfolio as returned by portfolio_supported_formats_intersect() Array ( [0] => plainhtml ) So it looks like plainhtml is being considered a file, which makes sense. Here is the formats for a glossary entry with an attached image (no export to portfolio icon is displayed). Array ( [0] => richhtml [2] => leap2a ) portfolio_supported_formats_intersect() says there are no common formats so no icon is displayed. richhtml is not considered a file. That also makes sense. We could possibly consider richhtml multiple files but it isnt a straight up file. Here is the format for a glossary entry with a file in the description. Array ( [0] => plainhtml [2] => leap2a ) I believe this is being falsely classified as plainhtml. It needs a file so it should be richhtml. If its format is fixed it will not display an export to portfolio icon as there will be no common format.
            Hide
            Michael de Raadt added a comment -

            Carrying over to the new sprint.

            Show
            Michael de Raadt added a comment - Carrying over to the new sprint.
            Hide
            Andrew Davis added a comment -

            This is the code from mod/glossary/lib.php that appears to be determining the format.

            $fs = get_file_storage();
                    if ($files = $fs->get_area_files($filecontext->id, 'mod_glossary', 'attachment', $entry->id, "timemodified", false)) {
                        $button->set_formats(PORTFOLIO_FORMAT_RICHHTML);
                    } else {
                        $button->set_formats(PORTFOLIO_FORMAT_PLAINHTML);
                    }

            My current theory is that this just needs to be made a bit smarter and needs to set the format "richhtml" if there is an image in the description as well as if there is one attached.

            Show
            Andrew Davis added a comment - This is the code from mod/glossary/lib.php that appears to be determining the format. $fs = get_file_storage(); if ($files = $fs->get_area_files($filecontext->id, 'mod_glossary', 'attachment', $entry->id, "timemodified", false)) { $button->set_formats(PORTFOLIO_FORMAT_RICHHTML); } else { $button->set_formats(PORTFOLIO_FORMAT_PLAINHTML); } My current theory is that this just needs to be made a bit smarter and needs to set the format "richhtml" if there is an image in the description as well as if there is one attached.
            Hide
            Andrew Davis added a comment - - edited

            Updating the branch info. I've added a second commit that causes glossary entries containing images in their description to be classed as richhtml instead of plainhtml. It results in there being no "export to portfolio" link for glossary entries containing images in their description as is currently the case for entries with attached images. This seems sensible to me. If an entry with an attached image is richhtml then surely so is an entry with an image in its description.

            Show
            Andrew Davis added a comment - - edited Updating the branch info. I've added a second commit that causes glossary entries containing images in their description to be classed as richhtml instead of plainhtml. It results in there being no "export to portfolio" link for glossary entries containing images in their description as is currently the case for entries with attached images. This seems sensible to me. If an entry with an attached image is richhtml then surely so is an entry with an image in its description.
            Hide
            Andrew Davis added a comment -

            Ok, now it appears that exporting a text only entry to docs is now working. Thats both problems I identified resolved!

            I'll do some more testing but I think my work here might be done.

            Show
            Andrew Davis added a comment - Ok, now it appears that exporting a text only entry to docs is now working. Thats both problems I identified resolved! I'll do some more testing but I think my work here might be done.
            Hide
            Andrew Davis added a comment -

            I think this is working. Putting this up for peer review.

            Show
            Andrew Davis added a comment - I think this is working. Putting this up for peer review.
            Hide
            Adrian Greeve added a comment - - edited

            [Y] Syntax
            [Y] Output
            [Y] Whitespace
            [N/A] Language
            [N/A] Databases
            [Y] Testing
            [N/A] Security
            [N/A] Documentation
            [Y] Git
            [Y] Sanity check

            I agree that if rich text can't be exported to a portfolio then images on a page shouldn't be exported either.

            No problems found.

            Show
            Adrian Greeve added a comment - - edited [Y] Syntax [Y] Output [Y] Whitespace [N/A] Language [N/A] Databases [Y] Testing [N/A] Security [N/A] Documentation [Y] Git [Y] Sanity check I agree that if rich text can't be exported to a portfolio then images on a page shouldn't be exported either. No problems found.
            Hide
            Andrew Davis added a comment -

            Created branches for 2.3 and 2.2. Submitting for integration.

            Show
            Andrew Davis added a comment - Created branches for 2.3 and 2.2. Submitting for integration.
            Hide
            Sam Hemelryk added a comment -

            Thanks Andrew, this has been integrated now

            Show
            Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now
            Hide
            Tim Barker added a comment -

            Tested as per instructions and it passed.

            Show
            Tim Barker added a comment - Tested as per instructions and it passed.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Closing as fixed, many thanks for your awesome collaboration.

            Show
            Eloy Lafuente (stronk7) added a comment - Closing as fixed, many thanks for your awesome collaboration.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: