Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-3383

formerly left-justified text is centered

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.5.1
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_15_STABLE

      Description

      Text that is not explicitly left-justified is displayed center-justified. I first thought that this was a problem with styles_layout.css and solved it by making .generalbox#intro left-justified. Arguably this is a stylistic issue, but I think it's difficult to argue that (1) text that is left-justified in the editor should be center-justified when displayed or that (2) reasonable humans expect paragraphs of text to be left-justified.

      This is discussed here:

      http://moodle.org/mod/forum/discuss.php?d=24603

        Gliffy Diagrams

          Activity

          Hide
          dougiamas Martin Dougiamas added a comment -

          From Jay Pfaffman (pfaffman at relaxpc.com) Saturday, 9 July 2005, 02:24 AM:

          Here's the right fix for this. I can't figure out how to check in stuff, but in http://moodle.cvs.sourceforge.net/moodle/moodle/theme/standard/styles_layout.css there needs to be a

          .generalboxcontent

          { text-align:center; }

          (At least that fixes stuff on the 1.5.1 that I just got from CVS.

          From Jay Pfaffman (pfaffman at relaxpc.com) Tuesday, 12 July 2005, 07:46 PM:

          Ooops. My fix should have RIGHT not center in it.

          From Martin Dougiamas (martin at moodle.com) Tuesday, 12 July 2005, 08:38 PM:

          You are only talking about the intro texts on activity modules.

          What you want is to delete this from standard/styles_layout.css:

          .generalbox#intro

          { text-align:center; }

          I agree this should not be in standard, but I will continue using it in my custom themes (like on moodle.org) for sites where I only put plain text in those intro boxes.

          I've fixed in this 1.5.2 onwards.

          From Jay Pfaffman (pfaffman at relaxpc.com) Tuesday, 12 July 2005, 09:42 PM:

          Thanks very much.

          Your custom styles are certainly your business, but if that whole text box is called the intro having them centered makes sense (to me, anyway) IFF your intro is less than a line.

          Thanks again.

          Show
          dougiamas Martin Dougiamas added a comment - From Jay Pfaffman (pfaffman at relaxpc.com) Saturday, 9 July 2005, 02:24 AM: Here's the right fix for this. I can't figure out how to check in stuff, but in http://moodle.cvs.sourceforge.net/moodle/moodle/theme/standard/styles_layout.css there needs to be a .generalboxcontent { text-align:center; } (At least that fixes stuff on the 1.5.1 that I just got from CVS. From Jay Pfaffman (pfaffman at relaxpc.com) Tuesday, 12 July 2005, 07:46 PM: Ooops. My fix should have RIGHT not center in it. From Martin Dougiamas (martin at moodle.com) Tuesday, 12 July 2005, 08:38 PM: You are only talking about the intro texts on activity modules. What you want is to delete this from standard/styles_layout.css: .generalbox#intro { text-align:center; } I agree this should not be in standard, but I will continue using it in my custom themes (like on moodle.org) for sites where I only put plain text in those intro boxes. I've fixed in this 1.5.2 onwards. From Jay Pfaffman (pfaffman at relaxpc.com) Tuesday, 12 July 2005, 09:42 PM: Thanks very much. Your custom styles are certainly your business, but if that whole text box is called the intro having them centered makes sense (to me, anyway) IFF your intro is less than a line. Thanks again.
          Hide
          mblake Michael Blake added a comment -

          assign to a valid user

          Show
          mblake Michael Blake added a comment - assign to a valid user

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: