Moodle
  1. Moodle
  2. MDL-33835

Marking guide "Frequently used comments" throws JS errors

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.1
    • Component/s: Grading methods
    • Labels:
    • Testing Instructions:
      Hide

      Create an assignment and set it to use the advanced grading method "Marking Guide" - make sure you add some frequently used comments to the marking guide.
      On the assignment submissions page choose to grade an existing student - on the page that loads before doing anything else click on one of the comments and make sure no JS errors occur and the comment is added to the comment field of the first criterion.

      Show
      Create an assignment and set it to use the advanced grading method "Marking Guide" - make sure you add some frequently used comments to the marking guide. On the assignment submissions page choose to grade an existing student - on the page that loads before doing anything else click on one of the comments and make sure no JS errors occur and the comment is added to the comment field of the first criterion.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      master_MDL-33835
    • Rank:
      41935

      Description

      When you try to add a frequently used comment, if you have not yet selected a criteria comment field, a JS error is shown and nothing is added to any comment field.

      currentfocus is null
      http://michael.moodle.local/moodle_testing/lib/javascript.php/1340084662/grade/grading/form/guide/js/guide.js
      Line 1
      

      I suggest the currentfocus variable be set to the first criterion comment initially. That would alleviate this error and put comments somewhere initially.

        Activity

        Hide
        Dan Marsden added a comment -

        thanks Michael - pushing this up for peer review.

        Show
        Dan Marsden added a comment - thanks Michael - pushing this up for peer review.
        Hide
        Rajesh Taneja added a comment -

        Thanks Dan,
        Code looks good, please fill testing instructions and push it for integration review

        Show
        Rajesh Taneja added a comment - Thanks Dan, Code looks good, please fill testing instructions and push it for integration review
        Hide
        Dan Marsden added a comment -

        thanks Rajesh!

        Show
        Dan Marsden added a comment - thanks Rajesh!
        Hide
        Dan Poltawski added a comment -

        Intgerated to master and 23_STABLE. thanks Dan

        Show
        Dan Poltawski added a comment - Intgerated to master and 23_STABLE. thanks Dan
        Hide
        Frédéric Massart added a comment -

        Passed on 2.3 and master. Cheers!

        Show
        Frédéric Massart added a comment - Passed on 2.3 and master. Cheers!
        Hide
        Sam Hemelryk added a comment -

        Congratulations your code is upstream - gold star for you!

        This issue + 79 others made it in in time for the minor releases.
        Thank you everyone involved for your exuberant efforts.

        Show
        Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: