Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33837

Picking a server file marked as "main" makes it main in new filearea

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.1
    • Component/s: Filepicker
    • Labels:
      None
    • Testing Instructions:
      Hide

      1. Create a file resource, add file and mark it as main. Save it
      2. Create a folder resource, open filepicker, Server files and pick a file created in #1 (try both picking as a copy and by reference)
      3. Make sure picked file is not displayed in filemanager with bold (which means "main file")

      Show
      1. Create a file resource, add file and mark it as main. Save it 2. Create a folder resource, open filepicker, Server files and pick a file created in #1 (try both picking as a copy and by reference) 3. Make sure picked file is not displayed in filemanager with bold (which means "main file")
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      wip-MDL-33837-master

      Description

      1. Create a file resource, add file and mark it as main. Save it
      2. Create a folder resource, open filepicker, Server files and pick a file created in #1
      It is displayed bold as if it was main (there is no "main file" functionality in folder resource)

      The field 'sortorder' should not be copied when file is picked by reference.

        Gliffy Diagrams

          Activity

          Hide
          marina Marina Glancy added a comment -

          TO INTEGRATORS: please cherry-pick to 23_STABLE

          Show
          marina Marina Glancy added a comment - TO INTEGRATORS: please cherry-pick to 23_STABLE
          Hide
          poltawski Dan Poltawski added a comment -

          Integrated, thanks Marina

          Show
          poltawski Dan Poltawski added a comment - Integrated, thanks Marina
          Hide
          poltawski Dan Poltawski added a comment -

          (to 23_STABLE and master)

          Show
          poltawski Dan Poltawski added a comment - (to 23_STABLE and master)
          Hide
          phalacee Jason Fowler added a comment -

          I'm getting a "Invalid JSON" string while attempting this test

          Show
          phalacee Jason Fowler added a comment - I'm getting a "Invalid JSON" string while attempting this test
          Hide
          phalacee Jason Fowler added a comment -

          All good now Marina, thanks

          Show
          phalacee Jason Fowler added a comment - All good now Marina, thanks
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Congratulations your code is upstream - gold star for you!

          This issue + 79 others made it in in time for the minor releases.
          Thank you everyone involved for your exuberant efforts.

          Show
          samhemelryk Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jul/12