Moodle
  1. Moodle
  2. MDL-33842

Antivirus detection with drag and drop on file manager form element is not verbose enough.

    Details

    • Rank:
      41942

      Description

      When anti virus checking is enabled on uploaded files; on the course page with drag and drop and in file picker; if the user uploads an infected file, the file is not uploaded. Moodle also displays a dialog with a message informing the user of what has happened. When the user drags a file onto the file manager form element, although the file is not uploaded, there is no dialog to inform the user what has just happened.

      To recreate:

      1. Drag an infected file - get a test file from http://www.eicar.org/85-0-Download.html - onto any File manager form element.

      Expected result:

      • Clam AV blocks the file and Moodle informs the user that the file has been blocked.

      Actual result:

      • Clam AV blocks the file it is not uploaded but there is no other feedback from Moodle.

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          Assigning to Davo to see what he thinks of it.

          Show
          Dan Poltawski added a comment - Assigning to Davo to see what he thinks of it.
          Hide
          Davo Smith added a comment -

          Quick patch that shows error messages from the server in a YUI dialog, rather than outputting them onto the javascript console.

          It appears to fix this issue (although I had to briefly hack the repository/upload code, as I don't have ClamAV set up locally).

          (Note the patch is based on integration.git)

          Show
          Davo Smith added a comment - Quick patch that shows error messages from the server in a YUI dialog, rather than outputting them onto the javascript console. It appears to fix this issue (although I had to briefly hack the repository/upload code, as I don't have ClamAV set up locally). (Note the patch is based on integration.git)
          Hide
          Dan Poltawski added a comment -

          Pulling this straight into integraiton.

          Show
          Dan Poltawski added a comment - Pulling this straight into integraiton.
          Hide
          Dan Poltawski added a comment -

          Integrated thanks.

          I haven't tested it but the code makes total sense to me. Hopefully Tim can confirm.

          Show
          Dan Poltawski added a comment - Integrated thanks. I haven't tested it but the code makes total sense to me. Hopefully Tim can confirm.
          Hide
          Tim Barker added a comment -

          Tested in my private files and in a file resource and got the filepicker style dialog.

          Your code has passed testing. Congrats, good work.

          Show
          Tim Barker added a comment - Tested in my private files and in a file resource and got the filepicker style dialog. Your code has passed testing. Congrats, good work.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay!

          Many, many thanks for your hard work!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay! Many, many thanks for your hard work! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: