Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      1. Add a folder activity to a course
      2. Try all themes in a couple of browsers to look at the editing page (with the filemanager) and the normal view page.
      3. Ensure there are not crazy amounts of whitespace like the first screenshot below.

      Show
      1. Add a folder activity to a course 2. Try all themes in a couple of browsers to look at the editing page (with the filemanager) and the normal view page. 3. Ensure there are not crazy amounts of whitespace like the first screenshot below.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33845_folder_whitespace

      Description

      On some themes there is a crazy amount of white space on the Folder edit and view pages. (See screenshot)

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            poltawski Dan Poltawski added a comment -

            Seems OK to me. Please add testing instructions and good to go

            Added Mary here in case she has any thoughts.

            Show
            poltawski Dan Poltawski added a comment - Seems OK to me. Please add testing instructions and good to go Added Mary here in case she has any thoughts.
            Hide
            lazydaisy Mary Evans added a comment -

            Looks good to me!

            Show
            lazydaisy Mary Evans added a comment - Looks good to me!
            Hide
            dougiamas Martin Dougiamas added a comment -

            Ready to go. Note this only affects themes based on canvas.

            Show
            dougiamas Martin Dougiamas added a comment - Ready to go. Note this only affects themes based on canvas.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Martin (congrats on mastering git btw!) this has been integrated now and ready to be tested.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Martin (congrats on mastering git btw!) this has been integrated now and ready to be tested.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            This looks good.

            Test passed.

            Show
            rwijaya Rossiani Wijaya added a comment - This looks good. Test passed.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay!

            Many, many thanks for your hard work!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay! Many, many thanks for your hard work! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12