Moodle
  1. Moodle
  2. MDL-33848

Tree view for assignment submission has table outline

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.1
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create an instance of the assignment module
      2. Enable file submissions and file feedback
      3. Login as a student and submit some files
      4. Login as a teacher and provide files as feedback
      5. Verify that the list of files in the grading table for teachers does not have a border around each file element for the submitted files or the feedback files
      6. Verify that the submission summary page for students does not have a border around each file element in the submitted files or the feedback files
      Show
      Create an instance of the assignment module Enable file submissions and file feedback Login as a student and submit some files Login as a teacher and provide files as feedback Verify that the list of files in the grading table for teachers does not have a border around each file element for the submitted files or the feedback files Verify that the submission summary page for students does not have a border around each file element in the submitted files or the feedback files
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:

      Description

      When viewing submitted files in an assignment there is an outline around elements of the tree used to present the files.

      I thought this might be generic to tree views, but I couldn't find it elsewhere, not even in the old assignment.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Michael de Raadt added a comment -

            I tried this in a number of browsers. It appears the same.

            Show
            Michael de Raadt added a comment - I tried this in a number of browsers. It appears the same.
            Hide
            Damyon Wiese added a comment -

            I just had a look - it is because it rendered within a table and is picking up the styles from that. I have looked at this for 6 months and not twigged there was anything wrong

            Show
            Damyon Wiese added a comment - I just had a look - it is because it rendered within a table and is picking up the styles from that. I have looked at this for 6 months and not twigged there was anything wrong
            Hide
            Michael de Raadt added a comment -

            I like it that you can fix issues faster than I can report them.

            Show
            Michael de Raadt added a comment - I like it that you can fix issues faster than I can report them.
            Hide
            Michael de Raadt added a comment -

            I think it is more correct to have border: none; or border: 0 none;

            http://www.w3schools.com/css/css_border.asp

            It does the job though.

            Show
            Michael de Raadt added a comment - I think it is more correct to have border: none; or border: 0 none; http://www.w3schools.com/css/css_border.asp It does the job though.
            Hide
            Damyon Wiese added a comment -

            Thanks Michael, I updated the patch to have "border: 0px none;".

            Show
            Damyon Wiese added a comment - Thanks Michael, I updated the patch to have "border: 0px none;".
            Hide
            Michael de Raadt added a comment -

            Eeeeexcelent.

            Show
            Michael de Raadt added a comment - Eeeeexcelent.
            Hide
            Sam Hemelryk added a comment -

            Thanks Damyon, this has been integrated now.

            Show
            Sam Hemelryk added a comment - Thanks Damyon, this has been integrated now.
            Hide
            Rajesh Taneja added a comment -

            Looks great, thanks for fixing this Damyon.

            Show
            Rajesh Taneja added a comment - Looks great, thanks for fixing this Damyon.
            Hide
            Sam Hemelryk added a comment -

            Congratulations your code is upstream - gold star for you!

            This issue + 79 others made it in in time for the minor releases.
            Thank you everyone involved for your exuberant efforts.

            Show
            Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: