Moodle
  1. Moodle
  2. MDL-33856

add activity or resource popup dialog shows no content in RTL mode.

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 2.3
        • Fix Version/s: 2.3
        • Component/s: Accessibility
        • Labels:
        • Testing Instructions:
          Hide

          In a RTL language (I used Hebrew)

          • Open a course
          • Turn editing on
          • Open the Activity chooser
            • Confirm that the instructions are on the left
            • Confirm that the instructions are visible
            • Confirm that the list of activities are on the right
            • Confirm that the list of activities is visible
          • Select an activity
            • Confirm that its help is visible
          • Switch back to English (or any other LTR language)
          • Open the Activity chooser
            • Confirm that the instructions are on the right
            • Confirm that the instructions are visible
            • Confirm that the list of activities is visible
            • Confirm that the list of activities are on the left
          • Select an activity
            • Confirm that its help is visible
          Show
          In a RTL language (I used Hebrew) Open a course Turn editing on Open the Activity chooser Confirm that the instructions are on the left Confirm that the instructions are visible Confirm that the list of activities are on the right Confirm that the list of activities is visible Select an activity Confirm that its help is visible Switch back to English (or any other LTR language) Open the Activity chooser Confirm that the instructions are on the right Confirm that the instructions are visible Confirm that the list of activities is visible Confirm that the list of activities are on the left Select an activity Confirm that its help is visible
        • Affected Branches:
          MOODLE_23_STABLE
        • Fixed Branches:
          MOODLE_23_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-33856-master-1
        • Pull Master Diff URL:

          Description

          i've attached a screenshot showing adding activity in RTL . note the 'lang=he' in url for the hebrew lang pack.

            Gliffy Diagrams

              Issue Links

              Discovered while testing

              Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33883 Activity and resource picker right to left issues

              • Minor - Minor loss of function where workaround is possible
              • Closed

              Functional Test - A test of a single Moodle feature MDLQA-3902 CLONE - Languages

              • Open

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Aparup Banerjee added a comment -

                attached quick comparison

                Show
                Aparup Banerjee added a comment - attached quick comparison
                Hide
                Permalink
                Aparup Banerjee added a comment -

                raising to major. but atleast there is the fall back old activity/resources selector.

                Show
                Aparup Banerjee added a comment - raising to major. but atleast there is the fall back old activity/resources selector.
                Hide
                Permalink
                Dan Poltawski added a comment -

                Seems to make sense and fixes the thing here.

                Show
                Dan Poltawski added a comment - Seems to make sense and fixes the thing here.
                Hide
                Permalink
                Aparup Banerjee added a comment -

                yup looks good and worked for me. even add/cancel buttons were swapped

                i've integrated that into master now, thanks Andrew

                Show
                Aparup Banerjee added a comment - yup looks good and worked for me. even add/cancel buttons were swapped i've integrated that into master now, thanks Andrew
                Hide
                Permalink
                Adrian Greeve added a comment -

                I tested this with Hebrew and Arabic and content is now available as described in the test. I did notice that the indentation that we have for assignment 2.2 in left to right mode is missing in right to left, and that the scroll bar is also missing in right to left mode. I created a separate issue for that.
                Test passed
                Thanks.

                Show
                Adrian Greeve added a comment - I tested this with Hebrew and Arabic and content is now available as described in the test. I did notice that the indentation that we have for assignment 2.2 in left to right mode is missing in right to left, and that the scroll bar is also missing in right to left mode. I created a separate issue for that. Test passed Thanks.
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay!

                Many, many thanks for your hard work!

                Ciao

                Show
                Eloy Lafuente (stronk7) added a comment - And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay! Many, many thanks for your hard work! Ciao

                  People

                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: