Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33857

Server files repository runs out of memory on big site

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 2.3
    • 2.3.3
    • Repositories
    • MOODLE_23_STABLE
    • MOODLE_23_STABLE
    • wip-MDL-33857-master
    • Hide

      Test 1 (speed):
      You need a really big site (for example moodle.org with a lot of folder)
      Open Filepicker and navigate inside 'Server files'. Should be faster than it was
      Please note that filepicker Javascript is still slow for rendering files (rendering starts when loading gif stops spinning)

      Test 2 (regression):

      1. Add one/several courses with at least one module of each changed module type: book, data, forum, glossary, imscp, workshop
      2. Add data with files of different types (images and non-images) in those modules
      3. Enable legacy file area in one of the courses and add files there
      4. As admin/teacher create a folder and make sure you can navigate in filepicker Server files through all modules
      5. Open insert image filepicker in some textarea and make sure you can navigate and Server files only shows folders with image files
      Show
      Test 1 (speed): You need a really big site (for example moodle.org with a lot of folder) Open Filepicker and navigate inside 'Server files'. Should be faster than it was Please note that filepicker Javascript is still slow for rendering files (rendering starts when loading gif stops spinning) Test 2 (regression): Add one/several courses with at least one module of each changed module type: book, data, forum, glossary, imscp, workshop Add data with files of different types (images and non-images) in those modules Enable legacy file area in one of the courses and add files there As admin/teacher create a folder and make sure you can navigate in filepicker Server files through all modules Open insert image filepicker in some textarea and make sure you can navigate and Server files only shows folders with image files

    Description

      On test upgrade of 2.3 on moodle.org, logged in as admin the server runs out of memory when clicking on server files.

      I'm pretty sure its doing something stupid there, previously have mentioned this issue in MDL-27236 and MDL-27236.

      I did one 'blind' bugfix to improve the situation in the past, we need to resolve the problem properly.

      Attachments

        Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-37254 Error thrown in filebrowser/file_info_context_course.php in postgresql 8.3

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36067 Error updating user preference 'filepicker_recentrepository' using ajax.

          • Major - Major loss of function, incorrect output
          • Reopened

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-25190 ERROR: Invalid JSON string on filepicker

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35668 Server files repository takes a long time to load

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Activity

            People

              marina Marina Glancy
              poltawski Dan Poltawski
              Sam Hemelryk Sam Hemelryk
              Mark Nelson Mark Nelson
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              10 Vote for this issue
              Watchers:
              16 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Nov/12