Moodle
  1. Moodle
  2. MDL-33862

Course AJAX editing fails to load when orphaned activities present

    Details

    • Testing Instructions:
      Hide
      • Turn editing on.
      • Create one or more activities in the last section of a course.
      • Reduce the number of course sections by 1.
      • Wait for page reload
        • Ensure that no JS errors were shown and that the module chooser works
      Show
      Turn editing on. Create one or more activities in the last section of a course. Reduce the number of course sections by 1. Wait for page reload Ensure that no JS errors were shown and that the module chooser works
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33862-master-1

      Description

      The changes from MDL-33573 highlighted an issue where a section without a chooser (e.g. an Oprhaned section) should not be set up as a section.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Davo Smith added a comment -

            Assigning to Andrew.

            I'm assuming a quick 'if (chooserspan) {' should fix this, as you probably don't want to allow users to add items to orphaned sections.

            Show
            Davo Smith added a comment - Assigning to Andrew. I'm assuming a quick 'if (chooserspan) {' should fix this, as you probably don't want to allow users to add items to orphaned sections.
            Hide
            Andrew Nicols added a comment -

            Thanks Davo - spot on the money

            Show
            Andrew Nicols added a comment - Thanks Davo - spot on the money
            Hide
            Davo Smith added a comment -

            As I suggested the fix and Andrew has confirmed and implemented and I've looked at (both lines of) the code, I'm happy that it is peer reviewed, assuming no one else objects?

            Show
            Davo Smith added a comment - As I suggested the fix and Andrew has confirmed and implemented and I've looked at (both lines of) the code, I'm happy that it is peer reviewed, assuming no one else objects?
            Hide
            Dan Poltawski added a comment -

            Thanks Davo and Andrew.

            FYI - of course! You are a peer and have reviewed it! Please feel free to peer review issues.

            Show
            Dan Poltawski added a comment - Thanks Davo and Andrew. FYI - of course! You are a peer and have reviewed it! Please feel free to peer review issues.
            Hide
            Dan Poltawski added a comment -

            Integrated, thanks

            Show
            Dan Poltawski added a comment - Integrated, thanks
            Hide
            Dan Poltawski added a comment -

            Passed. Although just noting that it was still working before, just errors.

            Show
            Dan Poltawski added a comment - Passed. Although just noting that it was still working before, just errors.
            Hide
            Davo Smith added a comment -

            On my computer it was stopping the rest of the Ajax and the drag and drop code from running.

            Show
            Davo Smith added a comment - On my computer it was stopping the rest of the Ajax and the drag and drop code from running.
            Hide
            Dan Poltawski added a comment -

            firefox right? I tired on firefox/chrome, still seemed to work. weird

            Show
            Dan Poltawski added a comment - firefox right? I tired on firefox/chrome, still seemed to work. weird
            Hide
            Davo Smith added a comment -

            Chrome 19/Debian - anyway, the important issue is that it is now working fine (I wouldn't have noticed the error, except that I was testing MDL-33722 and was wondering why the dnd status bar never appeared and then realised I wasn't getting any AJAX at all).

            Show
            Davo Smith added a comment - Chrome 19/Debian - anyway, the important issue is that it is now working fine (I wouldn't have noticed the error, except that I was testing MDL-33722 and was wondering why the dnd status bar never appeared and then realised I wasn't getting any AJAX at all).
            Hide
            Eloy Lafuente (stronk7) added a comment -

            And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay!

            Many, many thanks for your hard work!

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay! Many, many thanks for your hard work! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: