Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31167 PHP strict META
  3. MDL-33875

E_STRICT warning when deleting one course category

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      1) Enable debug developer.
      2) Go to Admin -> Courses -> Add/Edit courses
      3) Click the X (delete icon) of any category having some course(s).
      4) You are asked for confirmation. No need to proceed. In that page...
      4) TEST: The warning in the description is not shown at all.

      That is, puro simple! Ciao

      Show
      1) Enable debug developer. 2) Go to Admin -> Courses -> Add/Edit courses 3) Click the X (delete icon) of any category having some course(s). 4) You are asked for confirmation. No need to proceed. In that page... 4) TEST: The warning in the description is not shown at all. That is, puro simple! Ciao
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Getting this warning:

      Strict standards: Only variables should be passed by reference in course/delete_category_form.php on line 106

      Fix is trivial, split the array_keys() and reset() as far as the later requires a true variable (because it's modified by it).

        Attachments

          Activity

            People

            Assignee:
            stronk7 Eloy Lafuente (stronk7)
            Reporter:
            stronk7 Eloy Lafuente (stronk7)
            Integrator:
            Dan Poltawski
            Tester:
            Dan Poltawski
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              25/Jun/12