Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33878

Assignment module - stack trace when unoverriding a grade for a user with a submission but no grade when feedback comments is enabled.

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.3
    • 2.3
    • Assignment
    • None
    • MOODLE_23_STABLE
    • MOODLE_23_STABLE
    • Hide
      1. Create a new assignment in a course with at least one student. Make sure Feedback comments are enabled.
      2. Login as a student and add a submission to the assignment
      3. Login as a grader and assign a grade for the student directly in the gradebook (not in the assignment)
      4. Edit the grade in the gradebook and remove the overridden flag
      5. Save the grade - verify you do not see the stack trace/error listed in the description of this bug.
      Show
      Create a new assignment in a course with at least one student. Make sure Feedback comments are enabled. Login as a student and add a submission to the assignment Login as a grader and assign a grade for the student directly in the gradebook (not in the assignment) Edit the grade in the gradebook and remove the overridden flag Save the grade - verify you do not see the stack trace/error listed in the description of this bug.

    Description

      The following stack trace is produced when unoveriding a grade in the gradebook for a user who has a submission but no grade in an assignment when the feedback comments plugin is enabled for the assignment.

      Argument 1 passed to assign_feedback_comments::text_for_gradebook() must be an instance of stdClass, boolean given, called in /git/working/moodle23/mod/assign/locallib.php on line 3356 and defined
      Error code: codingerror
      Stack trace:

      line 397 of /lib/setuplib.php: coding_exception thrown
      line 290 of /mod/assign/feedback/comments/locallib.php: call to default_error_handler()
      line 3356 of /mod/assign/locallib.php: call to assign_feedback_comments->text_for_gradebook()
      line 760 of /mod/assign/lib.php: call to assign->get_user_grades_for_gradebook()
      line 777 of /mod/assign/lib.php: call to assign_get_user_grades()
      line 1190 of /lib/gradelib.php: call to assign_update_grades()
      line 1447 of /lib/grade/grade_item.php: call to grade_update_mod_grades()
      line 319 of /lib/grade/grade_grade.php: call to grade_item->refresh_grades()
      line 215 of /grade/edit/tree/grade.php: call to grade_grade->set_overridden()

      Attachments

        Issue Links

          Activity

            People

              damyon Damyon Wiese
              damyon Damyon Wiese
              Andrew Davis Andrew Davis
              Dan Poltawski Dan Poltawski
              Dan Poltawski Dan Poltawski
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                25/Jun/12