Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33891

Chooser Dialogue does not cancel listen events when closed

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 2.3
    • 2.3
    • JavaScript
    • MOODLE_23_STABLE
    • MOODLE_23_STABLE
    • MDL-33891-master-1
    • Hide
      • Open a course
      • Turn editing on
      • Open the activity chooser
        • Ensure that the scrollbars are locked
      • Close the activity chooser
        • Ensure that the scrollbars are unlocked
      • Resize your browser window (or rotate your device)
        • Ensure that the scrollbars are unlocked
      • Open the chooser
        • Ensure that it still opens
        • Ensure that the scrollbars are locked
      • Close the chooser
      Show
      Open a course Turn editing on Open the activity chooser Ensure that the scrollbars are locked Close the activity chooser Ensure that the scrollbars are unlocked Resize your browser window (or rotate your device) Ensure that the scrollbars are unlocked Open the chooser Ensure that it still opens Ensure that the scrollbars are locked Close the chooser

    Description

      This is an oversight on my part from when I added the event canceller to the chooser dialogue.
      This idea of the cancel_listeners function is to cancel all events relating to an open dialogue. This includes things such as window resizing.
      Now that MDL-33649 has been integrated, it means that if you resize the window after you close the dialogue (or if you're IE8 when you close the dialogue) the scrollbars are locked.

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Dan Poltawski Dan Poltawski
              Frédéric Massart Frédéric Massart
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                25/Jun/12