Moodle
  1. Moodle
  2. MDL-33891

Chooser Dialogue does not cancel listen events when closed

    Details

    • Testing Instructions:
      Hide
      • Open a course
      • Turn editing on
      • Open the activity chooser
        • Ensure that the scrollbars are locked
      • Close the activity chooser
        • Ensure that the scrollbars are unlocked
      • Resize your browser window (or rotate your device)
        • Ensure that the scrollbars are unlocked
      • Open the chooser
        • Ensure that it still opens
        • Ensure that the scrollbars are locked
      • Close the chooser
      Show
      Open a course Turn editing on Open the activity chooser Ensure that the scrollbars are locked Close the activity chooser Ensure that the scrollbars are unlocked Resize your browser window (or rotate your device) Ensure that the scrollbars are unlocked Open the chooser Ensure that it still opens Ensure that the scrollbars are locked Close the chooser
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33891-master-1
    • Rank:
      41993

      Description

      This is an oversight on my part from when I added the event canceller to the chooser dialogue.
      This idea of the cancel_listeners function is to cancel all events relating to an open dialogue. This includes things such as window resizing.
      Now that MDL-33649 has been integrated, it means that if you resize the window after you close the dialogue (or if you're IE8 when you close the dialogue) the scrollbars are locked.

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          Integrated, thanks

          Show
          Dan Poltawski added a comment - Integrated, thanks
          Hide
          Aparup Banerjee added a comment -

          for Fred

          Show
          Aparup Banerjee added a comment - for Fred
          Hide
          Frédéric Massart added a comment -

          Tested passed on IE8 and Chrome. Now MDL-33649 can be passed too!

          Show
          Frédéric Massart added a comment - Tested passed on IE8 and Chrome. Now MDL-33649 can be passed too!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay!

          Many, many thanks for your hard work!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay! Many, many thanks for your hard work! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: