Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33914

No scrollbar on SCORM player Table of Contents

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.2.4, 2.3.1
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide

      Good to test this in Multiple browsers if poss - I've tested in FF/Chrome on ubuntu and IE 8
      Create a SCORM with a small TOC like this one:
      http://moodle.org/mod/data/view.php?d=50&rid=1655
      make sure when adding scorm you set "display course structure in player" to "To the side"
      enter SCORM and check to make sure TOC doesn't show scrollbar

      Create a SCORM with a large TOC (email me for a copy of one as I don't have one that can be shared publicly)
      enter SCORM and check to make sure TOC shows scrollbar when required.

      Show
      Good to test this in Multiple browsers if poss - I've tested in FF/Chrome on ubuntu and IE 8 Create a SCORM with a small TOC like this one: http://moodle.org/mod/data/view.php?d=50&rid=1655 make sure when adding scorm you set "display course structure in player" to "To the side" enter SCORM and check to make sure TOC doesn't show scrollbar Create a SCORM with a large TOC (email me for a copy of one as I don't have one that can be shared publicly) enter SCORM and check to make sure TOC shows scrollbar when required.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      master_MDL-33914

      Description

      When browsing through a SCORM object with lots of elements in it, you can't actually scroll down the table of contents. Had to hack YUI CSS (for v2.8.2, /build/assets/skins/sam/skin.css around line 21 elements div.yui-layout-bd + div.yui-layout-bd-noft - added "overflow: auto;" into these classes). Has always been a problem for us, only looked at it last week when a staff member complained to my team

        Gliffy Diagrams

          Activity

          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks for the report David, I've reassigned this to Dan M, he's our SCORM expert and will have a much better idea about this then I will.

          Cheers
          Sam

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks for the report David, I've reassigned this to Dan M, he's our SCORM expert and will have a much better idea about this then I will. Cheers Sam
          Hide
          danmarsden Dan Marsden added a comment -

          hmmm - scroll within toc was working last time I checked with latest code - which browser are you seeing this with? - any chance you could supply a SCORM package that allows us to test?

          Show
          danmarsden Dan Marsden added a comment - hmmm - scroll within toc was working last time I checked with latest code - which browser are you seeing this with? - any chance you could supply a SCORM package that allows us to test?
          Hide
          dperry2009 Dave Perry added a comment -

          Oops sent the file (including screenshot of no scrollbars on a 2.1.4 instance) to the wrong Dan (Dan P). And our email filter threw a paddy about the mere use of a ZIP file on that one - will ask him to forward on.

          Show
          dperry2009 Dave Perry added a comment - Oops sent the file (including screenshot of no scrollbars on a 2.1.4 instance) to the wrong Dan (Dan P). And our email filter threw a paddy about the mere use of a ZIP file on that one - will ask him to forward on.
          Hide
          danmarsden Dan Marsden added a comment -

          ah - I remember now, we had extra scrollbars appearing on the content area so we removed them in MDL-31888 - looks like we need to add it back specifically for the toc.

          Show
          danmarsden Dan Marsden added a comment - ah - I remember now, we had extra scrollbars appearing on the content area so we removed them in MDL-31888 - looks like we need to add it back specifically for the toc.
          Hide
          danmarsden Dan Marsden added a comment -

          note to integrator - 22_STABLE and master only please.

          Show
          danmarsden Dan Marsden added a comment - note to integrator - 22_STABLE and master only please.
          Hide
          poltawski Dan Poltawski added a comment -

          Thanks Dan, integrated to master, 23 and 22

          Show
          poltawski Dan Poltawski added a comment - Thanks Dan, integrated to master, 23 and 22
          Hide
          rwijaya Rossiani Wijaya added a comment -

          This looks great.

          Test passed.

          Show
          rwijaya Rossiani Wijaya added a comment - This looks great. Test passed.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Congratulations your code is upstream - gold star for you!

          This issue + 79 others made it in in time for the minor releases.
          Thank you everyone involved for your exuberant efforts.

          Show
          samhemelryk Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jul/12