[MDL-33917] mod/resource/db/upgradelib.php typing error - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
Fixed Branches:
MOODLE_22_STABLE
Pull from Repository:
git://github.com/danpoltawski/moodle.git
Testing Instructions:
Hide

Install a Moodle 1.9 site

Go to Admin > Front Page > Front page settings

Include a topic section

On front page topic section

Add a link to a file or website

Upload a file

Set the link to this. (click choose).

Set the link explicitly so it uses the full http link (not just IMG_1.jpg explicitly to http://dan.moodle.org/moodle/file.php/1/IMG_1.jpg ) # # Save and verify that the file is linked to on front page

Checkout MOODLE_22_STABLE

Upgrade

Check the front page resource has been upgraded correctly and is visible when you click on it
Show
Install a Moodle 1.9 site Go to Admin > Front Page > Front page settings Include a topic section On front page topic section Add a link to a file or website Upload a file Set the link to this. (click choose). Set the link explicitly so it uses the full http link (not just IMG_1.jpg explicitly to http://dan.moodle.org/moodle/file.php/1/IMG_1.jpg ) # # Save and verify that the file is linked to on front page Checkout MOODLE_22_STABLE Upgrade Check the front page resource has been upgraded correctly and is visible when you click on it

in function resource_20_migrate(), line 79 is a typing error, i guess. (maybe nobody uses upload of resource to $siteid, so nobody recognized)

$file_record = array('contextid'=>$context->id, 'component'=>'mod_resourse', 'filearea'=>'content', 'itemid'=>0);

i think 'mod_resourse' should be spelled: 'mod_resource'

Best regards
Timo Welde

Participants:: Andrew Davis, Dan Poltawski, Martin Dougiamas, Michael de Raadt, Petr Skoda, Sam Hemelryk, Timo Welde

Component watchers:: Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie