Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33924

typo in quiz table def

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.1, 2.2
          • Fix Version/s: 2.1.7, 2.2.4, 2.3.1
          • Component/s: Quiz
          • Labels:
            None
          • Testing Instructions:
            Hide

            1. Go to admin -> development -> XMLDB
            2. Run the check foreign keys script.
            3. Verify the results relating to quiz_attempts -> question_usages makes sense.

            Show
            1. Go to admin -> development -> XMLDB 2. Run the check foreign keys script. 3. Verify the results relating to quiz_attempts -> question_usages makes sense.
          • Affected Branches:
            MOODLE_21_STABLE, MOODLE_22_STABLE
          • Fixed Branches:
            MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
          • Pull from Repository:
          • Pull Master Branch:
          • Pull Master Diff URL:

            Description

            Checking foreign keys violations I realized a line in mod/quiz/db/install.xml seems wrong :
            <KEY NAME="uniqueid" TYPE="foreign-unique" FIELDS="uniqueid" REFTABLE="question_attempts" REFFIELDS="id" PREVIOUS="userid"/>
            to me it seems that REFFIELDS should be "questionusageid" and not "id", am I wrong ?
            Of course it doesn't really matter and this will not cause any harm
            But what surprise me is that I am surely not the first Moodle user to look at foreign keys violations since Moodle 2.1 is out ???

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  timhunt Tim Hunt added a comment -

                  Seemingly you are the first.

                  Actually, it is the target table that is wrong.

                  Show
                  timhunt Tim Hunt added a comment - Seemingly you are the first. Actually, it is the target table that is wrong.
                  Hide
                  Permalink
                  jmvedrine Jean-Michel Vedrine added a comment -

                  Oh yes I see, with question_attempts table it would'nt be foreign-unique !!

                  Show
                  jmvedrine Jean-Michel Vedrine added a comment - Oh yes I see, with question_attempts table it would'nt be foreign-unique !!
                  Hide
                  Permalink
                  jmvedrine Jean-Michel Vedrine added a comment -

                  Oops my previous comment is wrong !! sorry but I just wake up ...

                  Show
                  jmvedrine Jean-Michel Vedrine added a comment - Oops my previous comment is wrong !! sorry but I just wake up ...
                  Hide
                  Permalink
                  timhunt Tim Hunt added a comment -

                  Rebased and 2.3 branch added.

                  Show
                  timhunt Tim Hunt added a comment - Rebased and 2.3 branch added.
                  Hide
                  Permalink
                  poltawski Dan Poltawski added a comment -

                  Integrated, thanks (21, 22, 23, master)

                  Show
                  poltawski Dan Poltawski added a comment - Integrated, thanks (21, 22, 23, master)
                  Hide
                  Permalink
                  nebgor Aparup Banerjee added a comment -

                  this works for me! (finally, had some vpn probs here)

                  Show
                  nebgor Aparup Banerjee added a comment - this works for me! (finally, had some vpn probs here)
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Congratulations your code is upstream - gold star for you!

                  This issue + 79 others made it in in time for the minor releases.
                  Thank you everyone involved for your exuberant efforts.

                  Show
                  samhemelryk Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      0 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        9/Jul/12