[MDL-33931] Fix the reverted 15% indent on form submit buttons in canvas themes and base - Moodle Tracker

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.3
Fix Version/s: 2.3
Component/s: Themes
Labels:
None

Testing Instructions:
Hide

Log in as the administrator.

Navigate to [Navigation->My Home]

Click 'Manage my private files' in the My private files block (Add the block if it is not present).
[Test] The 'Save changes' and 'Cancel' buttons should be aligned with the other buttons and upload area of the form.

Change the language to a right to left language.

Select a course and either add an activity or edit an existing activity.
[Test] The 'Save and return to course', 'Save and display', and 'Cancel' buttons should be aligned with the other elements on the page (drop down boxes etc.).

Please test other forms and also different themes particularly 'nonzero' and 'binarius'.

To add another language to your page

Go to [Settings->Site administration->Language->Language packs]

Select something like Hebrew (he) or Arabic (ar)

Go to the home page and there should be a select menu for changing languages
Show
Log in as the administrator. Navigate to [Navigation->My Home] Click 'Manage my private files' in the My private files block (Add the block if it is not present). [Test] The 'Save changes' and 'Cancel' buttons should be aligned with the other buttons and upload area of the form. Change the language to a right to left language. Select a course and either add an activity or edit an existing activity. [Test] The 'Save and return to course', 'Save and display', and 'Cancel' buttons should be aligned with the other elements on the page (drop down boxes etc.). Please test other forms and also different themes particularly 'nonzero' and 'binarius'. To add another language to your page Go to [Settings->Site administration->Language->Language packs] Select something like Hebrew (he) or Arabic (ar) Go to the home page and there should be a select menu for changing languages
Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://github.com/abgreeve/moodle.git
Pull Master Branch:
wip-~~MDL-33931~~-master
Pull Master Diff URL:
https://github.com/abgreeve/moodle/compare/wip-MDL-33931-master

Description

The main forms were all improved nicely in ~~MDL-33152~~ by fixing "base".

It seems this was accidentally undone in the linked bug.

Gliffy Diagrams

Attachments

Issue Links

has a non-specific relationship to

MDL-31756 group of mform elements display badly whether label is empty

Closed

is a regression caused by

MDL-32479 RTL Theme fixes for Moodle 2 (theme/base)

Closed

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Martin Dougiamas added a comment - 21/Jun/12 3:27 PM

Adrian identified this as a regression from ~~MDL-32479~~

Show

Martin Dougiamas added a comment - 21/Jun/12 3:27 PM Adrian identified this as a regression from MDL-32479

Hide

Permalink

Adrian Greeve added a comment - 21/Jun/12 3:56 PM

Hello Mary,

I added you as a watcher to this issue because I would like your advice on this fix. As far as I can tell this alteration won't effect the right to left styles, but I'd like you to verify that for me.

Many Thanks.

Show

Adrian Greeve added a comment - 21/Jun/12 3:56 PM Hello Mary, I added you as a watcher to this issue because I would like your advice on this fix. As far as I can tell this alteration won't effect the right to left styles, but I'd like you to verify that for me. Many Thanks.

Hide

Permalink

Adrian Greeve added a comment - 21/Jun/12 3:57 PM - edited

Please note that this patch is made against the master integration branch.
As the diff url won't show anything interesting, the line that I changed was theme/base/style/core.css line: 213

.mform .fitem fieldset.felement {margin-left:15%;padding-left:1%;margin-bottom:0}

Show

Adrian Greeve added a comment - 21/Jun/12 3:57 PM - edited Please note that this patch is made against the master integration branch. As the diff url won't show anything interesting, the line that I changed was theme/base/style/core.css line: 213 .mform .fitem fieldset.felement {margin-left:15%;padding-left:1%;margin-bottom:0}

Hide

Permalink

Martin Dougiamas added a comment - 21/Jun/12 4:01 PM

Can you just quickly test that in some RTL languages? eg Hebrew or Arabic

Show

Martin Dougiamas added a comment - 21/Jun/12 4:01 PM Can you just quickly test that in some RTL languages? eg Hebrew or Arabic

Hide

Permalink

Mary Evans added a comment - 21/Jun/12 5:29 PM

Better check what's happening in ~~MDL-32479~~ because Sam was dealing with that very thing. That small change in the .mform was done in error, and so Sam was going to reverse it to what you have here.

Show

Mary Evans added a comment - 21/Jun/12 5:29 PM Better check what's happening in MDL-32479 because Sam was dealing with that very thing. That small change in the .mform was done in error, and so Sam was going to reverse it to what you have here.

Hide

Permalink

Adrian Greeve added a comment - 22/Jun/12 9:38 AM

I've checked this in Arabic and Hebrew as well as a few other languages. The alignment works from left to right and from right to left. I'll have a chat with Sam when he gets back online.

Show

Adrian Greeve added a comment - 22/Jun/12 9:38 AM I've checked this in Arabic and Hebrew as well as a few other languages. The alignment works from left to right and from right to left. I'll have a chat with Sam when he gets back online.

Hide

Permalink

Sam Hemelryk added a comment - 22/Jun/12 10:26 AM

Thanks Adrian, this has been integrated now

Show

Sam Hemelryk added a comment - 22/Jun/12 10:26 AM Thanks Adrian, this has been integrated now

Hide

Permalink

Sam Hemelryk added a comment - 22/Jun/12 10:38 AM

Tested and passed

Show

Sam Hemelryk added a comment - 22/Jun/12 10:38 AM Tested and passed

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 25/Jun/12 12:42 AM

And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay!

Many, many thanks for your hard work!

Ciao

Show

Eloy Lafuente (stronk7) added a comment - 25/Jun/12 12:42 AM And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay! Many, many thanks for your hard work! Ciao

People

Assignee:

Adrian Greeve

Reporter:

Martin Dougiamas

Integrator:

Sam Hemelryk

Tester:

Sam Hemelryk

Participants:

Adrian Greeve, Eloy Lafuente (stronk7), Martin Dougiamas, Mary Evans, Sam Hemelryk

Votes:

0 Vote for this issue

Watchers:

4 Start watching this issue

Dates

Created:

21/Jun/12 12:12 PM

Updated:

25/Feb/13 7:25 AM

Resolved:

25/Jun/12 12:42 AM

Fix Release Date:

25/Jun/12