Details

    • Type: Bug Bug
    • Status: Reopened
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.3, 2.3.4, 2.4.1
    • Fix Version/s: 2.5.6
    • Component/s: Themes
    • Labels:
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Rank:
      42040

      Description

      Copying my comment from the linked issue

      1. on front page> click on blocks> the block "course description" shows up as blank tab. Clicking on the tab shows the description.
      2. Everything seems to be extremely slow and laggy
      3. When you click on "Settings" it shows the loading icon, and than it takes you to your existing page,before taking to the settings page
      4. Can be my phone but orientation changes were not properly detected.
      5. while editing a book resource, the form fields overlapped with the navigation menu (see the attached pic)
      6. Section pages are really messed up specially when the section doesn't contain any activities or resources.
      7. Drag and drop arrow is completely misplaced.
      8. I was trying to make a attachment to a forum post. Once I opened a filepicker, clicking on x wont close it.
      9. I had "student can manually mark this activity as complete" as the completion criteria for a file resource. I was able to mark the activity as complete from my phone. But it still shows as "uncomplete" when I access the site via desktop.
      10. View a book resource > goto the last chapter > click the up arrow. It should take you to course home page. But nothing really happens.
      11. Goto Quick grading page for any 2.3 assignment. Clicking on quick grading checkbox does nothing.
      12. Goto Quick grading page for any 2.3 assignment. Help icon for "quick grading" cannot be clicked.
      13. Randomly at times I was shown a blank page with just top navigation . Cannot determine the exact steps to reproduce it, but happened a few times.

      Most important thing is file-picker and course-section pages seems really messed up.

      1. jshint.log
        5 kB
        Damyon Wiese
      1. MDL-33934-jshint.jpg
        93 kB
      2. mdl-33934-njscp.png
        5 kB

        Issue Links

          Activity

          Hide
          John Stabinger added a comment -

          Maybe I'm not familiar enough with 2.3 yet, but can you show me a course-section page on the qa site so I can check into this?

          I'll check on the filepicker as well, it worked okay (if not pretty) in 2.2, so maybe something new broke things.

          Show
          John Stabinger added a comment - Maybe I'm not familiar enough with 2.3 yet, but can you show me a course-section page on the qa site so I can check into this? I'll check on the filepicker as well, it worked okay (if not pretty) in 2.2, so maybe something new broke things.
          Hide
          Ankit Agarwal added a comment -

          Hi John,
          I don't think we have section course pages in QA yet, as this is new feature of 2.3. This is how you can get there:-

          1. Goto a course>edit settings>course layout set to "one section per page"
          2. Goto course index page, sections should appear as links. Click on any , it should take you to something like
            (course/view.php?id=2&section=2)

          Also Filepicker has been completely re-written in 2.3, so the changes might be causing issues with the theme.

          Thanks

          Show
          Ankit Agarwal added a comment - Hi John, I don't think we have section course pages in QA yet, as this is new feature of 2.3. This is how you can get there:- Goto a course>edit settings>course layout set to "one section per page" Goto course index page, sections should appear as links. Click on any , it should take you to something like (course/view.php?id=2&section=2) Also Filepicker has been completely re-written in 2.3, so the changes might be causing issues with the theme. Thanks
          Hide
          John Stabinger added a comment -

          I have some updates for this that I will post in the morning. It cleans up a lot of the single section viewing issues, etc.

          John

          Show
          John Stabinger added a comment - I have some updates for this that I will post in the morning. It cleans up a lot of the single section viewing issues, etc. John
          Hide
          John Stabinger added a comment -

          Ankit,

          I added an updated version. This removes the fixed header, does some work on the single sections and new course format, as well as some work on the filepicker.

          I felt these were the most important things to get some work done on.

          Show
          John Stabinger added a comment - Ankit, I added an updated version. This removes the fixed header, does some work on the single sections and new course format, as well as some work on the filepicker. I felt these were the most important things to get some work done on.
          Hide
          Ankit Agarwal added a comment - - edited

          Hey John,
          Thanks for the patch, I haven't had time to test your patch, but send this for peer-review, so someone can review it.
          Thanks

          Show
          Ankit Agarwal added a comment - - edited Hey John, Thanks for the patch, I haven't had time to test your patch, but send this for peer-review, so someone can review it. Thanks
          Hide
          John Stabinger added a comment -

          I'd really like to get this in. Who can be set as a peer reviewer?

          Show
          John Stabinger added a comment - I'd really like to get this in. Who can be set as a peer reviewer?
          Hide
          Ankit Agarwal added a comment - - edited

          Hi John,
          Send it to peer review without assigning anyone as reviewer. I might not be the best person to review mobile stuff. Someone with more experience with mobiles will pick it up.

          Thanks

          Show
          Ankit Agarwal added a comment - - edited Hi John, Send it to peer review without assigning anyone as reviewer. I might not be the best person to review mobile stuff. Someone with more experience with mobiles will pick it up. Thanks
          Hide
          Joshua Holden added a comment -

          I was trying to use the file picker to upload grades (via CSV) from my phone and I didn't get the menu to choose ay source for the file except uploading. (I wanted to try to get a spreadsheet from GoogleDocs — dont know if that would have worked anyway but that's another story.) When I tried on my computer the menu was there. Sounds like it's related?

          Show
          Joshua Holden added a comment - I was trying to use the file picker to upload grades (via CSV) from my phone and I didn't get the menu to choose ay source for the file except uploading. (I wanted to try to get a spreadsheet from GoogleDocs — dont know if that would have worked anyway but that's another story.) When I tried on my computer the menu was there. Sounds like it's related?
          Hide
          John Stabinger added a comment -

          I'm not seeing that. With the version above (for 2.3+) you should be able to get the filepicker's full list of options.

          Show
          John Stabinger added a comment - I'm not seeing that. With the version above (for 2.3+) you should be able to get the filepicker's full list of options.
          Hide
          John Stabinger added a comment -

          Updated this with newer release code, some fixes and enhancements. Has updates to correct for:

          MDL-33115
          MDL-35234
          MDL-34818

          Show
          John Stabinger added a comment - Updated this with newer release code, some fixes and enhancements. Has updates to correct for: MDL-33115 MDL-35234 MDL-34818
          Hide
          Mary Evans added a comment -

          Hi John,

          Are you intending setting any of these fixes for integration?

          Show
          Mary Evans added a comment - Hi John, Are you intending setting any of these fixes for integration?
          Hide
          John Stabinger added a comment -

          I would like to have this integrated, but I do not know how.

          Show
          John Stabinger added a comment - I would like to have this integrated, but I do not know how.
          Hide
          Mary Evans added a comment -

          We need Testing Instructions if you could add them?
          Also please change the Fix Version to whatever you want it to fix. It will automatically go into Master, but if it needs to go into stable backlog then can you set it to do that too?

          You will also need to Rebase this. You can do that after you have updated your current master branch and then rebase MDL-33934-2 branch using...

          git rebase master MDL-33934-2

          If you suddenly get ANY conflicts then abort the process altogether with...

          git rebase --abort

          Hope this helps?
          Mary

          Show
          Mary Evans added a comment - We need Testing Instructions if you could add them? Also please change the Fix Version to whatever you want it to fix. It will automatically go into Master, but if it needs to go into stable backlog then can you set it to do that too? You will also need to Rebase this. You can do that after you have updated your current master branch and then rebase MDL-33934 -2 branch using... git rebase master MDL-33934 -2 If you suddenly get ANY conflicts then abort the process altogether with... git rebase --abort Hope this helps? Mary
          Hide
          Mary Evans added a comment - - edited

          @John

          Can you let me know when you have done the rebase?

          Thanks

          Show
          Mary Evans added a comment - - edited @John Can you let me know when you have done the rebase? Thanks
          Hide
          Dan Poltawski added a comment -

          Hi Sorry, but we can't integrate this with it conflicting like this.

          Please submit for integration when conflicts are resolved and there is testing instructions.

          Show
          Dan Poltawski added a comment - Hi Sorry, but we can't integrate this with it conflicting like this. Please submit for integration when conflicts are resolved and there is testing instructions.
          Hide
          Todd Thornton added a comment -

          Just wanted to elaborate more on the Book module in particular. Not sure if this is where I need to post this, but to me the navigation in the module itself could be changed that would improve all views specifically mobile. The navigation buttons are too small (IMHO) and too close together and to close to the edge of the screen to effectively navigate using a tablet or phone. If you doubled the current size of the arrows more similar to most current Flip-books and centered (either center bottom or center top or both)then the usability would be improved dramatically across all devices.

          Show
          Todd Thornton added a comment - Just wanted to elaborate more on the Book module in particular. Not sure if this is where I need to post this, but to me the navigation in the module itself could be changed that would improve all views specifically mobile. The navigation buttons are too small (IMHO) and too close together and to close to the edge of the screen to effectively navigate using a tablet or phone. If you doubled the current size of the arrows more similar to most current Flip-books and centered (either center bottom or center top or both)then the usability would be improved dramatically across all devices.
          Hide
          Mary Evans added a comment -

          @ Dan Poltawski
          I'm about to add some changes to MyMobile theme which John has done, but unfortunately not able to add here himself, so I have picked it and just about to do some testing for the moment to see what's happening with this theme.

          Show
          Mary Evans added a comment - @ Dan Poltawski I'm about to add some changes to MyMobile theme which John has done, but unfortunately not able to add here himself, so I have picked it and just about to do some testing for the moment to see what's happening with this theme.
          Hide
          Mary Evans added a comment -

          @ Todd Thornton

          Sorry Todd, but this is not the place to add your comments about a bug with the book module, you would be better off creating a new issue so that we can track the problem you have with MyMobile theme when using the book module.

          Thanks
          Mary

          Show
          Mary Evans added a comment - @ Todd Thornton Sorry Todd, but this is not the place to add your comments about a bug with the book module, you would be better off creating a new issue so that we can track the problem you have with MyMobile theme when using the book module. Thanks Mary
          Hide
          Mary Evans added a comment -

          Seems to work OK

          Show
          Mary Evans added a comment - Seems to work OK
          Hide
          Gareth J Barnard added a comment -

          Mary Evans

          Whilst looking at MyMobile in layout/general.php, I noticed:

          // TODO: Fix this hardcoding there are other course formats that peopleuse.
          //       Probably changing to an appropriate regex will do.
          if ($mypagetype == 'course-view-topics' || $mypagetype == 'course-view-weeks') {
              // jump to current topic only in course pages
              $jumptocurrent = 'true';
          } else {
              $jumptocurrent = 'false';
          }
          

          this can be fixed for all course formats by changing to:

          if ($mylayoutype == 'course') {
              // Jump to current topic only in course pages.
              $jumptocurrent = 'true';
          } else {
              $jumptocurrent = 'false';
          }
          

          Thus benefiting Collapsed Topics but not being Collapsed Topics specific.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Mary Evans Whilst looking at MyMobile in layout/general.php, I noticed: // TODO: Fix this hardcoding there are other course formats that peopleuse. // Probably changing to an appropriate regex will do . if ($mypagetype == 'course-view-topics' || $mypagetype == 'course-view-weeks') { // jump to current topic only in course pages $jumptocurrent = ' true '; } else { $jumptocurrent = ' false '; } this can be fixed for all course formats by changing to: if ($mylayoutype == 'course') { // Jump to current topic only in course pages. $jumptocurrent = ' true '; } else { $jumptocurrent = ' false '; } Thus benefiting Collapsed Topics but not being Collapsed Topics specific. Cheers, Gareth
          Hide
          Gareth J Barnard added a comment - - edited

          Dear Mary Evans

          Whilst this issue pertains to issues with the MyMobile theme, I'm wondering if an issue I'm experiencing with Collapsed Topics is not generic.

          The issue is that with the default jQueryMobile data-ajax set to true on the site index page when you navigate to a course page, none of the additional JavaScript is loaded as set-up on the page by the page requirements manager - say a call to '$PAGE->requires->js_init_call' - looking in FireBug this means that the standard 'format.js' and 'module.js' files of the course format are not loaded and thus lines like:

          M.yui.add_module({"format_topcoll":{"name":"format_topcoll","fullpath":"http:\/\/x.x.x.x\/moodle23\/course\/format\/topcoll\/module.js","requires":[]}});
          

          Do not seem to operate. I've tried lots of things as has John by getting the jQuery to include 'module.js' with the page before create and page create events. However, as the above code does not appear to operate, then YUI does not know about 'format_topcoll' and hence:

          Y.use('format_topcoll', function(Y) { M.format_topcoll.init(Y, "http:\/\/x.x.x.x\/moodle23", "2", "0jz6rk000000", "10", 1, 1); });
          

          Does not work in initialising the format. My code uses standard $PAGE requires techniques as mandated by the API.

          The only fix I've found for this is in 'custom.js' of the theme:

          $('#page-site-indexPAGE a').attr("data-ajax", "false");
          

          Or to refresh the course page once loaded as then the browser parses the html it already has and fetches the JavaScript as the markup is correct.

          On consideration, the fix would apply to all course formats and indeed core formats as the standard 'format.js' is not parsed causing potential issues when editing. And indeed if other functionality were ever added.

          I realise that the fix reduces the efficiency of the site index page, however, with some 140 fetches in 'developer' mode, surely other optimisations could be made generally for all themes?

          Linked to MDL-33115.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - - edited Dear Mary Evans Whilst this issue pertains to issues with the MyMobile theme, I'm wondering if an issue I'm experiencing with Collapsed Topics is not generic. The issue is that with the default jQueryMobile data-ajax set to true on the site index page when you navigate to a course page, none of the additional JavaScript is loaded as set-up on the page by the page requirements manager - say a call to '$PAGE->requires->js_init_call' - looking in FireBug this means that the standard 'format.js' and 'module.js' files of the course format are not loaded and thus lines like: M.yui.add_module({ "format_topcoll" :{ "name" : "format_topcoll" , "fullpath" : "http:\/\/x.x.x.x\/moodle23\/course\/format\/topcoll\/module.js" , "requires" :[]}}); Do not seem to operate. I've tried lots of things as has John by getting the jQuery to include 'module.js' with the page before create and page create events. However, as the above code does not appear to operate, then YUI does not know about 'format_topcoll' and hence: Y.use('format_topcoll', function(Y) { M.format_topcoll.init(Y, "http:\/\/x.x.x.x\/moodle23" , "2" , "0jz6rk000000" , "10" , 1, 1); }); Does not work in initialising the format. My code uses standard $PAGE requires techniques as mandated by the API. The only fix I've found for this is in 'custom.js' of the theme: $('#page-site-indexPAGE a').attr( "data-ajax" , " false " ); Or to refresh the course page once loaded as then the browser parses the html it already has and fetches the JavaScript as the markup is correct. On consideration, the fix would apply to all course formats and indeed core formats as the standard 'format.js' is not parsed causing potential issues when editing. And indeed if other functionality were ever added. I realise that the fix reduces the efficiency of the site index page, however, with some 140 fetches in 'developer' mode, surely other optimisations could be made generally for all themes? Linked to MDL-33115 . Cheers, Gareth
          Hide
          Gareth J Barnard added a comment -

          Dear Mary Evans

          In reading http://jquerymobile.com/test/docs/api/events.html it looks like in custom.js the opening:

          $(document).ready(function() {
          

          is wrong, I tried replacing it with:

          $(document).on('pageinit', function(event)
          

          but that did not work, so tried:

          $(document).live('pageinit', function(event)
          

          and that did not work too. So, commented it out completely such that:

          //$(document).ready(function() {
          ...
          //});
          

          And everything works without it, and I think does so faster. Perhaps some other testing as the JQueryMobile page not recommending use of '$(document).ready()'.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mary Evans In reading http://jquerymobile.com/test/docs/api/events.html it looks like in custom.js the opening: $(document).ready(function() { is wrong, I tried replacing it with: $(document).on('pageinit', function(event) but that did not work, so tried: $(document).live('pageinit', function(event) and that did not work too. So, commented it out completely such that: //$(document).ready(function() { ... //}); And everything works without it, and I think does so faster. Perhaps some other testing as the JQueryMobile page not recommending use of '$(document).ready()'. Cheers, Gareth
          Hide
          Mary Evans added a comment -

          Gareth,

          I know this could be a typo in this page, but if you added the code as you wrote it here is this correct?

          $(document).live('pageinit', function(event)

          Should it not be this...with closing bracket ) ?

          $(document).live('pageinit', function(event))
          Show
          Mary Evans added a comment - Gareth, I know this could be a typo in this page, but if you added the code as you wrote it here is this correct? $(document).live('pageinit', function(event) Should it not be this...with closing bracket ) ? $(document).live('pageinit', function(event))
          Hide
          Gareth J Barnard added a comment -

          Mary Evans

          Nope! No typo, just not enough explanation on my part, should really be:

          $(document).live('pageinit', function(event) {
          

          does not replace

          $(document).ready(function() {
          

          However, taking it out completely allows the .live calls underneath to operate fine.

          Is John S ok as you said you've taken over from him? His last commit in his area was 15 days ago.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Mary Evans Nope! No typo, just not enough explanation on my part, should really be: $(document).live('pageinit', function(event) { does not replace $(document).ready(function() { However, taking it out completely allows the .live calls underneath to operate fine. Is John S ok as you said you've taken over from him? His last commit in his area was 15 days ago. Cheers, Gareth
          Hide
          Mary Evans added a comment -

          John is snowed under with work. I'm just trying to get his fixes into Moodle, that's all and as this is based on the the same css and JavaScript we need to remove in MDL-37749, with the collapsed topic stuff, I though this would be better being integrated first. Now I am worrying, as I am not that familiar with jQuery, I tend to just copy and paste code, but do usually try to work it out when I use it in themes. I've not had time to digest this mobile.js so feeling a bit of a rookie!

          Show
          Mary Evans added a comment - John is snowed under with work. I'm just trying to get his fixes into Moodle, that's all and as this is based on the the same css and JavaScript we need to remove in MDL-37749 , with the collapsed topic stuff, I though this would be better being integrated first. Now I am worrying, as I am not that familiar with jQuery, I tend to just copy and paste code, but do usually try to work it out when I use it in themes. I've not had time to digest this mobile.js so feeling a bit of a rookie!
          Hide
          Gareth J Barnard added a comment -

          Dear Mary Evans

          No worries. I taught myself jQueryMobile in a week after using jQuery for a little bit of client side AJAX calls. Just PM me with questions . The jQueryMobile docs are really good with examples - http://jquerymobile.com/demos/1.2.0/.

          I've tested the above and seems fine, just needs testing by others to confirm this.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mary Evans No worries. I taught myself jQueryMobile in a week after using jQuery for a little bit of client side AJAX calls. Just PM me with questions . The jQueryMobile docs are really good with examples - http://jquerymobile.com/demos/1.2.0/ . I've tested the above and seems fine, just needs testing by others to confirm this. Cheers, Gareth
          Hide
          Gareth J Barnard added a comment - - edited

          Dear Mary,

          I've learnt a bit more about:

          $(document).ready(function() {
          

          overnight through investigation. At the moment, as the file that has it is sandwiched between the jQuery loading and the jQueryMobile loading. In essence the custom.js currently establishes event hooks that are jQueryMobile specific before jQueryMobile operates. Although removing the .ready() function works as the contained code operates on jQueryMobile pageinit and pagebeforecreate events etc. there are three variables that use the DOM to get their value:

          //get some vars to start
          var siteurl = $('.mobilesiteurl').attr("id");
          var mytheme = $(".datatheme").attr("id");
          var mythemeb = $(".datathemeb").attr("id");
          

          and removing them puts them at risk with the unpredictability of threads and the DOM passing 'loading' state. However, through investigation, if they are replaced with header meta tags:

          <meta name="wwwroot" wwwroot="<?php p($CFG->wwwroot); ?>" />
          <meta name="datatheme" datatheme="<?php echo $dtheme;?>" />
          ....
          

          etc. and using:

          var siteurl = $('head meta[name=wwwroot]').attr('wwwroot');
          var mytheme = $('head meta[name=datatheme]').attr('datatheme');
          .....
          

          Then this is safe because the 'head' element has finished processing and is 'ready' because it was it's execution that invoked the jQuery etc. in the first place.

          This can be seen by using 'console.log' in FireBug to see the value of things before the ECMAScript thread updates what they point to when you use FireBug to investigate their contents and loose hair in the process trying to figure out why the code does not work for the state of the variables. So moving the initialisation parameters to the head from the body means that there is less code and not having to use .ready() in a jQueryMobile context. Therefore the code should operate on all pages more reliably with AJAX caching.

          I hope I've made sense!

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - - edited Dear Mary, I've learnt a bit more about: $(document).ready(function() { overnight through investigation. At the moment, as the file that has it is sandwiched between the jQuery loading and the jQueryMobile loading. In essence the custom.js currently establishes event hooks that are jQueryMobile specific before jQueryMobile operates. Although removing the .ready() function works as the contained code operates on jQueryMobile pageinit and pagebeforecreate events etc. there are three variables that use the DOM to get their value: //get some vars to start var siteurl = $('.mobilesiteurl').attr( "id" ); var mytheme = $( ".datatheme" ).attr( "id" ); var mythemeb = $( ".datathemeb" ).attr( "id" ); and removing them puts them at risk with the unpredictability of threads and the DOM passing 'loading' state. However, through investigation, if they are replaced with header meta tags: <meta name= "wwwroot" wwwroot= "<?php p($CFG->wwwroot); ?>" /> <meta name= "datatheme" datatheme= "<?php echo $dtheme;?>" /> .... etc. and using: var siteurl = $('head meta[name=wwwroot]').attr('wwwroot'); var mytheme = $('head meta[name=datatheme]').attr('datatheme'); ..... Then this is safe because the 'head' element has finished processing and is 'ready' because it was it's execution that invoked the jQuery etc. in the first place. This can be seen by using 'console.log' in FireBug to see the value of things before the ECMAScript thread updates what they point to when you use FireBug to investigate their contents and loose hair in the process trying to figure out why the code does not work for the state of the variables. So moving the initialisation parameters to the head from the body means that there is less code and not having to use .ready() in a jQueryMobile context. Therefore the code should operate on all pages more reliably with AJAX caching. I hope I've made sense! Cheers, Gareth
          Hide
          Mary Evans added a comment -

          Is this important as I have just done some jiggery-pokery with this branch already! I'm ready for jumping in the lake right now and I wont me shouting Excalibur either!

          Show
          Mary Evans added a comment - Is this important as I have just done some jiggery-pokery with this branch already! I'm ready for jumping in the lake right now and I wont me shouting Excalibur either!
          Hide
          Gareth J Barnard added a comment -

          Sorry Mary,

          Notes for the once and future theme to be implemented at a later date . I think they will end up in an improvements tracker issue.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Sorry Mary, Notes for the once and future theme to be implemented at a later date . I think they will end up in an improvements tracker issue. Cheers, Gareth
          Hide
          Mary Evans added a comment -

          I've just done them

          Show
          Mary Evans added a comment - I've just done them
          Hide
          Gareth J Barnard added a comment -

          Wow! Logically,

          //get some vars to start
          var siteurl = $('.mobilesiteurl').attr("id");
          var mytheme = $(".datatheme").attr("id");
          var mythemeb = $(".datathemeb").attr("id");
          

          Should be fine as they are not used until after the DOM is ready within the pageinit type events and as I've found out through FireBug references are updated when the DOM is ready on calls that have happened before it is. However, I'm not certain. But all testing so far has been fine and things seem to be faster. That's why I now think the meta tag idea is better in the head.

          Oh so complicated!

          I hope this does not need another change.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Wow! Logically, //get some vars to start var siteurl = $('.mobilesiteurl').attr( "id" ); var mytheme = $( ".datatheme" ).attr( "id" ); var mythemeb = $( ".datathemeb" ).attr( "id" ); Should be fine as they are not used until after the DOM is ready within the pageinit type events and as I've found out through FireBug references are updated when the DOM is ready on calls that have happened before it is. However, I'm not certain. But all testing so far has been fine and things seem to be faster. That's why I now think the meta tag idea is better in the head. Oh so complicated! I hope this does not need another change. Cheers, Gareth
          Hide
          Mary Evans added a comment -

          I forgot to add you as Peer Reviewer so just done it.

          Show
          Mary Evans added a comment - I forgot to add you as Peer Reviewer so just done it.
          Hide
          Mary Evans added a comment - - edited

          Thanks for testing/peer-reviewing this as I have been working on it.
          Let's see what the DEV's have to say

          Show
          Mary Evans added a comment - - edited Thanks for testing/peer-reviewing this as I have been working on it. Let's see what the DEV's have to say
          Hide
          Gareth J Barnard added a comment -

          No problem

          Show
          Gareth J Barnard added a comment - No problem
          Hide
          Damyon Wiese added a comment -

          Hi Mary,

          Thanks for working on this - it looks like a big set of changes.

          Can you please add testing instructions for this?

          If you have specifically fixed the items listed in the description - that would be a good start for the testing instructions.

          Some other comments:

          There is commented out code in theme/mymobile/javascript/custom.js - we shouldn't leave that in.

          We have recently added jshint settings to Moodle now - you can run it on this code with "jshint theme/mymobile/javascript/custom.js".

          To install jshint you can first install node.js and then run "npm install jshint" (we may add it to the codechecker in future).

          I'll attach the output I get from jshint to this bug (58 warnings).

          I also see white space errors in "theme/mymobile/settings.php"

          Thanks, Damyon

          Show
          Damyon Wiese added a comment - Hi Mary, Thanks for working on this - it looks like a big set of changes. Can you please add testing instructions for this? If you have specifically fixed the items listed in the description - that would be a good start for the testing instructions. Some other comments: There is commented out code in theme/mymobile/javascript/custom.js - we shouldn't leave that in. We have recently added jshint settings to Moodle now - you can run it on this code with "jshint theme/mymobile/javascript/custom.js". To install jshint you can first install node.js and then run "npm install jshint" (we may add it to the codechecker in future). I'll attach the output I get from jshint to this bug (58 warnings). I also see white space errors in "theme/mymobile/settings.php" Thanks, Damyon
          Hide
          Gareth J Barnard added a comment -

          Dear Mary,

          I think there is some instructions on the developer's forum for installing jshint that Tim gave me a link for. I can post later as the link is on my other computer. But it should be in the dev chat logs too. Also there is an online version where you can copy / paste / check -> http://www.jshint.com/.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mary, I think there is some instructions on the developer's forum for installing jshint that Tim gave me a link for. I can post later as the link is on my other computer. But it should be in the dev chat logs too. Also there is an online version where you can copy / paste / check -> http://www.jshint.com/ . Cheers, Gareth
          Hide
          Mary Evans added a comment -

          Thanks Gareth. I see what transpires, although I doubt that I will get very far with it. It took me ages using the codechecker the first time I used it! LOL

          Looks like this is not going to get very far with MDL-37749_master as that needs this fixing first!

          Show
          Mary Evans added a comment - Thanks Gareth. I see what transpires, although I doubt that I will get very far with it. It took me ages using the codechecker the first time I used it! LOL Looks like this is not going to get very far with MDL-37749 _master as that needs this fixing first!
          Hide
          Mary Evans added a comment -

          @Damyon I am currently waiting for John Stabinger to send me the Test Instructions as he has done the work but was unable to continue so I offered to finish off and submit for Integration Review.

          Sorry for the wait!

          Show
          Mary Evans added a comment - @Damyon I am currently waiting for John Stabinger to send me the Test Instructions as he has done the work but was unable to continue so I offered to finish off and submit for Integration Review. Sorry for the wait!
          Hide
          Gareth J Barnard added a comment -

          Dear Mary,

          No problem. I'm currently looking into why the 'Exit book' button does not work with the book module in the theme.

          Looking at 'jshint.log' most are easily fixed, also all of the 'ui' / 'event' parameters can be removed and code should still work:

          theme/mymobile/javascript/custom.js: line 15, col 57, 'ui' is defined but never used.
          theme/mymobile/javascript/custom.js: line 15, col 53, 'event' is defined but never used.
          

          I've tested a few and it seems fine.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mary, No problem. I'm currently looking into why the 'Exit book' button does not work with the book module in the theme. Looking at 'jshint.log' most are easily fixed, also all of the 'ui' / 'event' parameters can be removed and code should still work: theme/mymobile/javascript/custom.js: line 15, col 57, 'ui' is defined but never used. theme/mymobile/javascript/custom.js: line 15, col 53, 'event' is defined but never used. I've tested a few and it seems fine. Cheers, Gareth
          Hide
          Mary Evans added a comment -

          Hi Gareth,

          If you find any errors with the theme, can you report them as individual BUGS?

          Thanks

          Show
          Mary Evans added a comment - Hi Gareth, If you find any errors with the theme, can you report them as individual BUGS? Thanks
          Hide
          Mary Evans added a comment -

          @Damyon:

          Just to make it clear what changes have taken place. According to John Stabinger who has been working on this since last month, the updates included changes to upgrade to the latest version (at the time) of jQuery Mobile. There were also stylistic changes brought about by theme changes in 2.4. A theme setting was also added to turn on/off AJAX page loading.

          I'm not familiar with the jsHint software (whatever) but I have used CodeChecker. What I am concerned about is, if the settings page has some white-space, then why is it I don't see it? Unless it is because John uses a Mac?

          Anyway whatever happens with this, I suppose I can deal with it. Or learn how to! LOL

          Show
          Mary Evans added a comment - @Damyon: Just to make it clear what changes have taken place. According to John Stabinger who has been working on this since last month, the updates included changes to upgrade to the latest version (at the time) of jQuery Mobile. There were also stylistic changes brought about by theme changes in 2.4. A theme setting was also added to turn on/off AJAX page loading. I'm not familiar with the jsHint software (whatever) but I have used CodeChecker. What I am concerned about is, if the settings page has some white-space, then why is it I don't see it? Unless it is because John uses a Mac? Anyway whatever happens with this, I suppose I can deal with it. Or learn how to! LOL
          Hide
          Damyon Wiese added a comment -

          Thanks Mary for the testing instructions.

          The jshint warnings are just warnings - fixing them is not a blocker for integrating this issue (And it will be good to get this integrated as it is blocking other issues).

          The major issue is in theme/mymobile/javascript/custom.js line 5

          //$(document).ready(function() {
          

          I am not sure if this is intentionally commented or not - but it breaks the nesting of the javascript because the corresponding close at the end of the file is not commented. Can you either update the patch or just add a comment to say whether this should be commented or not ?

          I am happy to fix the whitespace issues during integration.

          Show
          Damyon Wiese added a comment - Thanks Mary for the testing instructions. The jshint warnings are just warnings - fixing them is not a blocker for integrating this issue (And it will be good to get this integrated as it is blocking other issues). The major issue is in theme/mymobile/javascript/custom.js line 5 //$(document).ready(function() { I am not sure if this is intentionally commented or not - but it breaks the nesting of the javascript because the corresponding close at the end of the file is not commented. Can you either update the patch or just add a comment to say whether this should be commented or not ? I am happy to fix the whitespace issues during integration.
          Hide
          Gareth J Barnard added a comment -

          Dear Mary,

          I will report them as individual bugs - sorry for putting them here - was a part of the discussion on issues with the theme .

          For now, I think that:

          //$(document).ready(function() {
          

          should go back in given the order of script loading. I have a better solution but will submit this as a separate issue.

          I have lots of difficulty in seeing white space so use Notepad++ with a bold colour for the 'whitespace' option.

          Once again, sorry for cluttering up this tracker with MyMobile issues not in the patch.

          Kind regards,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mary, I will report them as individual bugs - sorry for putting them here - was a part of the discussion on issues with the theme . For now, I think that: //$(document).ready(function() { should go back in given the order of script loading. I have a better solution but will submit this as a separate issue. I have lots of difficulty in seeing white space so use Notepad++ with a bold colour for the 'whitespace' option. Once again, sorry for cluttering up this tracker with MyMobile issues not in the patch. Kind regards, Gareth
          Hide
          Mary Evans added a comment - - edited

          @Damyon I have cancelled the commented out section and left it as it was originally. It was a misunderstanding on my part during the process of committing the whole of MDL-33934_master. I miss interpreted Gareth's comments in the discussion about problems with MyMoble theme in general.

          I think it's ready to roll now.

          Thanks
          Mary

          Show
          Mary Evans added a comment - - edited @Damyon I have cancelled the commented out section and left it as it was originally. It was a misunderstanding on my part during the process of committing the whole of MDL-33934 _master. I miss interpreted Gareth's comments in the discussion about problems with MyMoble theme in general. I think it's ready to roll now. Thanks Mary
          Hide
          Mary Evans added a comment -

          @anybody!

          RE: jsHint

          How do you actually install it into Moodle? Is it similar to Codechecker which you add to moodle/local/?

          If this is the case it should be easy enough to use.

          If it isn't, then I will need some more instructions.

          Thanks
          Mary

          Show
          Mary Evans added a comment - @anybody! RE: jsHint How do you actually install it into Moodle? Is it similar to Codechecker which you add to moodle/local/? If this is the case it should be easy enough to use. If it isn't, then I will need some more instructions. Thanks Mary
          Hide
          Gareth J Barnard added a comment -

          Dear Mary,

          I've tracked down the installation instructions that Tim told me about -> https://moodle.org/mod/forum/discuss.php?d=217450#p959882

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mary, I've tracked down the installation instructions that Tim told me about -> https://moodle.org/mod/forum/discuss.php?d=217450#p959882 Cheers, Gareth
          Hide
          Mary Evans added a comment -

          Thanks Gareth!

          Downloaded and install jsnode. That was easy. Installing jshint is causing me concern, as it does not seem to be doing anything. I just set a strange message which means noting to me.

          See image attached.

          Show
          Mary Evans added a comment - Thanks Gareth! Downloaded and install jsnode. That was easy. Installing jshint is causing me concern, as it does not seem to be doing anything. I just set a strange message which means noting to me. See image attached.
          Hide
          Mary Evans added a comment -

          Attached image MDL-32934-jshint.jpg

          Show
          Mary Evans added a comment - Attached image MDL-32934 -jshint.jpg
          Hide
          Gareth J Barnard added a comment -

          Dear Mary,

          You need to run the 'Node.js command prompt' shortcut on the start menu

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mary, You need to run the 'Node.js command prompt' shortcut on the start menu Cheers, Gareth
          Hide
          Mary Evans added a comment -

          Now I know why people talk in GEEK, it's to confuse people! lol

          There is only the Node.js icon in my start menu. The fact it looks like a command prompt had me fooled. I had to go looking for a shortcut to the node.js command prompt.

          OK...I think I am on the right track now. Just need to see how it works.

          Thanks

          Show
          Mary Evans added a comment - Now I know why people talk in GEEK, it's to confuse people! lol There is only the Node.js icon in my start menu. The fact it looks like a command prompt had me fooled. I had to go looking for a shortcut to the node.js command prompt. OK...I think I am on the right track now. Just need to see how it works. Thanks
          Hide
          Gareth J Barnard added a comment -

          Hence the old saying 'Beware of Geeks using Git'

          Show
          Gareth J Barnard added a comment - Hence the old saying 'Beware of Geeks using Git'
          Hide
          Mary Evans added a comment - - edited

          I must be doing something wrong, although I have have changed directory to get to moodle root on my localhost server, and after entering the call as expleined by Colin Chambers, it does not seem to recognise jshint --config .jshintrc theme/mymobile/javascript/custom.js because it says that jshint is not recognised as an internal or external command!

          Oh why can't things be simple!

          Show
          Mary Evans added a comment - - edited I must be doing something wrong, although I have have changed directory to get to moodle root on my localhost server, and after entering the call as expleined by Colin Chambers, it does not seem to recognise jshint --config .jshintrc theme/mymobile/javascript/custom.js because it says that jshint is not recognised as an internal or external command! Oh why can't things be simple!
          Hide
          Mary Evans added a comment -

          Got it!

          The problem was it had not installed, as I thought it had, so on checking it appears I got a warning which I must have missed. Apparently I have left of the -g command.

          So custom.js has 55 Errors! Just like the log that Damyon uploaded.

          Show
          Mary Evans added a comment - Got it! The problem was it had not installed, as I thought it had, so on checking it appears I got a warning which I must have missed. Apparently I have left of the -g command. So custom.js has 55 Errors! Just like the log that Damyon uploaded.
          Hide
          Damyon Wiese added a comment -

          Thanks for making the effort Mary to install jshint, it is appreciated.

          I'll take this issue out of integration for this week (it's wednesday already!) which will give you a chance to look at those js warnings. Note - the only critical thing I found has been fixed which was the commented line of code.

          Regards, Damyon

          Show
          Damyon Wiese added a comment - Thanks for making the effort Mary to install jshint, it is appreciated. I'll take this issue out of integration for this week (it's wednesday already!) which will give you a chance to look at those js warnings. Note - the only critical thing I found has been fixed which was the commented line of code. Regards, Damyon
          Hide
          CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          Mary Evans added a comment -

          Thanks Damyon.

          I've reduced the js warnings down to 50, but the problem is as two or three get fixed others appear. Like a never-ending story!

          I'm just wondering if I could remove the redundant files from MDL-38072 in this issue. That would save time wouldn't it? They have been safely removed from 2.3 and 2.4 stable branches so there should be no problem in master.

          Show
          Mary Evans added a comment - Thanks Damyon. I've reduced the js warnings down to 50, but the problem is as two or three get fixed others appear. Like a never-ending story! I'm just wondering if I could remove the redundant files from MDL-38072 in this issue. That would save time wouldn't it? They have been safely removed from 2.3 and 2.4 stable branches so there should be no problem in master.
          Hide
          Damyon Wiese added a comment -

          That's fine with me Mary

          Show
          Damyon Wiese added a comment - That's fine with me Mary
          Hide
          Mary Evans added a comment -

          This issue will include MDL-38072.

          Show
          Mary Evans added a comment - This issue will include MDL-38072 .
          Hide
          Damyon Wiese added a comment -

          Hi Mary,

          I have pushed this to master now.

          I added a commit to fix a few white space errors and other minor cleanups.

          Unless this issue fails testing additional improvements should be listed in a new tracker.

          Thanks!

          Show
          Damyon Wiese added a comment - Hi Mary, I have pushed this to master now. I added a commit to fix a few white space errors and other minor cleanups. Unless this issue fails testing additional improvements should be listed in a new tracker. Thanks!
          Hide
          Frédéric Massart added a comment - - edited

          Thanks for you work on this Mary, unfortunately I have to fail the test.

          1. It is impossible to expand a section in the collapsible format
          2. The patch removes the regression fixed in MDL-36305 (Button to reply to forum post disappeared)
          3. Why deleting the file readme_moodle.txt?
          4. Why not following the instructions of readme_moodle.txt when updating the library? Though I noticed that the git hash is wrong, my bad :-/
          5. The RTL rules are removed, don't we need a few of them at least?
          6. I had fixed a bunch of things with the 2.4 icons, which have been reverted:
            • Size of the icons
            • Display of conditions to access the activity
            • Display of the description of an activity
            • ...

          I think those issues should be fixed as part of this one, instead of creating new issues to re-implement all the changes reverted in here.

          Many thanks!
          Fred

          Show
          Frédéric Massart added a comment - - edited Thanks for you work on this Mary, unfortunately I have to fail the test. It is impossible to expand a section in the collapsible format The patch removes the regression fixed in MDL-36305 (Button to reply to forum post disappeared) Why deleting the file readme_moodle.txt? Why not following the instructions of readme_moodle.txt when updating the library? Though I noticed that the git hash is wrong, my bad :-/ The RTL rules are removed, don't we need a few of them at least? I had fixed a bunch of things with the 2.4 icons, which have been reverted: Size of the icons Display of conditions to access the activity Display of the description of an activity ... I think those issues should be fixed as part of this one, instead of creating new issues to re-implement all the changes reverted in here. Many thanks! Fred
          Hide
          Gareth J Barnard added a comment -

          Dear Fred,

          RE: Part 1.

          This is not a reason to fail the test. As the developer of the Collapsed Topics format it is precisely the current inclusion of specific contributed code in core that is causing a problem. Martin D has stated on the forums (I hope I'm quoting him correctly) that core should not have changes for contributed code.

          The code in question is causing me grief and preventing me making a better user experience for the users. The reason behind the current failure is all to do with AJAX loading or lack of my 'module.js' file (and indeed all other course format's module.js files) because the script inclusion code is not within the jQueryMobile page (my comments of the 18th Feb on MDL-33115). This is a separate bug in core (as it affects topics and weeks formats too and possibly any other module core or otherwise that uses the page requirements manager to include JavaScript). This is all documented on my forthcoming releases, if you wish to test with my current development version for 2.3 please use the code on https://github.com/gjb2048/moodle-format_topcoll/tree/MOODLE_23.

          However, if the toggles do not work, then either it's a problem in my code which I will fix is not Moodle HQ's responsibility or a general bug in core code that I will report.

          Please kindly allow these changes to proceed without test 1 being a stipulation.

          Kind regards,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Fred, RE: Part 1. This is not a reason to fail the test. As the developer of the Collapsed Topics format it is precisely the current inclusion of specific contributed code in core that is causing a problem. Martin D has stated on the forums (I hope I'm quoting him correctly) that core should not have changes for contributed code. The code in question is causing me grief and preventing me making a better user experience for the users. The reason behind the current failure is all to do with AJAX loading or lack of my 'module.js' file (and indeed all other course format's module.js files) because the script inclusion code is not within the jQueryMobile page (my comments of the 18th Feb on MDL-33115 ). This is a separate bug in core (as it affects topics and weeks formats too and possibly any other module core or otherwise that uses the page requirements manager to include JavaScript). This is all documented on my forthcoming releases, if you wish to test with my current development version for 2.3 please use the code on https://github.com/gjb2048/moodle-format_topcoll/tree/MOODLE_23 . However, if the toggles do not work, then either it's a problem in my code which I will fix is not Moodle HQ's responsibility or a general bug in core code that I will report. Please kindly allow these changes to proceed without test 1 being a stipulation. Kind regards, Gareth
          Hide
          Mary Evans added a comment - - edited

          Just to put you in the picture Fred, I did not do the work here. I just submitted John's fixes which he had done in January. I don't know why the Readme.txt was deleted.
          I think it was that John was doing a tidy-up.

          https://github.com/epsd/moodle/compare/master...MDL-33934-3

          The Collapsed topic code needs removing. End of story.
          If necessary I'll do that in MDL-37749.

          I'll leave this for another day. I donlt have time now to carry on with it.

          However if this were to get Integrated then I can fix the those images if you create a tracker for them.

          Thanks
          Mary

          Show
          Mary Evans added a comment - - edited Just to put you in the picture Fred, I did not do the work here. I just submitted John's fixes which he had done in January. I don't know why the Readme.txt was deleted. I think it was that John was doing a tidy-up. https://github.com/epsd/moodle/compare/master...MDL-33934-3 The Collapsed topic code needs removing. End of story. If necessary I'll do that in MDL-37749 . I'll leave this for another day. I donlt have time now to carry on with it. However if this were to get Integrated then I can fix the those images if you create a tracker for them. Thanks Mary
          Hide
          Frédéric Massart added a comment -

          Gareth, Mary,

          failing a test is not an accusation, nor does it mean that the patch will be reverted, all it means is that the testing instructions failed and that I wanted to raise some points before deciding if the test should pass or not.

          You will understand that reading the summary and description of this issue, there is no information allowing me to understand that the Collapsible Topics format code was removed from MyMobile theme. Also, the testing instructions state that the theme should be tested using this format, which made me think that it should work. That said, I agree that a 3rd party plugin should not be responsible for failing a test. So I'm all for ignoring the first point.

          About the other points, I think they are valid and integrating a patch which reverts previous bug fixes does not make sense to me. Mary, I understand this is not your work, but as you are saying that you do not have time for it now, I'd suggest reverting the patch, perhaps refining the purpose of this issue, and reopening the associated closed issue if need be.

          Anyway, the Great Integrators will decide what to do, I'm only a messenger here.

          Cheers,
          Fred

          Show
          Frédéric Massart added a comment - Gareth, Mary, failing a test is not an accusation, nor does it mean that the patch will be reverted, all it means is that the testing instructions failed and that I wanted to raise some points before deciding if the test should pass or not. You will understand that reading the summary and description of this issue, there is no information allowing me to understand that the Collapsible Topics format code was removed from MyMobile theme. Also, the testing instructions state that the theme should be tested using this format, which made me think that it should work. That said, I agree that a 3rd party plugin should not be responsible for failing a test. So I'm all for ignoring the first point. About the other points, I think they are valid and integrating a patch which reverts previous bug fixes does not make sense to me. Mary, I understand this is not your work, but as you are saying that you do not have time for it now, I'd suggest reverting the patch, perhaps refining the purpose of this issue, and reopening the associated closed issue if need be. Anyway, the Great Integrators will decide what to do, I'm only a messenger here. Cheers, Fred
          Hide
          Mary Evans added a comment - - edited

          I think now I know why John has not worked on this theme for a long time, other than not being able to afford the time due to RL commitments.

          I had not realised Fred, how many commits you have added to this theme, including the hack MDL-36860 where you added the README.txt.

          The reply button seems to have also been lost in one of Johns previous updates. This is most likely that he did not know it had been added.

          And now with me trying to be a 'Good Samaritan' has really only messed it all up. And as I see it, it's fast becoming a case of 'Too many cooks spoil the broth'.

          I'll fix this now that I know the history.

          It does not help either with the time difference. Being in the UK having to wait for clarity, while the clock ticks, and now another week wasted.

          Show
          Mary Evans added a comment - - edited I think now I know why John has not worked on this theme for a long time, other than not being able to afford the time due to RL commitments. I had not realised Fred, how many commits you have added to this theme, including the hack MDL-36860 where you added the README.txt. The reply button seems to have also been lost in one of Johns previous updates. This is most likely that he did not know it had been added. And now with me trying to be a 'Good Samaritan' has really only messed it all up. And as I see it, it's fast becoming a case of 'Too many cooks spoil the broth'. I'll fix this now that I know the history. It does not help either with the time difference. Being in the UK having to wait for clarity, while the clock ticks, and now another week wasted.
          Hide
          Damyon Wiese added a comment -

          Reopening this issue for more work.

          Thanks Mary, Gareth and Fred for all working on this.

          Please re-submit for integration when the points Fred raised have been addressed.

          Show
          Damyon Wiese added a comment - Reopening this issue for more work. Thanks Mary, Gareth and Fred for all working on this. Please re-submit for integration when the points Fred raised have been addressed.
          Hide
          CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          Mary Evans added a comment -

          I am no longer able to work on MyMobile theme so I have set this issue to unassigned so that other developers can assign it to themselves if they want to take on the task of fixing it.

          Show
          Mary Evans added a comment - I am no longer able to work on MyMobile theme so I have set this issue to unassigned so that other developers can assign it to themselves if they want to take on the task of fixing it.
          Hide
          Mary Evans added a comment -

          Is it worth trying to fix this theme if it is being depreciated in Moodle 2.6?
          There was a time that I was keen to fix as many of the issues here if I could and with Gareth J Barnard's help we very nearly succeeded, but we were put off by the news of its reported demise in 2.6.

          Show
          Mary Evans added a comment - Is it worth trying to fix this theme if it is being depreciated in Moodle 2.6? There was a time that I was keen to fix as many of the issues here if I could and with Gareth J Barnard 's help we very nearly succeeded, but we were put off by the news of its reported demise in 2.6.
          Hide
          Gareth J Barnard added a comment -

          To install JSHint you need the Node.js command prompt, see: mdl-33934-njscp.png.

          I agree with Mary Evans in that this is more pointless than inventing a device to rewind DVD's. Any issues with the theme are now in the realms of Contrib if it is placed there or with other themes by third parties based upon it. Frankly, Bootstrap is much better until jQueryMobile improves.

          Gareth

          Show
          Gareth J Barnard added a comment - To install JSHint you need the Node.js command prompt, see: mdl-33934-njscp.png. I agree with Mary Evans in that this is more pointless than inventing a device to rewind DVD's. Any issues with the theme are now in the realms of Contrib if it is placed there or with other themes by third parties based upon it. Frankly, Bootstrap is much better until jQueryMobile improves. Gareth
          Hide
          Mary Evans added a comment -

          Hi Gareth...thanks for the help with the Node.js command prompt, it's what I use for compiling LESS files.

          Also I recall you already put me wise about where to find the command prompt in this comment HERE

          and my comment HERE comfirms I got it to work, thanks to you!

          Show
          Mary Evans added a comment - Hi Gareth...thanks for the help with the Node.js command prompt, it's what I use for compiling LESS files. Also I recall you already put me wise about where to find the command prompt in this comment HERE and my comment HERE comfirms I got it to work, thanks to you!
          Hide
          Gareth J Barnard added a comment -

          Dear Mary Evans,

          No problem .

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mary Evans , No problem . Cheers, Gareth
          Hide
          Gareth J Barnard added a comment -

          Is there any reason for this and the sub-tasks it lists to be open anymore? As I doubt there is any intent to progress them beyond closure.

          Show
          Gareth J Barnard added a comment - Is there any reason for this and the sub-tasks it lists to be open anymore? As I doubt there is any intent to progress them beyond closure.

            People

            • Votes:
              5 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated: