Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33943

Hardcoded strings in moodle/admin/tool/replace/

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.3, 2.3
    • Fix Version/s: 2.3.2
    • Component/s: Administration
    • Labels:
      None

      Description

      I wanted to translate the "search and replace" tool but I found only hardcoded strings in moodle/admin/tool/replace/index.php

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              fred Frédéric Massart added a comment -

              Thanks Raj. Submitting for integration!

              Show
              fred Frédéric Massart added a comment - Thanks Raj. Submitting for integration!
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks Raj.

              I have integrated this only to 23 because 'This script is not supported'

              Show
              poltawski Dan Poltawski added a comment - Thanks Raj. I have integrated this only to 23 because 'This script is not supported'
              Hide
              phalacee Jason Fowler added a comment -

              All good Raj

              Show
              phalacee Jason Fowler added a comment - All good Raj
              Hide
              poltawski Dan Poltawski added a comment -

              Congratulations!

              You've made it into the weekly release!

              Thanks for your contribution - here are some random drummers to keep you inspired for the next week!
              http://www.youtube.com/watch?v=_QhpHUmVCmY

              Show
              poltawski Dan Poltawski added a comment - Congratulations! You've made it into the weekly release! Thanks for your contribution - here are some random drummers to keep you inspired for the next week! http://www.youtube.com/watch?v=_QhpHUmVCmY
              Hide
              krause Ralf Krause added a comment -

              In Moodle 2.3.1 I get three english strings which are still hardcoded.

              There is the button "Yes, do it now" from index.php line 64

              echo '<div class="buttons"><input type="submit" class="singlebutton" value="Yes, do it now" /></div>';

              There is no string for "Replacing in html blocks..." and "...finished" at the bottom of the page.
              These words come from another file ... I think they come from the function call db_replace($search, $replace);

              Show
              krause Ralf Krause added a comment - In Moodle 2.3.1 I get three english strings which are still hardcoded. There is the button "Yes, do it now" from index.php line 64 echo '<div class="buttons"><input type="submit" class="singlebutton" value="Yes, do it now" /></div>'; There is no string for "Replacing in html blocks..." and "...finished" at the bottom of the page. These words come from another file ... I think they come from the function call db_replace($search, $replace);
              Hide
              rajeshtaneja Rajesh Taneja added a comment - - edited

              Thanks Ralf,

              I have created MDL-34330 to look at this.

              Show
              rajeshtaneja Rajesh Taneja added a comment - - edited Thanks Ralf, I have created MDL-34330 to look at this.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    10/Sep/12