Moodle
  1. Moodle
  2. MDL-33947

Add functionality to change the title/name of a topic/section using AJAX

    Details

    • Type: Improvement Improvement
    • Status: Reopened
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: Future Dev
    • Fix Version/s: None
    • Component/s: AJAX and JavaScript, Course
    • Labels:
    • Testing Instructions:
      Hide

      With a course in editing mode

      • Ensure that the icon placeholder is added. It should appear to the right of each section title
      • Click on the icon - a popup prompt should appear asking for the new title
      • Try a new title
        • Confirm that the title updates on the page
      • Refresh the page
        • Confirm that the title appears on the freshly loaded page
      • Try the update again - this time set an empty string
        • Confirm that the string does not change
      • Refresh the page
        • Confirm that the string still hasn't changed
      • Try the update again - this time set a string of ' ' (space)
        • Confirm that the string does not change
      • Refresh the page
        • Confirm that the string still hasn't changed
      • Try the update again - this time click cancel instead
        • Confirm that the string does not change
      • Refresh the page
        • Confirm that the string still hasn't changed
      • Enable the multilang filter and set it to apply to Content and Headings
      • Try a new title: <span lang="DE" class="multilang">Deutsche</span><span lang="EN" class="multilang">English (UK)</span><span lang="AU" lang="multilang">Australian English</span>
        • Confirm that the title on the page appears as English (UK) (or whatever language you're using)
      • Refresh the page
        • Confirm that the title appears on the freshly loaded page
      • Try a new title: "<!-- This is a comment -->"
        • Confirm that the string does not change
      • Refresh the page
        • Confirm that the string still hasn't changed
      • Try a new title: "<!-- This is a comment --> This is not a comment"
        • Confirm that the title on the page appears as "This is not a comment"
      • Refresh the page
        • Confirm that the title appears on the freshly loaded page
      Show
      With a course in editing mode Ensure that the icon placeholder is added. It should appear to the right of each section title Click on the icon - a popup prompt should appear asking for the new title Try a new title Confirm that the title updates on the page Refresh the page Confirm that the title appears on the freshly loaded page Try the update again - this time set an empty string Confirm that the string does not change Refresh the page Confirm that the string still hasn't changed Try the update again - this time set a string of ' ' (space) Confirm that the string does not change Refresh the page Confirm that the string still hasn't changed Try the update again - this time click cancel instead Confirm that the string does not change Refresh the page Confirm that the string still hasn't changed Enable the multilang filter and set it to apply to Content and Headings Try a new title: <span lang="DE" class="multilang">Deutsche</span><span lang="EN" class="multilang">English (UK)</span><span lang="AU" lang="multilang">Australian English</span> Confirm that the title on the page appears as English (UK) (or whatever language you're using) Refresh the page Confirm that the title appears on the freshly loaded page Try a new title: "<!-- This is a comment -->" Confirm that the string does not change Refresh the page Confirm that the string still hasn't changed Try a new title: "<!-- This is a comment --> This is not a comment" Confirm that the title on the page appears as "This is not a comment" Refresh the page Confirm that the title appears on the freshly loaded page
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33947-master-1
    • Rank:
      42054

      Description

      Same as MDL-31215 but for topic/section names (as it works so well for resources)

        Activity

        Hide
        Andrew Nicols added a comment -

        I'd love to get this in place and it should be relatively trivial.

        Show
        Andrew Nicols added a comment - I'd love to get this in place and it should be relatively trivial.
        Hide
        Dan Poltawski added a comment -

        We are concentrating on fixing regressions in the course ajax things before we review new features. E.g. MDL-34328

        Speaking in general terms, we need to think carefully about 'bolting on' another widget like this here. Think wider about how we can make it into a general framework which looks and works consistently across Moodle and can be maintained easily. Else there will be a lot of code added for each 'click to edit' feature. We add titles now - how about html blocks, activity descriptions, forum posts, html pages etc?

        Show
        Dan Poltawski added a comment - We are concentrating on fixing regressions in the course ajax things before we review new features. E.g. MDL-34328 Speaking in general terms, we need to think carefully about 'bolting on' another widget like this here. Think wider about how we can make it into a general framework which looks and works consistently across Moodle and can be maintained easily. Else there will be a lot of code added for each 'click to edit' feature. We add titles now - how about html blocks, activity descriptions, forum posts, html pages etc?
        Hide
        Dan Poltawski added a comment -

        Sending all 'waiting for peer review' issues to integration before freeze, as agreed in Integrators Meeting 19/10/12. We are doing this to ensure any 'integratable issues' will not got missed before freeze..

        Show
        Dan Poltawski added a comment - Sending all 'waiting for peer review' issues to integration before freeze, as agreed in Integrators Meeting 19/10/12. We are doing this to ensure any 'integratable issues' will not got missed before freeze..
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sam Hemelryk added a comment -

        I'll pick this up for review Andrew, just noting I will check with Dan as to what is going on in regards to the course changes he was thinking of.
        If they're not ready but this is then I'd be tempted to sneak this is regardless.

        Many thanks
        Sam

        Show
        Sam Hemelryk added a comment - I'll pick this up for review Andrew, just noting I will check with Dan as to what is going on in regards to the course changes he was thinking of. If they're not ready but this is then I'd be tempted to sneak this is regardless. Many thanks Sam
        Hide
        Sam Hemelryk added a comment -

        Hmmm looks like recent changes have broken this functionality sorry Andrew.
        If you have time would you mind having a look at it, you may need to rebase it on integration.master in order to see the effects (I'm unsure about this).
        I'll still talk to Dan about his thoughts on this.

        Show
        Sam Hemelryk added a comment - Hmmm looks like recent changes have broken this functionality sorry Andrew. If you have time would you mind having a look at it, you may need to rebase it on integration.master in order to see the effects (I'm unsure about this). I'll still talk to Dan about his thoughts on this.
        Hide
        Sam Hemelryk added a comment -

        Reopening sorry Andrew, looks like this is going to need to be discussed and rebased.

        Show
        Sam Hemelryk added a comment - Reopening sorry Andrew, looks like this is going to need to be discussed and rebased.
        Hide
        CiBoT added a comment -

        Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

        Show
        CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          People

          • Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: