Moodle
  1. Moodle
  2. MDL-33957

Revise and backport the solution for MDL-33928: MySQLi host field size during installation

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.6, 2.2.3, 2.3
    • Fix Version/s: 2.1.7, 2.2.4, 2.3.1
    • Component/s: Installation
    • Labels:
      None
    • Rank:
      42066

      Description

      This issue is to look at backporting the solution to MDL-33928 to all stable branches in order to fix install layout problems.
      Alternatively we could look for a better layout solution so that we can increase the field size which was increased by MDL-26355 originally.

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Assigning to you Jason

          Show
          Sam Hemelryk added a comment - Assigning to you Jason
          Hide
          Jason Fowler added a comment -

          I honestly think these fields should have the size="x" removed, and have the width controlled by CSS

          Show
          Jason Fowler added a comment - I honestly think these fields should have the size="x" removed, and have the width controlled by CSS
          Hide
          Sam Hemelryk added a comment -

          Hehe I don't even know if we serve CSS during installation. Certainly if we do that would be great.

          Show
          Sam Hemelryk added a comment - Hehe I don't even know if we serve CSS during installation. Certainly if we do that would be great.
          Hide
          Jason Fowler added a comment -

          I'll be coming up with a new solution, then Forward-porting the whole thing from this issue

          Show
          Jason Fowler added a comment - I'll be coming up with a new solution, then Forward-porting the whole thing from this issue
          Hide
          Jason Fowler added a comment -

          Okay, so my solution was to make all the fields the same width (bigger) and reduce the size of the label, allowing them to occupy a single line still

          Show
          Jason Fowler added a comment - Okay, so my solution was to make all the fields the same width (bigger) and reduce the size of the label, allowing them to occupy a single line still
          Hide
          Frédéric Massart added a comment -

          Jason, as discussed with you, this change does not revert the MDL-33928, so now we have a small host field and big other ones.

          Beside that, I would not reduce the label too much. It looks good in English, but if you switch to another language it might not look as good. French for example has pretty much all of the labels over two lines.

          And as we are using CSS sizes for the label, wouldn't make your life easier to theme the inputs using CSS as well? I personally never know how big/small my fields will be using the size attribute.

          Show
          Frédéric Massart added a comment - Jason, as discussed with you, this change does not revert the MDL-33928 , so now we have a small host field and big other ones. Beside that, I would not reduce the label too much. It looks good in English, but if you switch to another language it might not look as good. French for example has pretty much all of the labels over two lines. And as we are using CSS sizes for the label, wouldn't make your life easier to theme the inputs using CSS as well? I personally never know how big/small my fields will be using the size attribute.
          Hide
          Aparup Banerjee added a comment -

          Jason, re MDL-33928's patch i think integrators will simply resolve the conflict and go with the solution here. however i think Sam is aware of this and i'm also putting the integration of this one down to Sam.

          Show
          Aparup Banerjee added a comment - Jason, re MDL-33928 's patch i think integrators will simply resolve the conflict and go with the solution here. however i think Sam is aware of this and i'm also putting the integration of this one down to Sam.
          Hide
          Jason Fowler added a comment -

          Due to the fact the integrators integrated the MDL-33928 patch and ignored my request to skip that one in favour of this one, I have fixed this patch to undo the change in the MDL-33928 and apply the correct patch for the master branch.

          Show
          Jason Fowler added a comment - Due to the fact the integrators integrated the MDL-33928 patch and ignored my request to skip that one in favour of this one, I have fixed this patch to undo the change in the MDL-33928 and apply the correct patch for the master branch.
          Hide
          Jason Fowler added a comment -

          popping this into the current sprint to help me keep track of it

          Show
          Jason Fowler added a comment - popping this into the current sprint to help me keep track of it
          Hide
          Sam Hemelryk added a comment -

          Thanks Jason, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Jason, this has been integrated now
          Hide
          Rossiani Wijaya added a comment -

          This looks fine.

          Test passed

          Show
          Rossiani Wijaya added a comment - This looks fine. Test passed
          Hide
          Sam Hemelryk added a comment -

          Congratulations your code is upstream - gold star for you!

          This issue + 79 others made it in in time for the minor releases.
          Thank you everyone involved for your exuberant efforts.

          Show
          Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: