Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.1.6, 2.2.3, 2.3.10, 2.4.7, 2.5.3, 2.6, 2.7
-
Component/s: Quiz
-
Testing Instructions:
-
Affected Branches:MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
-
Fixed Branches:MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
-
Pull from Repository:
-
Pull 2.6 Branch:moodle26-mdl33971
-
Pull 2.6 Diff URL:
-
Pull Master Branch:master-mdl33971
-
Pull Master Diff URL:
Description
When viewing course logs, various quiz actions will appear with "Quiz: [quiz name]" in the Information column. If, however, the action is 'quiz view summary', a number will appear instead and this is causing some confusion amongst our users. The issue seems to be that 'view summary' was never added to the definition of log events in /mod/quiz/db/log.php.
Could you please update the quiz module so that 'quiz view summary' events
will appear correctly when viewing logs.
Credits to Ed Bassett
Gliffy Diagrams
Activity
Also, the first line of the commit comment is way too long. It should not line-wrap in the github display of the commit.
Added other Pull branches. Sorry about the length of my commit comment.
I was rather hoping that you would git commit --amend to change the commit comment, but the code change is good, so submitting for integration anyway.
Please try to do shorter commit comments in future. Making output like "git log --oneline" and http://git.moodle.org/gw?p=moodle.git;a=shortlog;h=refs/heads/master;opt=--no-merges useful is important.
FWIW, my effort at composing a commit comment for this would be:
MDL-33971 quiz: view summary log action was missing
Hi Tim & Tim,
I consulted with Ankit (who knows more about this area than I) and I believe this change requires a quiz version bump to take effect. So could I request the version number change too.
thanks,
dan
Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
Hi Dan,
Sorry for not noting that a version bump was required for this issue. Or is there a process we should follow to committing the version bumps in the future?
Regards,
Tim
Ping, Dan, are you going to answer Tim's last question? Would be good to get this integrated.
In order to ensure that we don't forget to do the version bump, the easiest thing is for you to commit the version increment. Often there can be conflicts with version number changes but it is fine to leave that for the integrators to sort out (it often indicates other thing that need sorting out too, where as if no version number is committed, then we may miss it and not sort it out).
Note: testing instructions are missing. I'll be adding them after review. In the mean time... feel free to do so.
Integrated (24, 25, 26 and master), thanks!
And testing passed. I ended trying it in all branches while writing the testing instructions, all ok.
Thanks for your contributions, this change is now upstream!
“ If debugging is the process of removing software bugs, then programming must be the process of putting them in. ” - Edsger Dijkstra
Thanks for the patch. It looks good to me. Is there some reason why you have not yet done a commit on the master branch? We need that before this can be submitted for integration.