Moodle
  1. Moodle
  2. MDL-33971

When viewing course log entries for Quiz View Summary a number is displayed not the quiz name

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.6, 2.2.3, 2.3.10, 2.4.7, 2.5.3, 2.6, 2.7
    • Fix Version/s: 2.4.8, 2.5.4, 2.6.1
    • Component/s: Quiz
    • Testing Instructions:
      Hide

      1) Create a quiz with at least 1 question.
      2) Perform some attempts showing the final summary table (that will lead to 'view summary' logs inserted.
      3) Go to the logs report
      4) TEST: Verify the 'view summary' entries display the quiz name in the "information" column (they used to be the quiz->id before the patch)

      Show
      1) Create a quiz with at least 1 question. 2) Perform some attempts showing the final summary table (that will lead to 'view summary' logs inserted. 3) Go to the logs report 4) TEST: Verify the 'view summary' entries display the quiz name in the "information" column (they used to be the quiz->id before the patch)
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull 2.6 Branch:
      moodle26-mdl33971
    • Pull Master Branch:
      master-mdl33971

      Description

      When viewing course logs, various quiz actions will appear with "Quiz: [quiz name]" in the Information column. If, however, the action is 'quiz view summary', a number will appear instead and this is causing some confusion amongst our users. The issue seems to be that 'view summary' was never added to the definition of log events in /mod/quiz/db/log.php.

      Could you please update the quiz module so that 'quiz view summary' events
      will appear correctly when viewing logs.

      Credits to Ed Bassett

        Gliffy Diagrams

          Activity

          Hide
          Tim Hunt added a comment -

          Thanks for the patch. It looks good to me. Is there some reason why you have not yet done a commit on the master branch? We need that before this can be submitted for integration.

          Show
          Tim Hunt added a comment - Thanks for the patch. It looks good to me. Is there some reason why you have not yet done a commit on the master branch? We need that before this can be submitted for integration.
          Hide
          Tim Hunt added a comment -

          Also, the first line of the commit comment is way too long. It should not line-wrap in the github display of the commit.

          Show
          Tim Hunt added a comment - Also, the first line of the commit comment is way too long. It should not line-wrap in the github display of the commit.
          Hide
          Tim Lock added a comment -

          Added other Pull branches. Sorry about the length of my commit comment.

          Show
          Tim Lock added a comment - Added other Pull branches. Sorry about the length of my commit comment.
          Hide
          Tim Hunt added a comment -

          I was rather hoping that you would git commit --amend to change the commit comment, but the code change is good, so submitting for integration anyway.

          Please try to do shorter commit comments in future. Making output like "git log --oneline" and http://git.moodle.org/gw?p=moodle.git;a=shortlog;h=refs/heads/master;opt=--no-merges useful is important.

          Show
          Tim Hunt added a comment - I was rather hoping that you would git commit --amend to change the commit comment, but the code change is good, so submitting for integration anyway. Please try to do shorter commit comments in future. Making output like "git log --oneline" and http://git.moodle.org/gw?p=moodle.git;a=shortlog;h=refs/heads/master;opt=--no-merges useful is important.
          Hide
          Tim Hunt added a comment -

          FWIW, my effort at composing a commit comment for this would be:

          MDL-33971 quiz: view summary log action was missing

          Show
          Tim Hunt added a comment - FWIW, my effort at composing a commit comment for this would be: MDL-33971 quiz: view summary log action was missing
          Hide
          Dan Poltawski added a comment -

          Hi Tim & Tim,

          I consulted with Ankit (who knows more about this area than I) and I believe this change requires a quiz version bump to take effect. So could I request the version number change too.

          thanks,
          dan

          Show
          Dan Poltawski added a comment - Hi Tim & Tim, I consulted with Ankit (who knows more about this area than I) and I believe this change requires a quiz version bump to take effect. So could I request the version number change too. thanks, dan
          Hide
          CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          Tim Lock added a comment -

          Hi Dan,

          Sorry for not noting that a version bump was required for this issue. Or is there a process we should follow to committing the version bumps in the future?

          Regards,
          Tim

          Show
          Tim Lock added a comment - Hi Dan, Sorry for not noting that a version bump was required for this issue. Or is there a process we should follow to committing the version bumps in the future? Regards, Tim
          Hide
          Tim Hunt added a comment -

          Ping, Dan, are you going to answer Tim's last question? Would be good to get this integrated.

          Show
          Tim Hunt added a comment - Ping, Dan, are you going to answer Tim's last question? Would be good to get this integrated.
          Hide
          Dan Poltawski added a comment -

          In order to ensure that we don't forget to do the version bump, the easiest thing is for you to commit the version increment. Often there can be conflicts with version number changes but it is fine to leave that for the integrators to sort out (it often indicates other thing that need sorting out too, where as if no version number is committed, then we may miss it and not sort it out).

          Show
          Dan Poltawski added a comment - In order to ensure that we don't forget to do the version bump, the easiest thing is for you to commit the version increment. Often there can be conflicts with version number changes but it is fine to leave that for the integrators to sort out (it often indicates other thing that need sorting out too, where as if no version number is committed, then we may miss it and not sort it out).
          Hide
          Tim Lock added a comment -

          Implemented quiz version bump and updated diff urls.

          Show
          Tim Lock added a comment - Implemented quiz version bump and updated diff urls.
          Hide
          Tim Hunt added a comment -

          There are two commits on the 2.4 branch. That is wrong.

          Show
          Tim Hunt added a comment - There are two commits on the 2.4 branch. That is wrong.
          Hide
          Tim Hunt added a comment -

          Fixing workflow status.

          Show
          Tim Hunt added a comment - Fixing workflow status.
          Hide
          Tim Lock added a comment -

          Squashed 2.4 branch

          Show
          Tim Lock added a comment - Squashed 2.4 branch
          Hide
          Tim Hunt added a comment -

          Great. Thanks. Submitting for integration.

          Show
          Tim Hunt added a comment - Great. Thanks. Submitting for integration.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Note: testing instructions are missing. I'll be adding them after review. In the mean time... feel free to do so.

          Show
          Eloy Lafuente (stronk7) added a comment - Note: testing instructions are missing. I'll be adding them after review. In the mean time... feel free to do so.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (24, 25, 26 and master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (24, 25, 26 and master), thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And testing passed. I ended trying it in all branches while writing the testing instructions, all ok.

          Show
          Eloy Lafuente (stronk7) added a comment - And testing passed. I ended trying it in all branches while writing the testing instructions, all ok.
          Hide
          Dan Poltawski added a comment -

          Thanks for your contributions, this change is now upstream!

          “ If debugging is the process of removing software bugs, then programming must be the process of putting them in. ” - Edsger Dijkstra

          Show
          Dan Poltawski added a comment - Thanks for your contributions, this change is now upstream! “ If debugging is the process of removing software bugs, then programming must be the process of putting them in. ” - Edsger Dijkstra

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: