Moodle
  1. Moodle
  2. MDL-33978

SCORM creation fails when using activity completion

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.1
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide

      enable activity completion.
      Create a new SCORM package
      set completion tracking to "show activity is complete when conditions are met"
      tick the checkbox: require grade

      Save.

      Show
      enable activity completion. Create a new SCORM package set completion tracking to "show activity is complete when conditions are met" tick the checkbox: require grade Save.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      master_MDL-33978
    • Rank:
      42090

      Description

      Thanks to Matt Clarkson for reporting this.
      If activity completion is set to require a grade and the following settings are made:
      show activity is complete when conditions are met.
      require grade

      we get this error:
      Debug info: Cannot find grade item for 'scorm'
      cm '284' matching number '0'
      Error code: err_system
      Stack trace:
      line 1226 of /lib/completionlib.php: moodle_exception thrown
      line 584 of /lib/completionlib.php: call to completion_info->internal_systemerror()
      line 517 of /lib/completionlib.php: call to completion_info->internal_get_state()
      line 692 of /mod/scorm/lib.php: call to completion_info->update_state()
      line 153 of /mod/scorm/lib.php: call to scorm_grade_item_update()
      line 447 of /course/modedit.php: call to scorm_add_instance()

        Activity

        Hide
        Dan Marsden added a comment -

        pushing this up for integration as it causes fatal error on scorm creation when using activity completion.

        Show
        Dan Marsden added a comment - pushing this up for integration as it causes fatal error on scorm creation when using activity completion.
        Hide
        Dan Poltawski added a comment -

        Thanks Dan, i've integrated this now in 2.3 and master.

        Show
        Dan Poltawski added a comment - Thanks Dan, i've integrated this now in 2.3 and master.
        Hide
        Ankit Agarwal added a comment -

        Works as expected
        Thanks!

        Show
        Ankit Agarwal added a comment - Works as expected Thanks!
        Hide
        Sam Hemelryk added a comment -

        Congratulations your code is upstream - gold star for you!

        This issue + 79 others made it in in time for the minor releases.
        Thank you everyone involved for your exuberant efforts.

        Show
        Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: