Moodle
  1. Moodle
  2. MDL-33980

EQUELLA repository passing through database ID for a course rather than the Course ID Number

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Repositories
    • Labels:
      None
    • Rank:
      42092

      Description

      The EQUELLA module and original repository implementation would pass through the Course ID Number as part of the integration for copyright activations in EQUELLA. During the rewrite to the new repository implementation, this had been changed from $COURSE->idnumber to $COURSE->id which is incorrect. Not only will the database IDs change, but they will not match existing course ID numbers in EQUELLA which will cause errors.

        Activity

        Hide
        Nick Read added a comment -

        Added pull request

        Show
        Nick Read added a comment - Added pull request
        Hide
        Martin Dougiamas added a comment -

        I was wondering about that. OK.

        Show
        Martin Dougiamas added a comment - I was wondering about that. OK.
        Hide
        Martin Dougiamas added a comment -

        Dan, this is uncontroversial. Please integrate to 2.3

        Show
        Martin Dougiamas added a comment - Dan, this is uncontroversial. Please integrate to 2.3
        Hide
        Dan Poltawski added a comment -

        Integrated, thanks

        Show
        Dan Poltawski added a comment - Integrated, thanks
        Hide
        Dan Poltawski added a comment -

        Going to check for regressions.

        Show
        Dan Poltawski added a comment - Going to check for regressions.
        Hide
        Dan Poltawski added a comment -

        Still works, hurrah.

        Show
        Dan Poltawski added a comment - Still works, hurrah.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Yay. just in time for Moodle 2.3 release! Many thanks!

        Closing as fixed, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Yay. just in time for Moodle 2.3 release! Many thanks! Closing as fixed, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: