Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33984

2.3 upgrade failing with double unsigned fields in DB

    XMLWordPrintable

Details

    • MOODLE_23_STABLE
    • MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Hide

      1) TEST: In all the target branches, verify that admin->server->environment shows MySQL 5.1.33 as requirement for Moodle 2.3. Previous Moodle versions show 5.0.25 as req.

      2) TEST: Try to install Moodle 2.3 into older MySQL version. Should not be possible.

      3) TEST: Try to upgrade to Moodle 2.3 into older MySQL version. Should not be possible.

      Show
      1) TEST: In all the target branches, verify that admin->server->environment shows MySQL 5.1.33 as requirement for Moodle 2.3. Previous Moodle versions show 5.0.25 as req. 2) TEST: Try to install Moodle 2.3 into older MySQL version. Should not be possible. 3) TEST: Try to upgrade to Moodle 2.3 into older MySQL version. Should not be possible.

    Description

      From the forums (http://moodle.org/mod/forum/discuss.php?d=205378), it looks like if there is a 'double unsigned' field in the DB then it causes the whole upgrade to fail.

      I suppose this is because we don't support unsigned double in the db? In any case maybe it shouldn't cause the whole upgrade to fail:

      error/invalidmysqlnativetype

      More information about this error

      Debug info:
      Error code: invalidmysqlnativetype
      $a contents: double unsigned
      Stack trace:
      line 641 of /lib/dml/mysqli_native_moodle_database.php: dml_exception thrown
      line 534 of /lib/dml/mysqli_native_moodle_database.php: call to mysqli_native_moodle_database->mysqltype2moodletype()
      line 460 of /lib/dml/mysqli_native_moodle_database.php: call to mysqli_native_moodle_database->get_column_info()
      line 522 of /lib/dml/moodle_database.php: call to mysqli_native_moodle_database->get_columns()
      line 1551 of /lib/dml/moodle_database.php: call to moodle_database->where_clause()
      line 60 of /lib/db/upgradelib.php: call to moodle_database->count_records()
      line 232 of /lib/db/upgrade.php: call to upgrade_mysql_fix_unsigned_columns()
      line 1481 of /lib/upgradelib.php: call to xmldb_main_upgrade()
      line 275 of /admin/index.php: call to upgrade_core()

      Attachments

        Activity

          People

            stronk7 Eloy Lafuente (stronk7)
            poltawski Dan Poltawski
            Dan Poltawski Dan Poltawski
            Dan Poltawski Dan Poltawski
            David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              9/Jul/12