[MDL-33984] 2.3 upgrade failing with double unsigned fields in DB - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.3
Fix Version/s: 2.0.10, 2.1.7, 2.2.4
Component/s: Database SQL/XMLDB
Labels:
None

Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/stronk7/moodle.git
Pull Master Branch:
~~MDL-33984~~
Pull Master Diff URL:
https://github.com/stronk7/moodle/compare/master...MDL-33984
Documentation link:
http://docs.moodle.org/dev/Moodle_2.3_release_notes
Testing Instructions:

Hide

1) TEST: In all the target branches, verify that admin->server->environment shows MySQL 5.1.33 as requirement for Moodle 2.3. Previous Moodle versions show 5.0.25 as req.

2) TEST: Try to install Moodle 2.3 into older MySQL version. Should not be possible.

3) TEST: Try to upgrade to Moodle 2.3 into older MySQL version. Should not be possible.

Show
1) TEST: In all the target branches, verify that admin->server->environment shows MySQL 5.1.33 as requirement for Moodle 2.3. Previous Moodle versions show 5.0.25 as req. 2) TEST: Try to install Moodle 2.3 into older MySQL version. Should not be possible. 3) TEST: Try to upgrade to Moodle 2.3 into older MySQL version. Should not be possible.

Description

From the forums (http://moodle.org/mod/forum/discuss.php?d=205378), it looks like if there is a 'double unsigned' field in the DB then it causes the whole upgrade to fail.

I suppose this is because we don't support unsigned double in the db? In any case maybe it shouldn't cause the whole upgrade to fail:

error/invalidmysqlnativetype

More information about this error

Debug info:
Error code: invalidmysqlnativetype
$a contents: double unsigned
Stack trace:
line 641 of /lib/dml/mysqli_native_moodle_database.php: dml_exception thrown
line 534 of /lib/dml/mysqli_native_moodle_database.php: call to mysqli_native_moodle_database->mysqltype2moodletype()
line 460 of /lib/dml/mysqli_native_moodle_database.php: call to mysqli_native_moodle_database->get_column_info()
line 522 of /lib/dml/moodle_database.php: call to mysqli_native_moodle_database->get_columns()
line 1551 of /lib/dml/moodle_database.php: call to moodle_database->where_clause()
line 60 of /lib/db/upgradelib.php: call to moodle_database->count_records()
line 232 of /lib/db/upgrade.php: call to upgrade_mysql_fix_unsigned_columns()
line 1481 of /lib/upgradelib.php: call to xmldb_main_upgrade()
line 275 of /admin/index.php: call to upgrade_core()

Attachments

Activity

People

Assignee:: Eloy Lafuente (stronk7)

Reporter:: Dan Poltawski

Integrator:: Dan Poltawski

Tester:: Dan Poltawski

Participants:: Charles Fulton, Dan Poltawski, Eloy Lafuente (stronk7), Helen Foster, Martin Dougiamas, Matteo Scaramuccia

Component watchers:: Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 25/Jun/12 8:13 PM

Updated:: 30/Jun/12 1:42 PM

Resolved:: 26/Jun/12 8:50 AM

Fix Release Date:: 9/Jul/12