Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33996

Advanced forum search should display time details in English instead of using time stamps

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2, 2.3
    • Fix Version/s: 2.5
    • Component/s: Forum
    • Testing Instructions:
      Hide
      1. Use the advanced search form and choose a date in "Posts must be newer than this" and/or "Posts must be older than this" field and/or eventually any other conditions.
      2. TEST: If there are some results, you should get a page with the heading "Search results: xx" with the results listed. The search form input field is pre-populated with a string that actually contains all datefrom: forumid: and other parameters (the timestamp is expected here).
      3. TEST: If there are no results, a page with the heading "No posts" is displayed, the advanced search form is displayed again with pre-populated values.
      Show
      Use the advanced search form and choose a date in "Posts must be newer than this" and/or "Posts must be older than this" field and/or eventually any other conditions. TEST: If there are some results, you should get a page with the heading "Search results: xx" with the results listed. The search form input field is pre-populated with a string that actually contains all datefrom: forumid: and other parameters (the timestamp is expected here). TEST: If there are no results, a page with the heading "No posts" is displayed, the advanced search form is displayed again with pre-populated values.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33996-forum-advanced-timestamp

      Description

      If you make a advanced forum search, with time constraints. The query displayed to user is something like:-
      No posts containing 'datefrom:1385827200' were found

      Which clearly wont make any sense to the user.

      The code responsible for this is in mod/forum/search.php

          if (!empty($datefrom)) {
              $search .= ' datefrom:'.$datefrom;
          }
          if (!empty($dateto)) {
              $search .= ' dateto:'.$dateto;
      

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13