Moodle
  1. Moodle
  2. MDL-34008

repeatElements does not replace {no} for submit button values.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.3, 2.3
    • Fix Version/s: 2.2.4, 2.3.1
    • Component/s: Forms Library
    • Labels:
    • Testing Instructions:
      Hide

      1. Drop the attached test.php into the root of your Moodle install.

      2. Go there with your browser. You should see buttons with labels like Submit 1, Button 1. Previously you would have seen Submit

      {no}, Button {no}

      .

      Show
      1. Drop the attached test.php into the root of your Moodle install. 2. Go there with your browser. You should see buttons with labels like Submit 1, Button 1. Previously you would have seen Submit {no}, Button {no} .
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      This works for other input types, but not buttons.

        Gliffy Diagrams

          Activity

          Hide
          Tim Hunt added a comment -

          Note that the buggy code does not even exist in 2.1, so I am not even attempting to fix this there.

          Show
          Tim Hunt added a comment - Note that the buggy code does not even exist in 2.1, so I am not even attempting to fix this there.
          Hide
          Tim Hunt added a comment -

          Re-based and 2.3 branch added.

          Show
          Tim Hunt added a comment - Re-based and 2.3 branch added.
          Hide
          Dan Poltawski added a comment -

          Are repeat elements the most buggy part of formslib!!?

          Show
          Dan Poltawski added a comment - Are repeat elements the most buggy part of formslib!!?
          Hide
          Dan Poltawski added a comment -

          Integrated, thanks Tim

          Show
          Dan Poltawski added a comment - Integrated, thanks Tim
          Hide
          Rajesh Taneja added a comment -

          Button labels are numbered properly.
          Thanks for fixing this, Tim.

          Show
          Rajesh Taneja added a comment - Button labels are numbered properly. Thanks for fixing this, Tim.
          Hide
          Sam Hemelryk added a comment -

          Congratulations your code is upstream - gold star for you!

          This issue + 79 others made it in in time for the minor releases.
          Thank you everyone involved for your exuberant efforts.

          Show
          Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: