Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34025

Call to close_attempt_popup passes parameters in wrong order.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2, 2.3
    • Fix Version/s: 2.2.4, 2.3.1
    • Component/s: Quiz
    • Labels:
      None
    • Testing Instructions:
      Hide

      1. Create a quiz that allows multiple attempts, and set to Browser security: 'Popup ...', and no review allowed immediately after the attempt.
      2. Add a question to the quiz
      3. Create a student account and access the quiz.
      4. Finish an attempt
      5. Ensure a valid message is displayed and the pop-up window then closes after a few seconds.

      Show
      1. Create a quiz that allows multiple attempts, and set to Browser security: 'Popup ...', and no review allowed immediately after the attempt. 2. Add a question to the quiz 3. Create a student account and access the quiz. 4. Finish an attempt 5. Ensure a valid message is displayed and the pop-up window then closes after a few seconds.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34025_master

      Description

      In mod/quiz/accessmanager.php the function back_to_view_page makes a call to close_attempt_popup and passes the message as the first parameter, and the url as the second parameter, when in fact it should be reversed. Function close_attempt_popup is declared in mod/quiz/renderer.php.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              markn Mark Nelson
              Reporter:
              markn Mark Nelson
              Peer reviewer:
              Tim Hunt
              Integrator:
              Dan Poltawski
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jul/12