Moodle

Plugin notifications page does not link to the plugins!

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.3
  • Fix Version/s: 2.3.1
  • Component/s: Administration
  • Labels:
    None
  • Affected Branches:
    MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_23_STABLE

Description

We really need more than just a message, we need links to the plugins page so people can see/get it.

eg http://moodle.org/plugins/pluginversions.php?plugin=repository_poodll

Issue Links

discovered while testing

New Feature - A new Moodle feature which has yet to be developed. MDL-20438 Available update notifications

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Mudrak added a comment -

Adding Eloy here as a watcher as this involves server-side part of the machinery.

The Moodle code itself is prepared for that. The response from the server is expected to provide URL to download as well as the URL to a page with more information about the plugin. See the fake.php example attached to MDL-20438 for the expected structure of the info. The 'download' URL is supposed to contain a link to the ZIP package with the plugin. The 'url' value is supposed to contain a link like the one Martin provided in the description.

I intentionally did not include any URL construction at the client side. All info is supposed to be returned by the server (which gives us more flexibility, should we ever need it).

Eloy, I believe an addition of at least the 'url' item should be pretty trivial. If you find time to implement it into your scripts, please feel free to re-assign this to yourself. Thanks in advance.

Show
David Mudrak added a comment - Adding Eloy here as a watcher as this involves server-side part of the machinery. The Moodle code itself is prepared for that. The response from the server is expected to provide URL to download as well as the URL to a page with more information about the plugin. See the fake.php example attached to MDL-20438 for the expected structure of the info. The 'download' URL is supposed to contain a link to the ZIP package with the plugin. The 'url' value is supposed to contain a link like the one Martin provided in the description. I intentionally did not include any URL construction at the client side. All info is supposed to be returned by the server (which gives us more flexibility, should we ever need it). Eloy, I believe an addition of at least the 'url' item should be pretty trivial. If you find time to implement it into your scripts, please feel free to re-assign this to yourself. Thanks in advance.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Oki, Updates API updated to:

  • return the 'url' for each matching plugin version returned.
  • consider "matching" those being the most recent per maturity (null maturity included). We were returning all before without any maturity grouping.
  • avoid returning any null maturity and release information.
  • avoid returning any information about plugins not having any "match".

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Oki, Updates API updated to: return the 'url' for each matching plugin version returned. consider "matching" those being the most recent per maturity (null maturity included). We were returning all before without any maturity grouping. avoid returning any null maturity and release information. avoid returning any information about plugins not having any "match". Ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Self-integrated, self-thanks!
(and thanks to David for all the details support).

Show
Eloy Lafuente (stronk7) added a comment - Self-integrated, self-thanks! (and thanks to David for all the details support).
Hide
Permalink
David Mudrak added a comment -

Passing. A shiny "More info ..." link appears leading to the details on the available update. Thanks Eloy for another great job. Yay!

Show
David Mudrak added a comment - Passing. A shiny "More info ..." link appears leading to the details on the available update. Thanks Eloy for another great job. Yay!
Hide
Permalink
Martin Dougiamas added a comment -

Woot - so glad that no Moodle changes were required!

Next problem: MDLSITE-1819

Show
Martin Dougiamas added a comment - Woot - so glad that no Moodle changes were required! Next problem: MDLSITE-1819
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Closing this as fixed, changes are now available upstream.

Big thanks!

Show
Eloy Lafuente (stronk7) added a comment - Closing this as fixed, changes are now available upstream. Big thanks!

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: