Moodle
  1. Moodle
  2. MDL-34047

URL downloader repository appears in non-image environment

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.3
        • Fix Version/s: 2.2.4, 2.3.1
        • Component/s: Repositories
        • Labels:
          None
        • Testing Instructions:
          Hide

          1. Enable URL repository
          2. Open any page with texteditor and make sure that URL repository appears in the repositories list when you try to insert image but does not appear when you try to insert media

          Show
          1. Enable URL repository 2. Open any page with texteditor and make sure that URL repository appears in the repositories list when you try to insert image but does not appear when you try to insert media
        • Affected Branches:
          MOODLE_23_STABLE
        • Fixed Branches:
          MOODLE_22_STABLE, MOODLE_23_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          wip-MDL-34047-master
        • Pull Master Diff URL:
        • Rank:
          42348

          Description

          Repository 'URL downloader' does not specify that it returns only images and therefore it appears in filepicker when other file types are expected.

          Raised from discussion MDLSITE-1818, the moodle.org/plugins filemanager expects .zip file and 'URL downloader' is confusing in the repositories list there

            Issue Links

            has been marked as being related by

            Bug - A problem which impairs or prevents Moodle from functioning correctly. MDLSITE-1818 Upload file from url fails on moodle.org plugins

            • Minor - Minor loss of function where workaround is possible
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Marina Glancy added a comment -

              TO INTEGRATORS: please cherry-pick to 23_STABLE

              Show
              Marina Glancy added a comment - TO INTEGRATORS: please cherry-pick to 23_STABLE
              Hide
              Permalink
              Dan Poltawski added a comment -

              As discussed, Marina could you create a branch for 22_STABLE and add testing instructions.

              Show
              Dan Poltawski added a comment - As discussed, Marina could you create a branch for 22_STABLE and add testing instructions.
              Hide
              Permalink
              Marina Glancy added a comment -

              Added branch for 2.2

              Show
              Marina Glancy added a comment - Added branch for 2.2
              Hide
              Permalink
              Dan Poltawski added a comment -

              Thanks Marina, i've integrated that now

              Show
              Dan Poltawski added a comment - Thanks Marina, i've integrated that now
              Hide
              Permalink
              Frédéric Massart added a comment -

              Passed on 2.2, 2.3 and master. Cheers!

              Show
              Frédéric Massart added a comment - Passed on 2.2, 2.3 and master. Cheers!
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Congratulations your code is upstream - gold star for you!

              This issue + 79 others made it in in time for the minor releases.
              Thank you everyone involved for your exuberant efforts.

              Show
              Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: