Moodle
  1. Moodle
  2. MDL-34052

Upgrade helper sets 'file submission' to yes for online text and offline assignment types

    Details

    • Testing Instructions:
      Hide
      1. Go to Site administration -> Plugins -> Assignment plugins -> Submission plugins -> Manage submission plugins
      2. Set all the submission plugins to visible and enabled by default (in the settings for each plugin).
      3. Enable the "Assignment (2.2)" activity
      4. Create an "Advanced uploading of files" assignment in a course
      5. Use the Assignment upgrade tool to upgrade the new assignment
      6. View the settings for the new assignment
      7. Verify that "Online text" is "No", "File submissions" is "Yes" and "Submission comments" is "Yes"
      Show
      Go to Site administration -> Plugins -> Assignment plugins -> Submission plugins -> Manage submission plugins Set all the submission plugins to visible and enabled by default (in the settings for each plugin). Enable the "Assignment (2.2)" activity Create an "Advanced uploading of files" assignment in a course Use the Assignment upgrade tool to upgrade the new assignment View the settings for the new assignment Verify that "Online text" is "No", "File submissions" is "Yes" and "Submission comments" is "Yes"
    • Workaround:
      Hide

      Change the assignment settings to disable unwanted submission types after it has been upgraded.

      A workaround for a mass upgrade would be to disable all the new assignment plugins types by default, do the mass upgrade, then set them back to whatever they were before.

      Show
      Change the assignment settings to disable unwanted submission types after it has been upgraded. A workaround for a mass upgrade would be to disable all the new assignment plugins types by default, do the mass upgrade, then set them back to whatever they were before.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34052-master
    • Rank:
      42354

      Description

      When upgrading assignments from older versions of Moodle, the upgrade helper in Moodle 2.3 sets the setting 'file submissions' setting to "Yes" (plus Max files to 1 and max submission size to course upload limit) for the online text and offline assignment types. Expected behaviour is to upgrade the 'file submission' setting to "No" for both of these assignment types.

      Steps to recreate:

      • create offline or online text assignment (or restore from backup)
      • login as admin and upgrade assignment using upgrade helper
      • view settings of upgraded assignment - scroll to "File submission" setting

        Activity

        Hide
        Lenka Belanova added a comment -

        I don´t understand: why is this bug created more than a month ago considered minor? In the Settings mapping section of the documentation for the Upgrade tool (http://docs.moodle.org/23/en/Upgrade_tool#Settings_Mapping) the expected functionality is clearly stated "For a Single File Upload or Advanced Uploading of Files assignment type this setting will upgrade to Yes. For all other subtypes it will upgrade to No." Yet it does not work. For us it is a blocker that makes it impossible to upgrade all the old assignment subtypes and start using the new assignment site-wide.

        Show
        Lenka Belanova added a comment - I don´t understand: why is this bug created more than a month ago considered minor? In the Settings mapping section of the documentation for the Upgrade tool ( http://docs.moodle.org/23/en/Upgrade_tool#Settings_Mapping ) the expected functionality is clearly stated "For a Single File Upload or Advanced Uploading of Files assignment type this setting will upgrade to Yes. For all other subtypes it will upgrade to No." Yet it does not work. For us it is a blocker that makes it impossible to upgrade all the old assignment subtypes and start using the new assignment site-wide.
        Hide
        Susan Mangan added a comment -

        Agreed. I just now realized this after upgrading thousands of offline assignments... sigh

        Show
        Susan Mangan added a comment - Agreed. I just now realized this after upgrading thousands of offline assignments... sigh
        Hide
        Susan Mangan added a comment -

        I wonder if there is any way to track these and do a mass update ... anyone?

        Show
        Susan Mangan added a comment - I wonder if there is any way to track these and do a mass update ... anyone?
        Hide
        Raymond Antonio added a comment -

        Hi Damyon,
        There is a patch for this bug on my Github link above ready for peer review. Thanks Damyon

        Show
        Raymond Antonio added a comment - Hi Damyon, There is a patch for this bug on my Github link above ready for peer review. Thanks Damyon
        Hide
        Damyon Wiese added a comment -

        I ammended Lukes commit to fix up the format of the git message and added a 2.4 branch.

        Show
        Damyon Wiese added a comment - I ammended Lukes commit to fix up the format of the git message and added a 2.4 branch.
        Hide
        Damyon Wiese added a comment -

        Thanks Grette, Raymond and Luke - this is ready for integration.

        Show
        Damyon Wiese added a comment - Thanks Grette, Raymond and Luke - this is ready for integration.
        Hide
        Damyon Wiese added a comment -

        This patch disables plugins that do not report that they know how to upgrade a particular type of the old assignment. Previously this was getting left at whatever the site defaults were for that type of assignment plugin.

        Show
        Damyon Wiese added a comment - This patch disables plugins that do not report that they know how to upgrade a particular type of the old assignment. Previously this was getting left at whatever the site defaults were for that type of assignment plugin.
        Hide
        Dan Poltawski added a comment -

        Integrated to master, 24 and 23, thanks guys

        Show
        Dan Poltawski added a comment - Integrated to master, 24 and 23, thanks guys
        Hide
        Michael de Raadt added a comment -

        Test result: Success!

        Tested in 2.3 and master.

        Show
        Michael de Raadt added a comment - Test result: Success! Tested in 2.3 and master.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

          People

          • Votes:
            3 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: