Moodle
  1. Moodle
  2. MDL-34063

XHTML files should use the HTML icon, not the markup icon

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.4
    • Fix Version/s: 2.3.1
    • Component/s: Files API
    • Labels:
    • Rank:
      42368

      Description

      XHTML is HTML as an XML application so, even though it is an XML file, it should have the same document-type icon as HTML files.

        Issue Links

          Activity

          Hide
          David Balch added a comment -

          filelib patch to set the XHTML files' icon the same as HTML files.

          Show
          David Balch added a comment - filelib patch to set the XHTML files' icon the same as HTML files.
          Hide
          Michael de Raadt added a comment -

          Thanks for spotting that and providing a solution.

          Show
          Michael de Raadt added a comment - Thanks for spotting that and providing a solution.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks! (23 and master)

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (23 and master)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And tested. I now get the html icon (gray one, without any special distinctive) both with html and xhtml files.

          Show
          Eloy Lafuente (stronk7) added a comment - And tested. I now get the html icon (gray one, without any special distinctive) both with html and xhtml files.
          Hide
          Sam Hemelryk added a comment -

          Congratulations your code is upstream - gold star for you!

          This issue + 79 others made it in in time for the minor releases.
          Thank you everyone involved for your exuberant efforts.

          Show
          Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: