Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.4
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Go to the "Site Administration" => "Plugins" => "Activity modules" => "Manage activities" page
      2. Delete the "Assignment" plugin
      3. Go to the "Site Administration" => "Notifications" page
      4. Re-install the plugin
      5. Verify the default value for "assignfeedback_comments | default" is "Yes"
      Show
      Go to the "Site Administration" => "Plugins" => "Activity modules" => "Manage activities" page Delete the "Assignment" plugin Go to the "Site Administration" => "Notifications" page Re-install the plugin Verify the default value for "assignfeedback_comments | default" is "Yes"
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
    • Rank:
      42372

      Description

      With the old assignment whichever type it was, it was always possible to quick grade with a grade and comment.

      Now with comments put as a sub-type of feedback, this is not the case.

      So if people were allowing a file to be uploaded, having used the old assignment type would they not expect to be able to grade + comment as normal?

      So if the comment aspect has to be maintained as a feedback type (which I don't see the logic in when the comment was part of the grading) the comment feedback should be defaulted to ON in Moodle (right now defaulted to off)

        Activity

        Hide
        Mary Cooch added a comment - - edited

        yes- I will go with the default to ON -it has caught me out a couple of times until I figured out where to change it myself.

        Show
        Mary Cooch added a comment - - edited yes- I will go with the default to ON -it has caught me out a couple of times until I figured out where to change it myself.
        Hide
        Michael de Raadt added a comment -

        Thanks for raising that, Gavin.

        I tend to agree that comments should be on by default. I was planning to raise that myself at one stage, but lost sight of it.

        I suggest we throw this open to the community for some objective opinions.

        Show
        Michael de Raadt added a comment - Thanks for raising that, Gavin. I tend to agree that comments should be on by default. I was planning to raise that myself at one stage, but lost sight of it. I suggest we throw this open to the community for some objective opinions.
        Hide
        gavin henrick added a comment -

        Thanks Michael.

        Must admit I see it as lost functionality right now rather than an improvement, since people need to do something extra just to have what they already had.

        G

        Show
        gavin henrick added a comment - Thanks Michael. Must admit I see it as lost functionality right now rather than an improvement, since people need to do something extra just to have what they already had. G
        Hide
        Damyon Wiese added a comment -

        I considered turning the file feedback plugin on by default as well but the file picker takes up quite a lot of room now so I decided to leave it off.

        Show
        Damyon Wiese added a comment - I considered turning the file feedback plugin on by default as well but the file picker takes up quite a lot of room now so I decided to leave it off.
        Hide
        Rossiani Wijaya added a comment -

        Patch looks good.

        Thanks Damyon.

        Submitting for integration review.

        Show
        Rossiani Wijaya added a comment - Patch looks good. Thanks Damyon. Submitting for integration review.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sam Hemelryk added a comment -

        Thanks guys, this has been integrated to master now.

        Show
        Sam Hemelryk added a comment - Thanks guys, this has been integrated to master now.
        Hide
        Tim Barker added a comment -

        Congrats, your test passed.

        Show
        Tim Barker added a comment - Congrats, your test passed.
        Hide
        Aparup Banerjee added a comment -

        yay, it works!

        This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

        Thank you all for taking the time to get us here.

        cheers!

        Show
        Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: