Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.9.18, 2.2, 2.2.5, 2.3.2, 2.4
-
Component/s: Chat
-
Testing Instructions:
-
Affected Branches:MOODLE_19_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
-
Fixed Branches:MOODLE_22_STABLE, MOODLE_23_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-34068_master -
Pull Master Diff URL:
Description
When you run the chat daemon, which uses a frameset, the main chat area, (where messages appear, i.e., win=chat) does not send out a response header. Proper response headers are sent for the sidekick frames (message, beep, and user). The user sees the underlying html exposed in Firefox. Firefox treats the output in quirks mode and as text/plain not text/html. IE Chrome appear to be more forgiving.
I tracked this down using Fiddler, Firefox' Live Headers add-on and by looking at the Firefox cache (about:cache).
As a partial fix, I added an HTTP response block beginning on line 532 of chatd.php. However, this may cause some of the sidebars to send the header response twice.
|
chatd.php |
$this->dismiss_half($sessionid, false);
|
|
|
// new block begins here
|
|
|
$header = "HTTP/1.1 200 OK\n";
|
$header .= "Date: ".date('r')."\n";
|
$header .= "Server: Moodle\n";
|
$header .= "Content-Type: text/html; charset=utf-8\n";
|
$header .= "Last-Modified: ".gmdate("D, d M Y H:i:s")." GMT\n";
|
$header .= "Cache-Control: no-cache, must-revalidate\n";
|
$header .= "Expires: Wed, 4 Oct 1978 09:32:45 GMT\n";
|
$header .= "\n";
|
$this->write_data($this->conn_sets[$sessionid][CHAT_CONNECTION_CHANNEL], $header);
|
|
|
// new block ends here
|
|
|
$this->write_data($this->conn_sets[$sessionid][CHAT_CONNECTION_CHANNEL], $CHAT_HTMLHEAD_JS);
|
Gliffy Diagrams
Attachments
Issue Links
- is blocked by
-
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
It looks like this is still probably a problem with the current version.
Thanks Paul for reporting the issue and providing a solution.
I've added text/html headers to the new connection output, but I can't see any duplicate response header in any of the other frames, each of them has it's own header and this new addition does not conflict. I avoid investing more efforts in this issue (refactoring code I mean) because, if it has to be done, should be part of a general cleanup of the chat daemon code.
This looks good.
+1 for integration.
Thanks Rossie
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao 
Rebased
Thanks, thats been integrated.
Tested this with random browsers and themes. All working good.
Thanks
Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio
This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).
Thanks!
FYI: this has been discussed in http://moodle.org/mod/forum/discuss.php?d=205471, before filing the issue.