Moodle
  1. Moodle
  2. MDL-34081

Install fails on mssql if using binary collation

        Details

        • Testing Instructions:
          Hide

          You need a mssql server with binary collation, mine was Latin1_General_BIN. You must be using the freedts driver (mssql, not sqlsrv)

          1. Attempt to install
          2. run phpunit tests
          Show
          You need a mssql server with binary collation, mine was Latin1_General_BIN. You must be using the freedts driver (mssql, not sqlsrv) Attempt to install run phpunit tests
        • Affected Branches:
          MOODLE_23_STABLE
        • Fixed Branches:
          MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          mssql-case-sensitive
        • Pull Master Diff URL:
        • Rank:
          42388

          Description

          In MSSQL using the freedts driver with a binary collation, Moodle fails to install due to problems with information_schema.

          This can be resolved by using the proper uppercase naming.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Petr Škoda added a comment -

            +1 these should be already fixed and tested in the sqlsrv driver

            Show
            Petr Škoda added a comment - +1 these should be already fixed and tested in the sqlsrv driver
            Hide
            Permalink
            Dan Poltawski added a comment -

            Yep, the sqlsrv driver is using uppercase.

            Show
            Dan Poltawski added a comment - Yep, the sqlsrv driver is using uppercase.
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            Integrated (21, 22, 23 and master), thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated (21, 22, 23 and master), thanks!
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            Installs OK now and runs phpunit tests OK too. Only the 2 well-known "mssql_data_seek" exceptions are shown. So passing.

            Show
            Eloy Lafuente (stronk7) added a comment - Installs OK now and runs phpunit tests OK too. Only the 2 well-known "mssql_data_seek" exceptions are shown. So passing.
            Hide
            Permalink
            Sam Hemelryk added a comment -

            Congratulations your code is upstream - gold star for you!

            This issue + 79 others made it in in time for the minor releases.
            Thank you everyone involved for your exuberant efforts.

            Show
            Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: