[MDL-34086] META: Increase robustness of upgrade from 1.9 to 2.2 - Moodle Tracker

Details

Type: Task
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 2.2
Fix Version/s: 2.2.11
Component/s: Administration, Database SQL/XMLDB
Labels:
- triaged

Affected Branches:
MOODLE_22_STABLE
Fixed Branches:
MOODLE_22_STABLE

Description

Use this META bug to group and prioritise problems found in the 1.9 -> 2.2 upgrade.

For large sites, please use the command-line interface (CLI).
http://docs.moodle.org/22/en/Administration_via_command_line#Upgrading_via_command_line

All fixes here should be ported to 2.2.x only.

Gliffy Diagrams

Attachments

Issue Links

has been marked as being related by

MDL-36126 Error restoring a Moodle 1.9.x course to Moodle 2.x due to long filenames

Closed

Options

Sub-Tasks

1.	Sites using 1.9.x, but originally installed with < 1.7, fail upgrading to 2.0 due to null fields in mdl_user table	Closed	Mark Nelson
2.	Upgrade 1.9.x -> 2.0 fails: column "city " contains null values	Closed	Aparup Banerjee
3.	improve mysql collation handling	Closed	Petr Skoda
4.	Force language not displayed in course settings after upgrade	Closed	Petr Skoda
5.	Presets lost after upgrade from 1.9.12 to 2.0.4 to 2.1.1	Closed	Mark Nelson
6.	mdl_resource upgrade bug: Data too long for column 'mainfile'	Closed	Mark Nelson
7.	2.1 Upgrade fails in mod_folder section	Closed	Unassigned
8.	Moodle 1.9 to 2.x restore of course with a display directory	Closed	David Mudrák
9.	Upgrade to 2.0.2 fails if certain fields are null in user or resource table	Closed	Mark Nelson
10.	Sites installed with Moodle version < 1.7 using Postgres have null database columns	Closed	Mark Nelson
11.	Error on upgrade to Moodle 2.0	Closed	Mark Nelson

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Dan Poltawski added a comment - 28/Jun/12 9:55 PM

Really I think we should be able to do something like this in xmldb:
http://docs.moodle.org/22/en/Verify_Database_Schema

Show

Dan Poltawski added a comment - 28/Jun/12 9:55 PM Really I think we should be able to do something like this in xmldb: http://docs.moodle.org/22/en/Verify_Database_Schema

Hide

Permalink

Dan Poltawski added a comment - 29/Jun/12 11:06 AM - edited

From http://moodle.org/mod/forum/discuss.php?d=205367 - some work someone had to do:

ALTER TABLE mdl_user MODIFY COLUMN lastip VARCHAR(45) NOT NULL DEFAULT '';

ALTER TABLE mdl_post MODIFY COLUMN uniquehash VARCHAR(255) NOT NULL DEFAULT '';

ALTER TABLE mdl_resource MODIFY COLUMN reference VARCHAR(255) NOT NULL DEFAULT '';

UPDATE mdl_user SET lastip = '0.0.0.0' WHERE lastip IS NULL;

UPDATE mdl_user SET city = 'unknown' WHERE city IS NULL;

ALTER TABLE mdl_modules ALTER COLUMN search SET DEFAULT 'default';

FWIW, I have also had to change all of those fields apart form mdl_post and mdl_modules on a site i've upgraded. This must be fairly widespread.

Show

Dan Poltawski added a comment - 29/Jun/12 11:06 AM - edited From http://moodle.org/mod/forum/discuss.php?d=205367 - some work someone had to do: ALTER TABLE mdl_user MODIFY COLUMN lastip VARCHAR(45) NOT NULL DEFAULT ''; ALTER TABLE mdl_post MODIFY COLUMN uniquehash VARCHAR(255) NOT NULL DEFAULT ''; ALTER TABLE mdl_resource MODIFY COLUMN reference VARCHAR(255) NOT NULL DEFAULT ''; UPDATE mdl_user SET lastip = '0.0.0.0' WHERE lastip IS NULL; UPDATE mdl_user SET city = 'unknown' WHERE city IS NULL; ALTER TABLE mdl_modules ALTER COLUMN search SET DEFAULT 'default'; FWIW, I have also had to change all of those fields apart form mdl_post and mdl_modules on a site i've upgraded. This must be fairly widespread.

Hide

Permalink

Martin Dougiamas added a comment - 10/Jul/12 1:44 PM

How about this one about collations? http://moodle.org/mod/forum/discuss.php?d=206607

ELECT CONCAT('ALTER TABLE `', t.`TABLE_SCHEMA`, '`.`', t.`TABLE_NAME`, '` CONVERT TO CHARACTER SET utf8 COLLATE utf8_unicode_ci;') as stmt

FROM `information_schema`.`TABLES` t

WHERE 1

AND t.`TABLE_SCHEMA` = 'moodledb'

ORDER BY 1 ;

and

ALTER TABLE `mdl_course` CONVERT TO CHARACTER SET utf8 COLLATE utf8_general_ci;

ALTER TABLE `mdl_context` CONVERT TO CHARACTER SET utf8 COLLATE utf8_general_ci;

ALTER TABLE `mdl_role_assignments` CONVERT TO CHARACTER SET utf8 COLLATE utf8_general_ci;

ALTER TABLE `mdl_enrol` CONVERT TO CHARACTER SET utf8 COLLATE utf8_general_ci;

Show

Martin Dougiamas added a comment - 10/Jul/12 1:44 PM How about this one about collations? http://moodle.org/mod/forum/discuss.php?d=206607 ELECT CONCAT('ALTER TABLE `', t.`TABLE_SCHEMA`, '`.`', t.`TABLE_NAME`, '` CONVERT TO CHARACTER SET utf8 COLLATE utf8_unicode_ci;') as stmt FROM `information_schema`.`TABLES` t WHERE 1 AND t.`TABLE_SCHEMA` = 'moodledb' ORDER BY 1 ; and ALTER TABLE `mdl_course` CONVERT TO CHARACTER SET utf8 COLLATE utf8_general_ci; ALTER TABLE `mdl_context` CONVERT TO CHARACTER SET utf8 COLLATE utf8_general_ci; ALTER TABLE `mdl_role_assignments` CONVERT TO CHARACTER SET utf8 COLLATE utf8_general_ci; ALTER TABLE `mdl_enrol` CONVERT TO CHARACTER SET utf8 COLLATE utf8_general_ci;

Hide

Permalink

Dan Poltawski added a comment - 10/Jul/12 2:04 PM

Martin: pretty sure that is nothing to do with us, just mysql environment settings.

Show

Dan Poltawski added a comment - 10/Jul/12 2:04 PM Martin: pretty sure that is nothing to do with us, just mysql environment settings.

Hide

Permalink

Dan Poltawski added a comment - 16/Jul/12 11:03 AM

Please ignore my above comment. Petr has come up with a solution for this in ~~MDL-34271~~.

Show

Dan Poltawski added a comment - 16/Jul/12 11:03 AM Please ignore my above comment. Petr has come up with a solution for this in MDL-34271 .

People

Assignee:

moodle.com

Reporter:

Martin Dougiamas

Participants:

Dan Poltawski, Martin Dougiamas, moodle.com

Votes:

8 Vote for this issue

Watchers:

11 Start watching this issue

Dates

Created:

28/Jun/12 5:36 PM

Updated:

04/Jun/13 4:49 AM

Resolved:

04/Jun/13 4:49 AM

Fix Release Date:

8/Jul/13