Moodle
  1. Moodle
  2. MDL-34107

Dot added to the filename without an extension when using Drop & Drag uploader

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.2
    • Component/s: Filepicker
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in to moodle and navigate to "My private files"
      2. drag-n-drop a file with no extension
      3. make sure it doesn't have a "."(dot) suffixed to filename.

      Test this on STABLE_23 and master

      Show
      Log in to moodle and navigate to "My private files" drag-n-drop a file with no extension make sure it doesn't have a "."(dot) suffixed to filename. Test this on STABLE_23 and master
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-34107_filename_dot
    • Rank:
      42419

      Description

      I have noticed that if you upload a file without an extension with the Drop & Drag uploader the resulting file will be 'test.' and if you upload it via the old Upload method it will be 'test'

        Activity

        Hide
        Davo Smith added a comment -

        Probably a 1-line fix, but I won't have time to look at it until Monday now.

        Show
        Davo Smith added a comment - Probably a 1-line fix, but I won't have time to look at it until Monday now.
        Hide
        Davo Smith added a comment -

        Added an extra check for the presence of a '.' in the filename before doing any extension handling at all (to distinguish between no extension and an empty extension: 'filename' and 'filename.')

        Show
        Davo Smith added a comment - Added an extra check for the presence of a '.' in the filename before doing any extension handling at all (to distinguish between no extension and an empty extension: 'filename' and 'filename.')
        Hide
        Sam Hemelryk added a comment -

        Thanks Davo, this has been integrated now.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Thanks Davo, this has been integrated now. Cheers Sam
        Hide
        Rajesh Taneja added a comment -

        Works fine, no . (dot) was prefixed to filename.

        Thanks for fixing this Davo.

        Show
        Rajesh Taneja added a comment - Works fine, no . (dot) was prefixed to filename. Thanks for fixing this Davo.
        Hide
        Dan Poltawski added a comment -

        Congratulations!

        You've made it into the weekly release!

        Thanks for your contribution - here are some random drummers to keep you inspired for the next week!
        http://www.youtube.com/watch?v=_QhpHUmVCmY

        Show
        Dan Poltawski added a comment - Congratulations! You've made it into the weekly release! Thanks for your contribution - here are some random drummers to keep you inspired for the next week! http://www.youtube.com/watch?v=_QhpHUmVCmY

          People

          • Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: