Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.2, 2.3, 2.4
    • Fix Version/s: 2.2.4, 2.3.1
    • Component/s: Backup
    • Labels:
      None
    • Rank:
      42437

      Description

      from parent issue: The backup_ids and backup_files tables (used by 1.9 backup) are present in an installed 2.2 version but missing in an upgraded one. It seems that they were deleted from both install and upgrade (a934bd23) but later re-introduced @ install.xml by (df997f84).

      This problem might also affects upgrades - see http://moodle.org/mod/forum/discuss.php?d=205937

        Activity

        Hide
        Petr Škoda added a comment -

        eh, there are still tons of orphaned code using these in backup/lib.php and backup/restorelib.php

        Show
        Petr Škoda added a comment - eh, there are still tons of orphaned code using these in backup/lib.php and backup/restorelib.php
        Hide
        Petr Škoda added a comment - - edited

        argh, there are still some includes of backup/lib.php, lets do this code cleanup in 2.4 only, it is such a bloody mess
        the tables should be dropped in 2.2, 2.3 and master

        Show
        Petr Škoda added a comment - - edited argh, there are still some includes of backup/lib.php, lets do this code cleanup in 2.4 only, it is such a bloody mess the tables should be dropped in 2.2, 2.3 and master
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks (22, 23 & master)!

        PS: I've added one extra commit to each branch to get version bumped one extra +.01 (patch ones were already in use).

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks (22, 23 & master)! PS: I've added one extra commit to each branch to get version bumped one extra +.01 (patch ones were already in use).
        Hide
        Petr Škoda added a comment -

        Hmm, I do not think it is likely the forum issue is related.

        Show
        Petr Škoda added a comment - Hmm, I do not think it is likely the forum issue is related.
        Hide
        Rajesh Taneja added a comment -
        1. Installed 2.2.3, 2.3 and master from scratch.
        2. Upgraded 2.2.3 => 2.3 => master
          All worked fine.

        Thanks for fixing this, Petr.

        Show
        Rajesh Taneja added a comment - Installed 2.2.3, 2.3 and master from scratch. Upgraded 2.2.3 => 2.3 => master All worked fine. Thanks for fixing this, Petr.
        Hide
        Sam Hemelryk added a comment -

        Congratulations your code is upstream - gold star for you!

        This issue + 79 others made it in in time for the minor releases.
        Thank you everyone involved for your exuberant efforts.

        Show
        Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: