Moodle

Fatal error: Cannot access protected property xmldb_table::$name in lib/adminlib.php on line 455

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3
  • Fix Version/s: 2.3.1
  • Component/s: Database SQL/XMLDB
  • Labels:

Description

On trying to delete a third-party activity plugin, the following fatal error is displayed:

Fatal error: Cannot access protected property xmldb_table::$name in lib/adminlib.php on line 455

Suggested fix (lib/adminlib.php, line 455):

  • OLD: $table_names[] = strtolower($table->name);
  • NEW: $table_names[] = strtolower($table->getName());

Issue Links

is duplicated by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34193 Can not delete data tables created from a module

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34196 adminlib.php reports error when deleting plugins

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda added a comment -

Thanks a lot for the report with patch and sorry for the trouble.

Show
Petr Škoda added a comment - Thanks a lot for the report with patch and sorry for the trouble.
Hide
Permalink
Dan Poltawski added a comment -

Integrated, thanks Gordon/Petr.

Show
Dan Poltawski added a comment - Integrated, thanks Gordon/Petr.
Hide
Permalink
Adrian Greeve added a comment -

Tested in master to replicate the problem and then master integration. The Fatal error is no longer raised. No other problems encountered.
Test passed.

Show
Adrian Greeve added a comment - Tested in master to replicate the problem and then master integration. The Fatal error is no longer raised. No other problems encountered. Test passed.
Hide
Permalink
Sam Hemelryk added a comment -

Congratulations your code is upstream - gold star for you!

This issue + 79 others made it in in time for the minor releases.
Thank you everyone involved for your exuberant efforts.

Show
Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

People

Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: