Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.3
-
Fix Version/s: 2.3.1
-
Component/s: Database SQL/XMLDB
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_23_STABLE
-
Fixed Branches:MOODLE_23_STABLE
-
Pull from Repository:
-
Pull Master Branch:w27_
MDL-34125_m24_tablename -
Pull Master Diff URL:
Description
On trying to delete a third-party activity plugin, the following fatal error is displayed:
Fatal error: Cannot access protected property xmldb_table::$name in lib/adminlib.php on line 455
Suggested fix (lib/adminlib.php, line 455):
- OLD: $table_names[] = strtolower($table->name);
- NEW: $table_names[] = strtolower($table->getName());
Gliffy Diagrams
Issue Links
Activity
Integrated, thanks Gordon/Petr.
Show
Dan Poltawski
added a comment - Integrated, thanks Gordon/Petr.
Tested in master to replicate the problem and then master integration. The Fatal error is no longer raised. No other problems encountered.
Test passed. 
Show
Adrian Greeve
added a comment - Tested in master to replicate the problem and then master integration. The Fatal error is no longer raised. No other problems encountered.
Test passed.
Congratulations your code is upstream - gold star for you!
This issue + 79 others made it in in time for the minor releases.
Thank you everyone involved for your exuberant efforts.
Show
Sam Hemelryk
added a comment - Congratulations your code is upstream - gold star for you!
This issue + 79 others made it in in time for the minor releases.
Thank you everyone involved for your exuberant efforts.
Thanks a lot for the report with patch and sorry for the trouble.