[MDL-34130] Add more recordset related unit tests - Moodle Tracker

Details

Type: Improvement
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 2.2, 2.3, 2.4
Fix Version/s: 2.3.1
Component/s: Database SQL/XMLDB
Labels:
None

Testing Instructions:

Hide

1/ run phpunit tests
2/ ignore problems in sqlsrv driver (it is known to be borked, see linked issues)

Show
1/ run phpunit tests 2/ ignore problems in sqlsrv driver (it is known to be borked, see linked issues)
Affected Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://github.com/skodak/moodle.git
Pull Master Branch:
w27_~~MDL-34130~~_m24_recordsettests
Pull Master Diff URL:
https://github.com/skodak/moodle/compare/master...w27_MDL-34130_m24_recordsettests

Description

1/ verify nested recordset works
2/ verify transactions work when in recordset
3/ verify the recordsets are static (do not change after later update/delete queries)

Problems are expected mostly in sqlsrv driver, see MDL-34069 and friends. This issue is not supposed to fix these existing problems...

Gliffy Diagrams

Attachments

Issue Links

has been marked as being related by

MDL-37734 POLICY: sqlsrv driver, to be or not to be

Closed

will help resolve

MDL-34069 Bulk Delete of Users Fails on MS SQL Server

Open

MDL-34079 Error when running Cron on MS SQL Server

Closed

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 02/Jul/12 4:03 AM

Integrated, thanks! (23 and master)

Show

Eloy Lafuente (stronk7) added a comment - 02/Jul/12 4:03 AM Integrated, thanks! (23 and master)

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 02/Jul/12 4:29 AM

Tested the complete dml tests are passing without problems under:

MySQL
PostgreSQL
MSSQL (freeTDS): 2 exceptions, about mssql_data_seek(), not dangerous and 100% unrelated with the nested recordsets and transactions problems.
Oracle: 1 failure, about non ANSI concat of nulls

So I'm passing this. It would be great if somebody could paste here the problems happening with the sqlsrv driver, TIA!

Show

Eloy Lafuente (stronk7) added a comment - 02/Jul/12 4:29 AM Tested the complete dml tests are passing without problems under: MySQL PostgreSQL MSSQL (freeTDS): 2 exceptions, about mssql_data_seek(), not dangerous and 100% unrelated with the nested recordsets and transactions problems. Oracle: 1 failure, about non ANSI concat of nulls So I'm passing this. It would be great if somebody could paste here the problems happening with the sqlsrv driver, TIA!

Hide

Permalink

Petr Skoda added a comment - 02/Jul/12 4:36 AM - edited

sqlsrv on Windows 8 using 3.0 driver - MARS enabled in our sqlsrv driver

c:\server\workspace\moodle>phpunit dml_testcase lib/dml/tests/dml_test.php

PHPUnit 3.6.11 by Sebastian Bergmann.

Configuration read from C:\server\workspace\moodle\phpunit.xml

................................................................. 65 / 87 ( 74%)

..............EEF.....

Time: 10 seconds, Memory: 38.50Mb

There were 2 errors:

1) dml_testcase::test_nested_transactions

dml_read_exception: Error reading from database (SQLState: 42000<br>

Error Code: 3988<br>

Message: [Microsoft][SQL Server Native Client 11.0][SQL Server]New transaction is not allowed because there are other threads running in the session.<br>

native sqlsrv_begin_transaction

[NULL])

C:\server\workspace\moodle\lib\dml\moodle_database.php:407

C:\server\workspace\moodle\lib\dml\sqlsrv_native_moodle_database.php:258

C:\server\workspace\moodle\lib\dml\sqlsrv_native_moodle_database.php:1368

C:\server\workspace\moodle\lib\dml\moodle_database.php:2101

C:\server\workspace\moodle\lib\dml\tests\dml_test.php:4226

C:\Program Files (x86)\PHP\v5.3\phpunit:46

To re-run:

 phpunit dml_testcase C:\server\workspace\moodle\lib\dml\tests\dml_test.php

2) dml_testcase::test_transactions_forbidden

dml_transaction_exception: Database transaction error (This code can not be excecuted in transaction)

C:\server\workspace\moodle\lib\dml\moodle_database.php:2076

C:\server\workspace\moodle\lib\dml\tests\dml_test.php:4251

C:\Program Files (x86)\PHP\v5.3\phpunit:46

To re-run:

 phpunit dml_testcase C:\server\workspace\moodle\lib\dml\tests\dml_test.php

--

There was 1 failure:

1) dml_testcase::test_wrong_transactions

Failed asserting that 2 matches expected 0.

C:\server\workspace\moodle\lib\dml\tests\dml_test.php:4302

C:\Program Files (x86)\PHP\v5.3\phpunit:46

To re-run:

 phpunit dml_testcase C:\server\workspace\moodle\lib\dml\tests\dml_test.php

FAILURES!

Tests: 87, Assertions: 970, Failures: 1, Errors: 2.

c:\server\workspace\moodle>

Show

Petr Skoda added a comment - 02/Jul/12 4:36 AM - edited sqlsrv on Windows 8 using 3.0 driver - MARS enabled in our sqlsrv driver c:\server\workspace\moodle>phpunit dml_testcase lib/dml/tests/dml_test.php PHPUnit 3.6.11 by Sebastian Bergmann. Configuration read from C:\server\workspace\moodle\phpunit.xml ................................................................. 65 / 87 ( 74%) ..............EEF..... Time: 10 seconds, Memory: 38.50Mb There were 2 errors: 1) dml_testcase::test_nested_transactions dml_read_exception: Error reading from database (SQLState: 42000<br> Error Code: 3988<br> Message: [Microsoft][SQL Server Native Client 11.0][SQL Server]New transaction is not allowed because there are other threads running in the session.<br> native sqlsrv_begin_transaction [NULL]) C:\server\workspace\moodle\lib\dml\moodle_database.php:407 C:\server\workspace\moodle\lib\dml\sqlsrv_native_moodle_database.php:258 C:\server\workspace\moodle\lib\dml\sqlsrv_native_moodle_database.php:1368 C:\server\workspace\moodle\lib\dml\moodle_database.php:2101 C:\server\workspace\moodle\lib\dml\tests\dml_test.php:4226 C:\Program Files (x86)\PHP\v5.3\phpunit:46 To re-run: phpunit dml_testcase C:\server\workspace\moodle\lib\dml\tests\dml_test.php 2) dml_testcase::test_transactions_forbidden dml_transaction_exception: Database transaction error (This code can not be excecuted in transaction) C:\server\workspace\moodle\lib\dml\moodle_database.php:2076 C:\server\workspace\moodle\lib\dml\tests\dml_test.php:4251 C:\Program Files (x86)\PHP\v5.3\phpunit:46 To re-run: phpunit dml_testcase C:\server\workspace\moodle\lib\dml\tests\dml_test.php -- There was 1 failure: 1) dml_testcase::test_wrong_transactions Failed asserting that 2 matches expected 0. C:\server\workspace\moodle\lib\dml\tests\dml_test.php:4302 C:\Program Files (x86)\PHP\v5.3\phpunit:46 To re-run: phpunit dml_testcase C:\server\workspace\moodle\lib\dml\tests\dml_test.php FAILURES! Tests: 87, Assertions: 970, Failures: 1, Errors: 2. c:\server\workspace\moodle>

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 02/Jul/12 7:20 AM

Closing this as fixed, changes are now available upstream.

Big thanks!

Show

Eloy Lafuente (stronk7) added a comment - 02/Jul/12 7:20 AM Closing this as fixed, changes are now available upstream. Big thanks!

People

Assignee:

Petr Skoda

Reporter:

Petr Skoda

Integrator:

Eloy Lafuente (stronk7)

Tester:

Eloy Lafuente (stronk7)

Participants:

Eloy Lafuente (stronk7), Petr Skoda

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

02/Jul/12 3:21 AM

Updated:

28/Jan/13 12:19 PM

Resolved:

02/Jul/12 7:20 AM

Fix Release Date:

9/Jul/12