Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.3.1
    • Fix Version/s: 2.3.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Select Anomaly in Theme selector
      2. Purge your caches
      3. Dock a couple of blocks
      4. TEST docked blocks and:
        --Ensure the title display correctly when you mouse over
        --Ensure the content of the block is shown correctly (not floating right)
      Show
      Select Anomaly in Theme selector Purge your caches Dock a couple of blocks TEST docked blocks and: --Ensure the title display correctly when you mouse over --Ensure the content of the block is shown correctly (not floating right)
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-33987_master

      Description

      This is a tidy up following on from MDL-33987

        Gliffy Diagrams

          Activity

          Hide
          Mary Evans added a comment -

          I had already done these for MDL-33987 so used same commits to save time

          Show
          Mary Evans added a comment - I had already done these for MDL-33987 so used same commits to save time
          Hide
          Mary Evans added a comment -

          Martin, I've fixed the float which was causing the wide docked panel.

          Show
          Mary Evans added a comment - Martin, I've fixed the float which was causing the wide docked panel.
          Hide
          Sam Hemelryk added a comment -

          Thanks Mary, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Mary, this has been integrated now
          Hide
          Jason Fowler added a comment -

          This probably isn't normal – see attachement

          Show
          Jason Fowler added a comment - This probably isn't normal – see attachement
          Hide
          Jason Fowler added a comment -

          Sorry, it appears there has been something wrong with my update script, so my integration version of moodle master/2.3 hasn't been updated - will retest this as soon as it is fixed, and will comment back with actual results then

          Show
          Jason Fowler added a comment - Sorry, it appears there has been something wrong with my update script, so my integration version of moodle master/2.3 hasn't been updated - will retest this as soon as it is fixed, and will comment back with actual results then
          Hide
          Jason Fowler added a comment -

          Yeah, after successfully updating my installation, this test passes

          Show
          Jason Fowler added a comment - Yeah, after successfully updating my installation, this test passes
          Hide
          Dan Poltawski added a comment -

          Resetting test as requested by Jason.

          Show
          Dan Poltawski added a comment - Resetting test as requested by Jason.
          Hide
          Jason Fowler added a comment -

          All good

          Show
          Jason Fowler added a comment - All good
          Hide
          Mary Evans added a comment -

          @Jason
          Thanks!

          Show
          Mary Evans added a comment - @Jason Thanks!
          Hide
          Sam Hemelryk added a comment -

          Congratulations your code is upstream - gold star for you!

          This issue + 79 others made it in in time for the minor releases.
          Thank you everyone involved for your exuberant efforts.

          Show
          Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: